Changes in Makefile

4741f854 - Add accelerated arm64 sha512 to libmd

Fri, 19 Nov 2021 11:32:58 +0000

Add accelerated arm64 sha512 to libmdAs with sha256 add support for accelerated sha512 support to libmd onarm64. This depends on clang 13+ to build as this is the first releasewith the needed intrinsics. Gcc should also support them, however froma currently unknown release.Reviewed by: cemSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D33373(cherry picked from commit 71bf1c4cc5b21e7e5740514c1bc6ad751f312eea) List of files: /freebsd-13.1/lib/libmd/Makefile

757a39b1 - Use arm64 sha256 intrinsics in libmd

Fri, 23 Jul 2021 09:14:03 +0000

Use arm64 sha256 intrinsics in libmdSummary:When running on a CPU that supports the arm64 sha256 intrinsics use themto improve perfromance of sha256 calculations.With this changethe following improvement has been seen on an Apple M1with FreeBS running under Parallels, with similar results on aNeoverse-N1 r3p1.x sha256.orig+ sha256.arm64+--------------------------------------------------------------------+|++ x x||+++ xxx|||A |A||+--------------------------------------------------------------------+ N Min Max Median Avg Stddevx 5 3.41 3.5 3.46 3.458 0.042661458+ 5 0.47 0.54 0.5 0.504 0.027018512Difference at 95.0% confidence -2.954 +/- 0.0520768 -85.4251% +/- 0.826831% (Student's t, pooled s = 0.0357071)Reviewed by: cemSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D31284(cherry picked from commit 69d8dc20be6ca10cf87c98223121c4121aff42cc) List of files: /freebsd-13.1/lib/libmd/Makefile

da6e5efe - libmd: add dependency workaround for r366344

Fri, 02 Oct 2020 14:00:52 +0000

libmd: add dependency workaround for r366344r366344 fixed and reenabled the assembly optimized skein implementation,but skein_block objects were not being rebuilt in no-clean builds. Thisresulted in failing no-clean builds. SKEIN_USE_ASM controls whichroutines come from C vs assembly, and with no explicit dependencyr366344's change to SKEIN_USE_ASM did not cause skein_block.{o,pico}to be rebuilt.Add a dependency on this Makefile for the skein_block objects. Thisdependency is broader in scope than absolutely required (that is, theskein_block objects will now be rebuilt on any change to this Makefile).There are ways this could be addressed, but it is probably not worth theadditional effort or testing time to pursue them.PR: 248221Reported by: kevans, Jeremy FaulknerDiscussed with: kevansSponsored by: The FreeBSD Foundation List of files: /freebsd-13.1/lib/libmd/Makefile

36972ee3 - libmd: fix assembly optimized skein implementation

Thu, 01 Oct 2020 21:05:50 +0000

libmd: fix assembly optimized skein implementationThe assembly implementation incorrectly used logical AND instead ofbitwise AND. Fix, and re-enable in libmd.Submitted by: Yang Zhong Reviewed by: cem (earlier)Sponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D26614 List of files: /freebsd-13.1/lib/libmd/Makefile

0d2c19d0 - libmd: temporarily disable optimized assembly skein1024 implementation

Thu, 23 Jul 2020 18:55:47 +0000

libmd: temporarily disable optimized assembly skein1024 implementationIt is apparently broken when assembled by contemporary GNU as as well asClang IAS (which is used in the default configuration).PR: 248221Reported by: pizzamigSponsored by: The FreeBSD Foundation List of files: /freebsd-13.1/lib/libmd/Makefile

7425ce4b - Remove warning that is no longer accurate after r361853

Wed, 15 Jul 2020 17:24:34 +0000

Remove warning that is no longer accurate after r361853We now build the skein assembly with clangs integrated assembler.Reviewed By: emasteDifferential Revision: https://reviews.freebsd.org/D25664 List of files: /freebsd-13.1/lib/libmd/Makefile

24ed6f55 - Rename skein_block_asm.s to .S and assemble using Clang IAS

Sat, 06 Jun 2020 00:35:41 +0000

Rename skein_block_asm.s to .S and assemble using Clang IASComparing the object files produced by GNU as 2.17.50 and Clang IASshows many immaterial changes in strtab etc., and one material changein .text: 1bac: 4c 8b 4f 18 mov 0x18(%rdi),%r9 1bb0: eb 0e jmp 1bc0 - 1bb2: 66 66 2e 0f 1f 84 00 data16 nopw %cs:0x0(%rax,%rax,1)- 1bb9: 00 00 00 00- 1bbd: 0f 1f 00 nopl (%rax)+ 1bb2: 66 2e 0f 1f 84 00 00 nopw %cs:0x0(%rax,%rax,1)+ 1bb9: 00 00 00+ 1bbc: 0f 1f 40 00 nopl 0x0(%rax) 0000000000001bc0 : Skein1024_block_loop(): 1bc0: 4c 8b 47 10 mov 0x10(%rdi),%r8 1bc4: 4c 03 85 c0 00 00 00 add 0xc0(%rbp),%r8That is, GNU as and Clang's integrated assembler use different multi-byte NOPs for alignment (GNU as emits an 11 byte NOP + a 3 byte NOP,while Clang IAS emits a 10 byte NOP + a 4 byte NOP).Dependency cleanup hacks are not required, because we do not create.depend files from GNU as.Reviewed by: allanjude, arichardson, cem, tsoomeSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D8434 List of files: /freebsd-13.1/lib/libmd/Makefile

f2b86886 - Also pass SKEIN_USE_ASM to the assembler, via AFLAGS

Fri, 05 Jun 2020 18:56:43 +0000

Also pass SKEIN_USE_ASM to the assembler, via AFLAGS List of files: /freebsd-13.1/lib/libmd/Makefile

310e81ae - Apply C SKEIN_LOOP setting only to skein_block.c

Fri, 05 Jun 2020 17:00:38 +0000

Apply C SKEIN_LOOP setting only to skein_block.cOtherwise if assembling skein_block_asm.s with Clang's integrated assemblerwe can pass conflicting SKEIN_LOOP settings (via CFLAGS and ACFLAGS). List of files: /freebsd-13.1/lib/libmd/Makefile

a7b5a3d4 - pkgbase: Put a lot of binaries and lib in FreeBSD-runtime

Thu, 05 Sep 2019 14:13:08 +0000

pkgbase: Put a lot of binaries and lib in FreeBSD-runtimeAll of them are needed to be able to boot to single user and be ableto repair a existing FreeBSD installation so put them directly intoFreeBSD-runtime.Reviewed by: bapt, gjbDifferential Revision: https://reviews.freebsd.org/D21503 List of files: /freebsd-13.1/lib/libmd/Makefile

01a9c323 - r338270 had the side effect of no longer installing libmd.so into /lib.

Sun, 26 Aug 2018 17:05:43 +0000

r338270 had the side effect of no longer installing libmd.so into /lib.For users who have a seperate zfs mount of /usr or /usr/lib, this willcause dynamic loading failures when attempting to execute zfs mount onbootup. E.g. the system won't boot.Including sets SHLIBDIR, so SHLIBDIR?= has noeffect. The other lib/ Makefiles solve this problem by moving theSHLIBDIR assignment to before .include .Submitted by: jillesReviewed by: allanjudeApproved by: re (rgrimes)Differential Revision: https://reviews.freebsd.org/D16910 List of files: /freebsd-13.1/lib/libmd/Makefile

c91575ce - Don't build skein_block_asm.s if we don't have an as binary

Thu, 23 Aug 2018 18:19:33 +0000

Don't build skein_block_asm.s if we don't have an as binaryThis fixes building libmd on MacOS/Linux. The real fix is probably tobuild it as a .S file with $CC instead. It might also be better to justcompile the C file in userspace since the compiler can the use SSE/AVX.Reviewed By: emaste, brooksApproved By: jhb (mentor)Differential Revision: https://reviews.freebsd.org/D16844 List of files: /freebsd-13.1/lib/libmd/Makefile

078018e0 - Allow bootstrapping libmd on MacOS

Mon, 20 Aug 2018 10:39:48 +0000

Allow bootstrapping libmd on MacOSThe assembly files use directives that only work for ELF targets so skipthem when bootstrapping on MacOS.Reviewed By: impApproved By: jhb (mentor)Differential Revision: https://reviews.freebsd.org/D14247 List of files: /freebsd-13.1/lib/libmd/Makefile

8ff3cdd1 - Integrate SHA2-224 with userspace components

Mon, 09 Jul 2018 08:19:04 +0000

Integrate SHA2-224 with userspace componentsThe double compilation of the kernel sources in libmd and libcrypt isbaffling, but add yet another define hack to prevent duplicate symbols.Add documentation and SHA2-224 test cases to libmd.Integrate with the md5(1) command, document, and add more test cases;self-tests pass. List of files: /freebsd-13.1/lib/libmd/Makefile

25316863 - Revert r334090.

Wed, 23 May 2018 17:01:28 +0000

Revert r334090.It causes the 32bit compat build of libmd to fail with:libmd/rmd160c.c:86:9: error: 'ripemd160_block' macro redefined#define ripemd160_block ripemd160_block_x86 ^libmd/ripemd.h:122:9: note: previous definition is here#define ripemd160_block _libmd_ripemd160_block List of files: /freebsd-13.1/lib/libmd/Makefile

272b99f7 - libmd: build with WARNS=1

Wed, 23 May 2018 11:20:16 +0000

libmd: build with WARNS=1- build with WARNS=1. This works without any changes- remove two unused variables noticed at WARNS=2 List of files: /freebsd-13.1/lib/libmd/Makefile

929b476a - Increase loop unrolling for skein hashes

Sat, 01 Jul 2017 21:18:06 +0000

Increase loop unrolling for skein hashesThis patch was inspired by an opposite change made to shrink the codefor the boot loader.On my i7-4770, it increases the skein1024 speed from 470 to 550 MB/sReviewed by: sbrunoMFC after: 1 monthSponsored by: ScaleEngine Inc.Differential Revision: https://reviews.freebsd.org/D7824 List of files: /freebsd-13.1/lib/libmd/Makefile

a1b9cad5 - Fix bootstrapping libmd on older systems after r314709.

Mon, 06 Mar 2017 21:06:55 +0000

Fix bootstrapping libmd on older systems after r314709.This follows another fix to bootstrap libmd after r313404. TheMD5FileChunk prototype is needed to build libmd, but it isonly reliably in the src tree's sys/md5.h header. Rather thanpolluting the legacy build with this header for the entire build,just symlink it in here for now as is done in the elftoolchainbuild. Libmd is already referencing other src tree headers byits used of CFLAGS+= ${SRCTOP}/sys/crypto/sha2. This, andother uses of CFLAGS+= ${SRCTOP}/sys..., may later change tobe in the legacy mechanism.Reported by: bde, ian, sjgTested by: ian List of files: /freebsd-13.1/lib/libmd/Makefile

49233bae - Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones

Fri, 20 Jan 2017 04:43:21 +0000

Use SRCTOP-relative paths to other directories instead of .CURDIR-relative onesThis simplifies pathing in make/displayed outputMFC after: 3 weeksSponsored by: Dell EMC Isilon List of files: /freebsd-13.1/lib/libmd/Makefile

60a4cd84 - libmd: strip local absolute symbols (to link with lld)

Thu, 21 Jul 2016 18:47:51 +0000

libmd: strip local absolute symbols (to link with lld)Old versions of gas produce an invalid section index. That is ignored byold versions of ld, but prevents a link with lld.Submitted by: Rafael Ávila de Espíndola (earlier version)Reviewed by: allanjudeSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D6789 List of files: /freebsd-13.1/lib/libmd/Makefile