Changes in Makefile

c1a3d7f2 - Remove remaining uses of ${COMPILER_FEATURES:Mc++11}

Tue, 19 Jan 2021 15:05:43 +0000

Remove remaining uses of ${COMPILER_FEATURES:Mc++11}All supported compilers have C++11 support so these checks can be replacedwith MK_CXX guards.See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252759PR: 252759Reviewed By: emasteDifferential Revision: https://reviews.freebsd.org/D28234 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

2d143336 - Enable long double tests on RISC-V

Wed, 24 Jun 2020 13:11:19 +0000

Enable long double tests on RISC-VSome of the NetBSD contributed tests are gated behind the__HAVE_LONG_DOUBLE flag. This flag seems to be defined only forplatforms whose long double is larger than their double. I could notfind this explicitly documented anywhere, but it is implied by thedefinitions in NetBSD's sys/arch/${arch}/include/math.h headers, and thefollowing assertion from the UBSAN code: #ifdef __HAVE_LONG_DOUBLE long double LD; ASSERT(sizeof(LD) > sizeof(uint64_t)); #endifRISC-V has 128-bit long doubles, so enable the tests on this platform,and update the comments to better explain the purpose of this flag.Reviewed by: ngieMFC after: 1 weekDifferential Revision: https://reviews.freebsd.org/D25419 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

6507380f - Add qsort_r(3) regression test.

Mon, 20 Jan 2020 11:45:18 +0000

Add qsort_r(3) regression test.MFC after: 2 weeksSponsored by: DARPADifferential Revision: https://reviews.freebsd.org/D23206 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

0d2fabfc - Add qsort_s(3). Apart from the constraints, it also makes it easier

Mon, 20 Jan 2020 11:40:07 +0000

Add qsort_s(3). Apart from the constraints, it also makes it easierto port software written for Linux variant of qsort_r(3).Reviewed by: kib, arichardsonMFC after: 2 weeksRelnotes: yesSponsored by: DARPADifferential Revision: https://reviews.freebsd.org/D23174 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

24612bfd - Unskip test cases from netbsd-tests by defining __HAVE_FENV

Sat, 31 Aug 2019 20:45:45 +0000

Unskip test cases from netbsd-tests by defining __HAVE_FENVThis unskips: - lib.libc.stdlib.strtod_test.strtod_round - lib.msun.fe_round_test.t_nofe_roundIn lib/msun/tests/Makefile only define on fe_round_test.c becauselib.msun.ilogb_test.ilogb will get wrong results and needs more examination.MFC after: 1 weekSponsored by: The FreeBSD Foundation List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

0eb97cca - Allow users to override CSTD/CXXSTD on a per-prog basis

Fri, 29 Mar 2019 18:49:08 +0000

Allow users to override CSTD/CXXSTD on a per-prog basisThe current logic for CSTD/CXXSTD requires homogenity as far as thesupported C/C++ standards, which is a sensible default. However, whendealing with differing versions of C++, some code may compile with C++11, butnot C++17 (for instance). So in order to avoid having people convert over theircode to the new standard, give the users the ability to specify the standard ona per-program basis.This will allow a user to override the supporting standard for a set ofprograms, mixing C++11 with C++14 (for instance).Reviewed by: asomersApprved by: emaste (mentor)MFC after: 1 monthMFC with: r345708Differential Revision: https://reviews.freebsd.org/D19738 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

bdbf3440 - Revert r345706: the third time will be the charm

Fri, 29 Mar 2019 18:43:46 +0000

Revert r345706: the third time will be the charmWhen a review is closed via Phabricator it updates the patch attached to thereview. I downloaded the raw patch from Phabricator, applied it, and repeatedmy mistake from r345704 by accident mixing content from D19732 and D19738.For my own personal sanity, I will try not to mix reviews like this in thefuture.MFC after: 1 monthMFC with: r345706Approved by: emaste (mentor, implicit) List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

760b1a81 - Standardize `-std=c++* as `CXXSTD`

Fri, 29 Mar 2019 18:31:48 +0000

Standardize `-std=c++* as `CXXSTD`CXXSTD was added as the C++ analogue to CSTD.CXXSTD defaults to `-std=c++11` with supporting compilers; `-std=gnu++98`,otherwise for older versions of g++.This change standardizes the CXXSTD variable, originally added togoogletest.test.inc.mk as part of r345203.As part of this effort, convert all `CXXFLAGS+= -std=*` calls to use `CXXSTD`.Notes:This value is not sanity checked in bsd.sys.mk, however, given the twomost used C++ compilers on FreeBSD (clang++ and g++) support both modes, it islikely to work with both toolchains. This method will be refined in the futureto support more variants of C++, as not all versions of clang++ and g++ (forinstance) support C++14, C++17, etc.Any manual appending of `-std=*` to `CXXFLAGS` should be replaced with CXXSTD.Example:Before this commit:```CXXFLAGS+= -std=c++14```After this commit:```CXXSTD= c++14```Reviewed by: asomersApproved by: emaste (mentor)MFC after: 1 monthMFC with: r345203, r345704, r345705Relnotes: yesTested with: make tinderboxDifferential Revision: https://reviews.freebsd.org/D19732 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

752cabaa - Revert r345704

Fri, 29 Mar 2019 18:16:33 +0000

Revert r345704I accidentally committed code from two reviews. I will reintroduce the code tobsd.progs.mk as part of a separate commit from r345704.Approved by: emaste (mentor, implicit)MFC after: 2 monthsMFC with: r345704 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

9a41926b - CXXSTD is the C++ analogue to CSTD.

Fri, 29 Mar 2019 18:13:44 +0000

CXXSTD is the C++ analogue to CSTD.CXXSTD defaults to `-std=c++11` with supporting compilers; `-std=gnu++98`,otherwise for older versions of g++.This change standardizes the CXXSTD variable, originally added togoogletest.test.inc.mk as part of r345203.As part of this effort, convert all `CXXFLAGS+= -std=*` calls to use `CXXSTD`.Notes:This value is not sanity checked in bsd.sys.mk, however, given the twomost used C++ compilers on FreeBSD (clang++ and g++) support both modes, it islikely to work with both toolchains. This method will be refined in the futureto support more variants of C++, as not all versions of clang++ and g++ (forinstance) support C++14, C++17, etc.Any manual appending of `-std=*` to `CXXFLAGS` should be replaced with CXXSTD.Example:Before this commit:```CXXFLAGS+= -std=c++14```After this commit:```CXXSTD= c++14```Reviewed by: asomersApproved by: emaste (mentor)MFC after: 1 monthRelnotes: yesDifferential Revision: https://reviews.freebsd.org/D19732 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

9303f819 - libc/tests: Add test case for jemalloc/libthr bug fixed in r343566

Thu, 31 Jan 2019 02:49:24 +0000

libc/tests: Add test case for jemalloc/libthr bug fixed in r343566Submitted by: Andrew Gierth (original reproducer; kevans massaged for atf)Reviewed by: kibMFC after: 2 weeksX-MFC-with: r343566 (or after)Differential Revision: https://reviews.freebsd.org/D19027 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

8c1c50ff - Allow multi-byte thousands separators in strfmon(3)

Wed, 19 Dec 2018 22:57:47 +0000

Allow multi-byte thousands separators in strfmon(3)PR: 234010Reported by: Jon Tejnung Reviewed by: yuripvDifferential Revision: https://reviews.freebsd.org/D18605 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

9851b340 - Implement the memset_s(3) function as specified by the C11 ISO/IEC

Thu, 30 Mar 2017 04:57:26 +0000

Implement the memset_s(3) function as specified by the C11 ISO/IEC9899:2011 Appendix K 3.7.4.1.Other needed supporting types, defines and constraint_handlerinfrastructure is added as specified in the C11 spec.Submitted by: Tom Rix Sponsored by: Juniper NetworksDiscussed with: edMFC after: 3 weeksDifferential revision: https://reviews.freebsd.org/D9903Differential revision: https://reviews.freebsd.org/D10161 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

9527fa4f - Remove __HAVE_LONG_DOUBLE #define from t_strtod.c and place it in Makefile

Thu, 12 Jan 2017 08:40:52 +0000

Remove __HAVE_LONG_DOUBLE #define from t_strtod.c and place it in MakefileThis is to enable support in other testcasesInspired by lib/msun/tests/Makefile .MFC after: 1 week List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

b585cd3e - Add __cxa_thread_atexit(3) API implementation.

Sat, 06 Aug 2016 13:32:40 +0000

Add __cxa_thread_atexit(3) API implementation.This is the backing feature to implement C++11 thread storage durationspecified by the thread_local keyword. A destructor for giventhread-local object is registered to be executed at the threadtermination time using __cxa_thread_atexit(). Libc calls the__cxa_thread_calls_dtors() during exit(3), before finalizers andatexit functions, and libthr calls the function at the threadtermination time, after the stack unwinding and thread-specific keydestruction.There are several uncertainties in the API which lacks a formalspecification. Among them:- is it allowed to register destructors during destructing; we allow, but limiting the nesting level. If too many iterations detected, a diagnostic is issued to stderr and thread forcibly terminates for now.- how to handle destructors which belong to an unloading dso; for now, we ignore destructor calls for such entries, and issue a diagnostic. Linux does prevent dso unload until all threads with destructors from the dso terminated.It is supposed that the diagnostics allow to detect real-worldapplications relying on the above details and possibly adjustour implementation. Right now the choices were to provide the slimAPI (but that rarely stands the practice test).Tests are added to check generic functionality and to specify some ofthe above implementation choices.Submitted by: Mahdi Mokhtari Reviewed by: theravenDiscussed with: dim (detection of -std=c++11 supoort for tests)Sponsored by: The FreeBSD Foundation (my involvement)MFC after: 2 weeksDifferential revisions: https://reviews.freebsd.org/D7224, https://reviews.freebsd.org/D7427 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

430f7286 - Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed

Wed, 04 May 2016 23:20:53 +0000

Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed- Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously.- Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.- Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo- Remove unnecessary .include s (some opportunistic cleanup)Document the proposed changes in share/examples/tests/tests/... via examplesso it's clear that ${PACKAGES}FILES is the suggested way forward in terms ofreplacing FILES. share/mk/bsd.README didn't seem like the appropriate methodof communicating that info.MFC after: never probablyX-MFC with: r298107PR: 209114Relnotes: yesTested with: buildworld, installworld, checkworld; buildworld, packageworldSponsored by: EMC / Isilon Storage Division List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

43faedc1 - First pass to fix the 'tests' packages.

Tue, 02 Feb 2016 22:26:49 +0000

First pass to fix the 'tests' packages.Sponsored by: The FreeBSD Foundation List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

459d04a5 - Let tsearch()/tdelete() use an AVL tree.

Tue, 22 Dec 2015 18:12:11 +0000

Let tsearch()/tdelete() use an AVL tree.The existing implementations of POSIX tsearch() and tdelete() don'tattempt to perform any balancing at all. Testing reveals that inserting100k nodes into a tree sequentially takes approximately one minute on mysystem.Though most other BSDs also don't use any balanced tree internally, Clibraries like glibc and musl do provide better implementations. glibcuses a red-black tree and musl uses an AVL tree.Red-black trees have the advantage over AVL trees that they only requireO(1) rotations after insertion and deletion, but have the disadvantagethat the tree has a maximum depth of 2*log2(n) instead of 1.44*log2(n).My take is that it's better to focus on having a lower maximum depth,for the reason that in the case of tsearch() the invocation of thecomparator likely dominates the running time.This change replaces the tsearch() and tdelete() functions by versionsthat create an AVL tree. Compared to musl's implementation, this versionis different in two different ways:- We don't keep track of heights; just balances. This is sufficient. This has the advantage that it reduces the number of nodes that are being accessed. Storing heights requires us to also access all of the siblings along the path.- Don't use any recursion at all. We know that the tree cannot 2^64 elements in size, so the height of the tree can never be larger than 96. Use a 128-bit bitmask to keep track of the path that is computed. This allows us to iterate over the same path twice, meaning we can apply rotations from top to bottom.Inserting 100k nodes into a tree now only takes 0.015 seconds. Insertionseems to be twice as fast as glibc, whereas deletion has about the sameperformance. Unlike glibc, it uses a fixed amount of memory.I also experimented with both recursive and iterative bottom-upimplementations of the same algorithm. This iterative top-down versionperforms similar to the recursive bottom-up version in terms of speedand code size.For some reason, the iterative bottom-up algorithm was actually 30%faster for deletion, but has a quadratic memory complexity to keep trackof all the parent pointers.Reviewed by: jillesObtained from: https://github.com/NuxiNL/cloudlibcDifferential Revision: https://reviews.freebsd.org/D4412 List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

eacae6dc - Fix LDADD/DPADD that should be LIBADD.

Fri, 04 Dec 2015 03:17:47 +0000

Fix LDADD/DPADD that should be LIBADD.Sponsored by: EMC / Isilon Storage Division List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile

98682851 - Integrate tools/regression/lib/libc/stdlib into the FreeBSD test suite

Sun, 08 Nov 2015 07:03:17 +0000

Integrate tools/regression/lib/libc/stdlib into the FreeBSD test suiteas lib/libc/tests/stdlib- Make the code a bit more style(9) compliant- Convert a sizeof(x)/sizeof(x[0]) to nitemsMFC after: 1 weekSponsored by: EMC / Isilon Storage Division List of files: /freebsd-13.1/lib/libc/tests/stdlib/Makefile