en Copyright 2015 Java http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#6d95d4c1 MFC r343165 (by jhibbits):Fix top(1) long options handlinggetopt_long(3) requires the long options be terminated by a NULL block.Without the terminator, an invalid long option results in a segmentationfault.Reported by: Brandon BergrenMFC r343957:Fix multiple warnings in usr.bin/top about discarded qualifiers fromboth clang and gcc, by either constifying variables, or when that is notpossible, using __DECONST.MFC r343958:Fix multiple warnings in usr.bin/top about variables shadowing globaldeclarations from base gcc, by renaming those variables.MFC r343959:Fix the first couple of AddressSanitizer violations in usr.bin/top.Avoid setting zero bytes beyond the length of the 'thisline' parametersin i_process() and u_process(), and don't attempt to memset a negativenumber of bytes. List of files: /freebsd-12.1/usr.bin/top/Makefile Wed, 20 Feb 2019 20:28:48 +0000 Dimitry Andric <dim@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#00abcb6a top(1): increase warningstop(1) now builds without cast-qual warnings, so remove the exemptionfor that.Tested with clang, gcc7, gcc9 List of files: /freebsd-12.1/usr.bin/top/Makefile Fri, 22 Jun 2018 10:20:21 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#51c834c4 top(1): reimplement header formatting as sbufThe current header formatting is a giant format string that changesglobal state during the format process.Make the following changes:- use sbuf to build up the header rather than use the abovepseudo-dynamic one- Change name length to 10- Reduce size of RES and SIZE by making humanize more aggressive- Restore a version number line to the copyright. This may be requiredby the copyright (and may not be; its unclear)This is also a pre-req to implementing TOPCOLOR from newer versions oftop(1)Discussed with: allanjude, rpolka, danfe, rgrimesDifferential Revision: https://reviews.freebsd.org/D15801 List of files: /freebsd-12.1/usr.bin/top/Makefile Fri, 22 Jun 2018 09:21:01 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#8e4b205e top(1): format_time, format_k, etc.- Use humanize_number for format_k and format_k2- Fix some style nits in format_time List of files: /freebsd-12.1/usr.bin/top/Makefile Wed, 13 Jun 2018 08:52:09 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#59c50d82 top(1): several small bugfixes and nits- initialize all maybe uninitialized vars with bogus values. This shutsup the compiler, and causes crashes if it changes later.- mark noreturn as noreturn- removed unused macro- handle x_procstate as runtime rather than pre-processor- avoid using void functions in condtionalsTested with clang, gcc 7, gcc 9 List of files: /freebsd-12.1/usr.bin/top/Makefile Wed, 13 Jun 2018 00:45:38 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#fb7b896c top(1): handle 0 in "digits" functions List of files: /freebsd-12.1/usr.bin/top/Makefile Mon, 11 Jun 2018 05:05:20 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#561b0720 top(1): use sys_signame instead of hard coding signalsThis enables the removal of the signal.h awk script. Shamelessly stolenfrom kill(1). List of files: /freebsd-12.1/usr.bin/top/Makefile Sun, 10 Jun 2018 09:00:01 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#b4aadfd2 top(1): filter fewer warnings; clean up- remove WARNS?=6. It is default- we no longer have cast-qual problems- remove unused macros- remove unneeded casts- add include guard for loadavg.h List of files: /freebsd-12.1/usr.bin/top/Makefile Sun, 10 Jun 2018 06:21:51 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#c5484668 top(1): Only use NO_WERROR for base gccThis is what was intended. If statements are hard. List of files: /freebsd-12.1/usr.bin/top/Makefile Sun, 03 Jun 2018 06:02:31 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#1d5b01e6 top(1): use greater warningsOne of the downsides of using numeric WARNS is that if we only have asingle type of issue we get no protection from other changes. Forexample, we got no warning for missing variable declaration, due tothe issues with "const".For this utility, explicitly list out the warnings which are failing.They should still be fixed, so only reduce them to warning instead oferror.Tested with: clang base (amd64, i386), gcc6, gcc7, gcc9, gcc base (mips) List of files: /freebsd-12.1/usr.bin/top/Makefile Sun, 03 Jun 2018 05:07:39 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#6ffc72df top(1): fix buildRemove 'top.local.hs'. This was not noticed since/srv/obj/fbsd/srv/src/freebsd/svn/head/amd64.amd64/usr.bin/top/top.local.hexisted locally on my machine despite "make clean". Only fully removingthe objdir allowed me to observe the error directly.Pointyhat to: me List of files: /freebsd-12.1/usr.bin/top/Makefile Mon, 21 May 2018 09:43:50 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#00157b4c Revert r333969 which contained one too many changes List of files: /freebsd-12.1/usr.bin/top/Makefile Mon, 21 May 2018 09:20:26 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#bfb79c2c top(1): modernize a bit; reduce warnings- Replace caddr_t with "void *". This reducesthe number of warnings at WARNS=6- use "static" where possible- sprinkle const where possibleThis leaves at WARNS=6:35 warnings in top.c72 warnings in machine.c5 warnings in commands.call of which are either "incompatible-pointer-types-discards-qualifiers"or "cast-qual" List of files: /freebsd-12.1/usr.bin/top/Makefile Mon, 21 May 2018 09:18:01 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#1d6a4ba3 top(1): build with WARNS=3This fixes everything but-Wincompatible-pointer-types-discards-qualifiers List of files: /freebsd-12.1/usr.bin/top/Makefile Mon, 21 May 2018 03:58:15 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#4901ca08 top(1): build with WARN=2 List of files: /freebsd-12.1/usr.bin/top/Makefile Mon, 21 May 2018 00:32:48 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#668af25d top(1): pull configuration directly into header filesThis sets configuration variables directly in the various header files,avoiding the need to have special logic in our Makefile to build theheader. List of files: /freebsd-12.1/usr.bin/top/Makefile Sun, 20 May 2018 23:37:30 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#500cd2d6 revert r333928I had missed a file when testing this, and it does not build. Will try again. List of files: /freebsd-12.1/usr.bin/top/Makefile Sun, 20 May 2018 18:02:40 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#808862b2 top(1): remove 'xs' and 'xh' source filesNow that we're our own upstream these files buy us nothing. List of files: /freebsd-12.1/usr.bin/top/Makefile Sun, 20 May 2018 17:58:22 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#8a133278 top(1): unconditionally provide 'FreeBSD' as a version List of files: /freebsd-12.1/usr.bin/top/Makefile Sat, 19 May 2018 23:04:42 +0000 Eitan Adler <eadler@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-12.1/usr.bin/top/Makefile#946e91ab top(1): assume that we're building on FreeBSDThis allows us to avoid the ifdefs that we set unconditionally. List of files: /freebsd-12.1/usr.bin/top/Makefile Sat, 19 May 2018 22:59:58 +0000 Eitan Adler <eadler@FreeBSD.org>