Changes in Makefile

ef87864d - MFC r343362,r343365,r343367,r343368,r343461,r343751,r344310:

Sun, 10 Mar 2019 16:14:42 +0000

MFC r343362,r343365,r343367,r343368,r343461,r343751,r344310:r343362:Add [initial] functional tests for sendfile(2) as lib/libc/sys/sendfileThese testcases exercise a number of functional requirements for sendfile(2).The testcases use IPv4 and IPv6 domain sockets with TCP, and were confirmedfunctional on UFS and ZFS. UDP address family sockets cannot be used per thesendfile(2) contract, thus using UDP sockets is outside the scope oftesting the syscall in positive cases. As seen in`:s_negative_udp_socket_test`, UDP is used to test the sendfile(2) contractto ensure that EINVAL is returned by sendfile(2).The testcases added explicitly avoid testing out `SF_SYNC` due to thecomplexity of verifying that support. However, this is a good next logicalitem to verify.The `hdtr_positive*` testcases work to a certain degree (the headertestcases pass), but the trailer testcases do not work (it is an expectedfailure). In particular, the value received by the mock server doesn't matchthe expected value, and instead looks something like the following (usingpython array notation):`trailer[:]message[1:]`instead of:`message[:]trailer[:]`This makes me think there's a buffer overrun issue or problem with theoffset somewhere in the sendfile(2) system call, but I need to do someother testing first to verify that the code is indeed sane, and myassumptions/code isn't buggy.The `sbytes_negative` testcases that check `sbytes` being set to aninvalid value resulting in `EFAULT` fails today as the other change(which checks `copyout(9)`) has not been committed [1]. Thus, itshould remain an expected failure (see bug 232210 for more detailson this item).Next steps for testing sendfile(2):1. Fix the header/trailer testcases so that they pass.2. Setup if_tap interface and test with it, instead of using "localhost", per @asomers's suggestion.3. Handle short recv(2)'s in `server_cat(..)`.4. Add `SF_SYNC` support.5. Add some more negative tests outside the scope of the functional contract.PR: 232210r343365:Unbreak the gcc build with sendfile_test after r343362gcc 8.x is more pedantic than clang 7.x with format strings and the testspassed `void*` variables while supplying `%s` (which is technicallyincorrect).Make the affected `void*` variables use `char*` storage instead to addressthis issue, as the compiler will upcast the values to `char*`.MFC with: r343362r343367:Unbreak the build on architectures where size_t isn't synonymous with uintmax_tI should have used `%zu` instead of `%ju` with `size_t` types.MFC with: r343362, r343365Pointyhat to: ngier343368:Fix up r343367I should have only changed the format qualifier with the `size_t` value,`length`, not the other [`off_t`] value, `dest_file_size`.MFC with: r343362, r343365, r343367r343461:Fix reporting errors with `gai_strerror(..)`The return value (`err`) should be checked; not the `errno` value.PR: 235200MFC with: r343362, r343365, r343367-r343368r343751:Avoid the DNS lookup for "localhost"ci.FreeBSD.org does not have access to a DNS resolver/network (unlike my testVM), so in order for the test to pass on the host, it needs to avoid the DNSlookup by using the numeric host address representation.PR: 235200MFC with: r343362, r343365, r343367-r343368, r343461r344310:Make `server_cat(..)` handle short receivesIn short, the prior code was far too simplistic when it came to calling recv(2)and failed intermittently (or in the case of Jenkins, deterministically).Handle short recv(2)s by checking the return code and incrementing the windowinto the buffer by the number of received bytes. If the number of receivedbytes <= 0, then bail out of the loop, and test the total number of receivedbytes vs the expected number of bytes sent for equality, and base whether ornot the test passes/fails on that fact.Remove the expected failure, now that the hdtr testcases deterministically passon my host after this change [1].PR: 234809 [1], 235200Approved by: emaste (mentor, implicit: MFC to ^/stable/11 in r344977)Differential Revision: https://reviews.freebsd.org/D19523 List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

ea16e3e1 - Don't build brk_test on platforms that don't support brk().

Tue, 05 Jun 2018 13:06:06 +0000

Don't build brk_test on platforms that don't support brk().X-MFC with: r334626 List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

9f9c9b22 - Reimplement brk() and sbrk() to avoid the use of _end.

Mon, 04 Jun 2018 19:35:15 +0000

Reimplement brk() and sbrk() to avoid the use of _end.Previously, libc.so would initialize its notion of the break addressusing _end, a special symbol emitted by the static linker followingthe bss section. Compatibility issues between lld and ld.bfd couldcause the wrong definition of _end (libc.so's definition rather thanthat of the executable) to be used, breaking the brk()/sbrk()interface.Avoid this problem and future interoperability issues by simply notrelying on _end. Instead, modify the break() system call to returnthe kernel's view of the current break address, and have libcinitialize its state using an extra syscall upon the first use of theinterface. As a side effect, this appears to fix brk()/sbrk() usagein executables run with rtld direct exec, since the kernel and libc.sono longer maintain separate views of the process' break address.PR: 228574Reviewed by: kib (previous version)MFC after: 2 monthsDifferential Revision: https://reviews.freebsd.org/D15663 List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

9f4bf11e - Properly set userid for truncate_test.

Fri, 21 Jul 2017 16:14:06 +0000

Properly set userid for truncate_test.MFC after: 1 weekSponsored by: Dell EMC Isilon List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

3f8455b0 - Add clock_nanosleep()

Sun, 19 Mar 2017 00:51:12 +0000

Add clock_nanosleep()Add a clock_nanosleep() syscall, as specified by POSIX.Make nanosleep() a wrapper around it.Attach the clock_nanosleep test from NetBSD. Adjust it for theFreeBSD behavior of updating rmtp only when interrupted by a signal.I believe this to be POSIX-compliant, since POSIX mentions the rmtpparameter only in the paragraph about EINTR. This is also whatLinux does. (NetBSD updates rmtp unconditionally.)Copy the whole nanosleep.2 man page from NetBSD because it is completeand closely resembles the POSIX description. Edit, polish, and reword ita bit, being sure to keep any relevant text from the FreeBSD page.Reviewed by: kib, ngie, jillesMFC after: 3 weeksRelnotes: yesSponsored by: Dell EMCDifferential Revision: https://reviews.freebsd.org/D10020 List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

710542df - Fix setrlimit_test:setrlimit_memlock when the system has exceeded vm.max_wired.

Thu, 01 Dec 2016 22:12:58 +0000

Fix setrlimit_test:setrlimit_memlock when the system has exceeded vm.max_wired.This uses the same fix as r294894 did for the mlock test. The code fromthat commit is moved into a common object file which PROGS supportsbuilding first.Sponsored by: Dell EMC IsilonDifferential Revision: https://reviews.freebsd.org/D8689 List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

b3ef7604 - Re-add PACKAGE=> tests to lib/libc/tests/net/getaddrinfo/Makefile and add

Mon, 19 Sep 2016 06:59:17 +0000

Re-add PACKAGE=> tests to lib/libc/tests/net/getaddrinfo/Makefile and addit to lib/libc/tests/sys/Makefile [*]Even though make -VPACKAGE and make -n install seem to do the right thing,the effects are a bit different, depending on the build host.MFC after: 1 weekObtained from: HardenedBSD (af602f0db) [*]Reported by: Oliver Pinter [*]Sponsored by: Dell EMC Isilon List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

430f7286 - Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed

Wed, 04 May 2016 23:20:53 +0000

Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed- Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously.- Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.- Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo- Remove unnecessary .include s (some opportunistic cleanup)Document the proposed changes in share/examples/tests/tests/... via examplesso it's clear that ${PACKAGES}FILES is the suggested way forward in terms ofreplacing FILES. share/mk/bsd.README didn't seem like the appropriate methodof communicating that info.MFC after: never probablyX-MFC with: r298107PR: 209114Relnotes: yesTested with: buildworld, installworld, checkworld; buildworld, packageworldSponsored by: EMC / Isilon Storage Division List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

796a99fc - Remove dd xfer stats emitted during buildworld

Thu, 18 Feb 2016 14:17:28 +0000

Remove dd xfer stats emitted during buildworldThey result in gratuitous differences when comparing build log output. List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

1f4bcc45 - More 'tests' packaging fixes.

Wed, 03 Feb 2016 19:08:45 +0000

More 'tests' packaging fixes.Sponsored by: The FreeBSD Foundation List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

43faedc1 - First pass to fix the 'tests' packages.

Tue, 02 Feb 2016 22:26:49 +0000

First pass to fix the 'tests' packages.Sponsored by: The FreeBSD Foundation List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

eacae6dc - Fix LDADD/DPADD that should be LIBADD.

Fri, 04 Dec 2015 03:17:47 +0000

Fix LDADD/DPADD that should be LIBADD.Sponsored by: EMC / Isilon Storage Division List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

f443c488 - Add some initial tests for SLIST and STAILQ macros

Mon, 16 Nov 2015 04:15:39 +0000

Add some initial tests for SLIST and STAILQ macrosMFC after: 1 weekSponsored by: EMC / Isilon Storage Division List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

b2d48be1 - Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) and

Mon, 12 Oct 2015 08:16:03 +0000

Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) andnetbsd-tests.test.mk (r289151)- Eliminate explicit OBJTOP/SRCTOP setting- Convert all ad hoc NetBSD test integration over to netbsd-tests.test.mk- Remove unnecessary TESTSDIR setting- Use SRCTOP where possible for clarityMFC after: 2 weeksSponsored by: EMC / Isilon Storage Divison List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

b5e4c5c4 - Enable mincore_test on arm64, we now have a working pmap_mincore.

Tue, 08 Sep 2015 18:44:12 +0000

Enable mincore_test on arm64, we now have a working pmap_mincore.PR: 202307Obtained from: ABT Systems LtdSponsored by: The FreeBSD Foundation List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

5e3cac3e - On arm64 disable three tests that hang or panic

Mon, 17 Aug 2015 23:19:36 +0000

On arm64 disable three tests that hang or panicEach issue has a PR open to track. This workaround allows us to run thetests to investigate the failures and avoid any new regressions.PR: 202304, 202305, 202307Reviewed by: ngieSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D3378 List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

249d5c7a - Add support for makecontext. This supports up to 8 arguments as this

Fri, 10 Jul 2015 08:36:22 +0000

Add support for makecontext. This supports up to 8 arguments as thissimplifies the code, these can be passed in registers.Obtained from: ABT Systems LtdSponsored by: The FreeBSD Foundation List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

ae995167 - Disable the tests that use makecontext on arm64, it still needs to be

Mon, 27 Apr 2015 13:56:20 +0000

Disable the tests that use makecontext on arm64, it still needs to bewritten. List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile

2f121787 - Add reachover Makefiles for contrib/netbsd-tests/lib/libc; this adds approximately

Tue, 04 Nov 2014 00:56:25 +0000

Add reachover Makefiles for contrib/netbsd-tests/lib/libc; this adds approximately500 new testcasesVarious TODOs have been sprinkled around the Makefiles for items that even needto be ported (missing features), testcases have issues with building/linking, orissues at runtime.A variant of this code has been tested extensively on amd64 and i38610-STABLE/11-CURRENT for several months without issue. It builds on otherarchitectures, but the code will remain off until I have prove it works onvirtual hardware or real hardware on other architecturesIn collaboration with: pho, Casey Peel Sponsored by: EMC / Isilon Storage Division List of files: /freebsd-12.1/lib/libc/tests/sys/Makefile