en Copyright 2015 Java http://172.16.0.5:8080/history/expo/packages/expo-updates/scripts/with-node.sh#ed716ba1 [with-node] Add quotes for arguments (#18741)Co-authored-by: James Ide <ide@users.noreply.github.com> List of files: /expo/packages/expo-updates/scripts/with-node.sh Mon, 22 Aug 2022 18:43:29 +0000 Kudo Chien <kudo@expo.dev> http://172.16.0.5:8080/history/expo/packages/expo-updates/scripts/with-node.sh#2fd75d6d Deprecate source-login-scripts.sh (#18330)# Why the `source-login-scripts.sh` introduced a lot of pain where the community reported much build errors from it. it doesn't support shells other than zsh and bash. this pr find a new way to deal with xcode building issues that it cannot find the correct nodejs path. close ENG-4864 close ENG-5242 # How react-native introduces `.xcode.env` and `.xcode.env.local` for developers to override the `$NODE_BINARY`: https://github.com/facebook/react-native/pull/33546 to make sure building success from expo-constants, expo-updates, and also the app target when generating bundles. i would like to reuse the `.xcode.env` and `.xcode.env.local` from react-native. this pr further generates `.xcode.env.local` automatically for the app during `pod install`. we can ensure that `pod install` is executed from shell and nodejs is available. so we will generate `export NODE_BINARY="$(command -v node)"` in the `.xcode.env.local`. for xcode, the path will be `$PODS_ROOT/../.xcode.env.local`, every xcode subprojects can source the file to get correct `$NODE_BINARY`. # Test Plan - building bare-expo from xcode (opening xcode by macos finder) - building bare-expo by `yarn ios` - updates e2e ci passed - building expo-go (prerequisite: #18344) Co-authored-by: James Ide <ide@users.noreply.github.com> List of files: /expo/packages/expo-updates/scripts/with-node.sh Mon, 25 Jul 2022 12:28:01 +0000 Kudo Chien <kudo@expo.dev>