46b58c59 - [docs] separate copy and link icons on headers/ collapsibles (#24448)

Fri, 15 Sep 2023 15:48:19 +0000

[docs] separate copy and link icons on headers/ collapsibles (#24448)# Why A follow-up to https://github.com/expo/expo/pull/24293 based on feedback from @brentvatne . The goal is to create more consistency and clarity between the anchor link and copy anchor link functionality on both headers and collapsibles. **UPDATE**: After talking with Brent, I removed the copy functionality, the idea being that, now that clicking the link icon everywhere gets you an updated URL, it's easy enough to copy. So, this really just updates collapsibles and removes copy functionality from the headings. I left the icon switch in there in case there was some appeal to that, since the link icon seemed to be a one-off. # How (old) There's a few ways to slice this, but this approach is to try separating the functionality into two icons. I've definitely seen this elsewhere, can't remember where tho. Now we have consistent rules for both headers and collapsibles: - the link icon always navigates to the anchor tag on click - the copy icon always copies the anchor tag on click (and __only__ copies, no updating of the URL here!) Additionally, we now have better copy feedback: Design notes: - I removed the arrow from the tooltip since, if the heading is at the top of the page, the tooltip moves below the icon, but the arrow still points down �� - I didn't see a copy icon in the docs, noticed it seemed like a lot of other icons were going in the styleguide direction, so I switched both icons to styleguide. I have no idea how to see all the icons, so I'm not sure if this is the best of the like 20 different link icons. ## Special collapsible stuff - Unlike a heading, where you can click anywhere and navigate to the anchor tag, you have to click the link icon in order to navigate anchor tag here. This is so you can expand the collapsible without also scrolling the page. - If you click the link icon and the collapsible is closed, it will expand the collapsible as well as updating the URL. However, if the collapsible is already open, clicking the link icon will not close it. Thus, clicking the link icon will always leave you in the same state as if you copied the URL with anchor tag and opened it in another tab. - The copy icon also expands the collapsible but will not close it. # Test Plan - [x] clicking on header text updates URL with anchor tag - [x] Headers: clicking on link icon updates URL with anchor tag ~~- [x] Headers: clicking on copy icon copies URL (doesn't navigate)~~ - [x] Collapsibles: clicking on header expands/ collapses section ONLY - [x] Collapsibles: clicking on link expands and navigates ~~- [x] Collapsibles: clicking on copy expands and copies (doesn't navigate)~~ ~~- [x] Collapsibles: clicking on link or copy when already opened doesn't close~~ ~~- [x] Copy tooltip: updates to "Copied!" on click~~ # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). List of files: /expo/docs/components/icons/Permalink.tsx

52aab7ca - Revert "separate copy/ link icons on headers and collapsibles"

Thu, 14 Sep 2023 15:29:34 +0000

Revert "separate copy/ link icons on headers and collapsibles"This reverts commit 857493dcbcd6761210ef538660efdca44afe2a00. List of files: /expo/docs/components/icons/Permalink.tsx

1f61a071 - [docs] improve typings after React 18 migration (#18269)

Tue, 19 Jul 2022 07:19:17 +0000

[docs] improve typings after React 18 migration (#18269) List of files: /expo/docs/components/icons/Permalink.tsx

b8b69ebe - [docs] bump Next, switch to React 18 (#18256)

Fri, 15 Jul 2022 14:58:24 +0000

[docs] bump Next, switch to React 18 (#18256) List of files: /expo/docs/components/icons/Permalink.tsx

586106d6 - [docs] Migrate codebase to TypeScript (#10324)

Tue, 29 Sep 2020 11:47:43 +0000

[docs] Migrate codebase to TypeScript (#10324)* Configure Next.js to use TypeScript * Migrate 'docs/common' to TypeScript * Migrate some components to TS * General components migrated * Migrate base components * Migrate icons * Migrate plugins * Tape patch window globals * Migrate _app * Migrate global-styles * Migrate _error and _document * Fixes * Exclude static files * Add slugger types, remove ts-ignores * Improve headingManger typing * Rebase, use React.FC where possible, prettier fixes * Add ESLint config * tsc watch script, updated test snapshots * Apply code review suggestions Apply suggestions * [docs] Enable TypeScript 'strict' mode (#10380) * Resolved TSC strict errors * Fix heading metadata typing * Simplify version handling * Enable 'noImplicitAny' * Update icons * Add mdx-js types List of files: /expo/docs/components/icons/Permalink.tsx

Changes in Permalink.tsx

46b58c59 - [docs] separate copy and link icons on headers/ collapsibles (#24448)

52aab7ca - Revert "separate copy/ link icons on headers and collapsibles"

1f61a071 - [docs] improve typings after React 18 migration (#18269)

b8b69ebe - [docs] bump Next, switch to React 18 (#18256)

586106d6 - [docs] Migrate codebase to TypeScript (#10324)