Changes in project.pbxproj

1902997c - [expo-manifests] Fix error in handling nested array (#23562)

Wed, 19 Jul 2023 19:03:56 +0000

[expo-manifests] Fix error in handling nested array (#23562)# Why Fix crash on iOS if a plugin is passed in as an array, but with only the name element and not the props element. Also fix corresponding code on Android, where an exception is thrown. Fixes #23549. # How Modified `Manifest.swift` and `Manifest.kt` to handle the above case correctly. # Test Plan - Tested with Expo Go and the project provided in the above issue - New unit tests for both iOS and Android # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). List of files: /expo/apps/native-tests/ios/NativeTests.xcodeproj/project.pbxproj

b61e665e - Update Podfile locks and fix ExpoModulesCore podspec for Fabric [skip ci]

Fri, 04 Nov 2022 10:20:33 +0000

Update Podfile locks and fix ExpoModulesCore podspec for Fabric [skip ci] List of files: /expo/apps/native-tests/ios/NativeTests.xcodeproj/project.pbxproj

c88b85cf - [ios] Bump deployment target to 13.0 (#18873)

Wed, 14 Sep 2022 07:55:46 +0000

[ios] Bump deployment target to 13.0 (#18873) List of files: /expo/apps/native-tests/ios/NativeTests.xcodeproj/project.pbxproj

215820b7 - Fix unquoted $NODE_BINARY inside xcode shell scripts (#18727)

Mon, 22 Aug 2022 00:24:26 +0000

Fix unquoted $NODE_BINARY inside xcode shell scripts (#18727)# Why If a user has a a NODE_BINARY with a space like for ex: `/Users/johndoe/Library/Application Support/fnm/node-versions/v16.16.0/installation/bin/node`, Xcode woudl then fail to run node because of the missing double quotes. Xcode build error: ``` …/Script-00DD1BFF1BD5951E006B06BC.sh: line 15: /Users/johndoe/Library/Application: No such file or directory Command PhaseScriptExecution failed with a nonzero exit code ``` # How All other shell scripts inside Xcode use `"` with env var so did the same for the `$NODE_BINARY` # Test Plan ``` npx create-expo-app@latest -t expo-template-blank-typescript@46 shiny cd shiny yarn expo install expo-dev-client yarn expo run:ios (you will get a build failure if you have a space in your node path, for example setup node with `fnm`) (I then manually changed the project.pbxproj with the changes from this PR) yarn expo run:ios (no build failure) ``` List of files: /expo/apps/native-tests/ios/NativeTests.xcodeproj/project.pbxproj

2fd75d6d - Deprecate source-login-scripts.sh (#18330)

Mon, 25 Jul 2022 12:28:01 +0000

Deprecate source-login-scripts.sh (#18330)# Why the `source-login-scripts.sh` introduced a lot of pain where the community reported much build errors from it. it doesn't support shells other than zsh and bash. this pr find a new way to deal with xcode building issues that it cannot find the correct nodejs path. close ENG-4864 close ENG-5242 # How react-native introduces `.xcode.env` and `.xcode.env.local` for developers to override the `$NODE_BINARY`: https://github.com/facebook/react-native/pull/33546 to make sure building success from expo-constants, expo-updates, and also the app target when generating bundles. i would like to reuse the `.xcode.env` and `.xcode.env.local` from react-native. this pr further generates `.xcode.env.local` automatically for the app during `pod install`. we can ensure that `pod install` is executed from shell and nodejs is available. so we will generate `export NODE_BINARY="$(command -v node)"` in the `.xcode.env.local`. for xcode, the path will be `$PODS_ROOT/../.xcode.env.local`, every xcode subprojects can source the file to get correct `$NODE_BINARY`. # Test Plan - building bare-expo from xcode (opening xcode by macos finder) - building bare-expo by `yarn ios` - updates e2e ci passed - building expo-go (prerequisite: #18344) Co-authored-by: James Ide List of files: /expo/apps/native-tests/ios/NativeTests.xcodeproj/project.pbxproj

53977629 - [dev-menu] Update `react-native-reanimated` to `2.9.1` (#18182)

Wed, 13 Jul 2022 12:44:12 +0000

[dev-menu] Update `react-native-reanimated` to `2.9.1` (#18182)# Why Closes ENG-5411. Closes ENG-5685. # How Run: ``` et vendor -c "[dev-menu] reanimated" ``` and adjust the vendoring script. # Test Plan - bare-expo with NCL ✅ - bare-expo with sandbox ✅ List of files: /expo/apps/native-tests/ios/NativeTests.xcodeproj/project.pbxproj

aa3bb5e3 - [ios][tools][ci] Redesign iOS unit tests (#17634)

Tue, 21 Jun 2022 13:16:36 +0000

[ios][tools][ci] Redesign iOS unit tests (#17634)# Why iOS Unit Test CI job had several issues: - Fastlane is being run for each package separately, so it's restarting the simulator each time. This makes the job slower and moreover, test results are scattered across all fastlane logs. - Some tests are being run on bare-expo, others on the client project. - Packages to be tested need to be defined manually in podfile - Some dev-client tests aren't being run at all (bug in expotools) # How Basically, running tests once from a single xcscheme is faster and clearer than doing it separately for each package. - Applied some autolinking + fastlane changes from #16993 and https://github.com/expo/expo/commit/0e0c1e3db71535002e56453ff6004b06e2836c8e - now we have `use_expo_modules_tests!` for autolinking only test packages. - Created (`expo init -t bare`) a new `apps/native-tests` app which has no JS code, but only native iOS project with a single test-only scheme (`NativeTests.xcscheme`) > It might be possible to integrate it as a separate test target in bare-expo instead of creating a new app - Created a custom fastlane action `generate_test_scheme`, which takes that NativeTests scheme as a template and automatically finds test targets (named `PodspecName-Unit-Tests`, generated by CocoaPods during `pod install`) and generates a `NativeTests_generated` scheme aggregating all these targets. Package filtering is also supported. - Created a new ios lane `:unit_tests` which uses that action to generate the scheme and then run tests, adopted the `et ios-native-unit-tests` command to use this lane. - Fixed expotools not recognizing the `expo-dev-launcher` podspec, because it was in the package root instead of the `ios/` subdir. - Got rid of `React-hermes` test spec dependencies. They're not needed anymore. JS engine for `apps/native-tests` is set to JSC. - Added `FASTLANE_SKIP_UPDATE_CHECK=1` to the CI env to prevent fastlane from spamming. One drawback of this approach is that we now have to maintain another app, another podfile etc �� List of files: /expo/apps/native-tests/ios/NativeTests.xcodeproj/project.pbxproj