Changes in power_manager.c

b49c677a - examples/vm_power: respect core mask

Fri, 15 Jan 2021 12:52:50 +0000

examples/vm_power: respect core maskWhen vm_power_manager is started, it takes over power management onall cores. This should be limited to cores defined in the core mask.When initialising, if a core is not on the coremask, skip it.Applies to both initialisation and exit.Signed-off-by: David Hunt List of files: /dpdk/examples/vm_power_manager/power_manager.c

95f648ff - examples/vm_power: make branch ratio threshold per core

Tue, 14 Jul 2020 16:01:58 +0000

examples/vm_power: make branch ratio threshold per coreThis modification allows for the branch ratio threshold to be setper core rather than system wide. This gives greater flexibility tothe branch ratio monitoring allowing it to manage differentworkloads with different characteristics on the same system.Signed-off-by: Rory Sexton Reviewed-by: David Hunt Acked-by: Reshma Pattan List of files: /dpdk/examples/vm_power_manager/power_manager.c

666272d2 - examples/vm_power: drop Unix path limit redefinition

Wed, 20 May 2020 08:10:50 +0000

examples/vm_power: drop Unix path limit redefinitionThe Unix socket path may be as long as UNIX_PATH_MAX.This constant is supposed to be defined in sys/un.h.On Linux, it appears to be in linux/un.h.This constant was re-defined locally, based on a variable declaration.It is breaking compilation with -fno-common (default in GCC 10)We could avoid the variable declaration by using NULL struct,but it looks simpler not redefining this system constant.As the power library and its examples are restricted to Linux only,the Linux header file is directly included.Fixes: 0d74597c1b4f ("examples/vm_power: fix max length of unix socket path")Cc: stable@dpdk.orgSigned-off-by: Thomas Monjalon Acked-by: David Marchand Acked-by: Kevin Traynor List of files: /dpdk/examples/vm_power_manager/power_manager.c

31c9a664 - examples/vm_power: fix OOB frequency oscillations

Wed, 24 Jul 2019 13:18:03 +0000

examples/vm_power: fix OOB frequency oscillationsThe branch ratio algorithm in the vm_power_manager sample applicationcan be very sensitive at patricular loads in a workload, causingoscillations between min and max frequency. For example, if aworkload is at 50%, scaling up may change the ratioenough that it immediately thinks it needs to scale down again.This patch introduces a sliding window recording the scale up/downdirection for the last 32 samples, and scales up if any samples indicatewe should scale up, otherwise scale down. Each core has it's own window.Fixes: 4b1a631b8a8a ("examples/vm_power: add oob monitoring functions")Cc: stable@dpdk.orgSigned-off-by: David Hunt Acked-by: Anatoly Burakov List of files: /dpdk/examples/vm_power_manager/power_manager.c

3f1fc5f2 - examples/power: fix buffer overrun

Fri, 26 Apr 2019 08:42:09 +0000

examples/power: fix buffer overrunThe freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,yet the code can attempt to look at the index at RTE_MAX_LCORE,which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index toRTE_MAX_LCORE_FREQS.Coverity issue: 337660Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")Cc: stable@dpdk.orgSigned-off-by: David Hunt Acked-by: Reshma Pattan List of files: /dpdk/examples/vm_power_manager/power_manager.c

751227a0 - power: fix buffer overruns

Tue, 09 Apr 2019 09:22:01 +0000

power: fix buffer overrunsA previous change removed the limit of 64 cores bymoving away from 64-bit masks to char arrays. Howeverthis left a buffer overrun issue, where the max channelswas defined as 64, and max cores was defined as 256. Theseshould all be consistently set to RTE_MAX_LCORE.The #defines being removed are CHANNEL_CMDS_MAX_CPUS,CHANNEL_CMDS_MAX_CHANNELS, POWER_MGR_MAX_CPUS, andCHANNEL_CMDS_MAX_VM_CHANNELS, and are being replacedwith RTE_MAX_LCORE for consistency and simplicity.Coverity issue: 337672, 337673, 337678Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")Cc: stable@dpdk.orgSigned-off-by: David Hunt Acked-by: Anatoly Burakov List of files: /dpdk/examples/vm_power_manager/power_manager.c

6ff7b996 - examples/power: fix for p-state

Tue, 08 Jan 2019 15:25:23 +0000

examples/power: fix for p-stateThe vm_power_manager starts by setting the environment to acpiusing rte_power_set_env(PM_ENV_ACPI_CPUFREQ). This causes a problemstarting vm_power_manager when the system is using the intel_pstatedriver. The env should be set to none, or not called at all, becausethe library now auto-detects the environment to be either acpi orintel_pstate. This patch sets the environment to none so that thelibrary can successfully auto-detect.Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")Signed-off-by: David Hunt List of files: /dpdk/examples/vm_power_manager/power_manager.c

b6b22982 - examples/power: remove mask functions

Fri, 14 Dec 2018 13:31:35 +0000

examples/power: remove mask functionsSince we're moving to allowing greater than 64 cores, the mask functionsthat use uint64_t to perform functions on a masked set of cores are nolonger needed, so removing them.Signed-off-by: David Hunt Reviewed-by: Anatoly Burakov List of files: /dpdk/examples/vm_power_manager/power_manager.c

c12ade20 - examples/vm_power: respect maximum CPUs

Wed, 31 Oct 2018 11:50:32 +0000

examples/vm_power: respect maximum CPUsThe vm_power_manager app was not respecting the POWER_MGR_MAX_CPUSduring initialisation, so if there were more CPUs than this value (64),it would lead to buffer overruns of there were more then 64 cores inthe system.Added in a check during init and un-init to only initialise up tolcore_id 63.This raises the question as to why not simply increase the value ofPOWER_MGR_MAX_CPUS. Well, it's not that simple, as many of the APIs takea uint64_t as a parameter for the core mask, and this will not work forcores greater than 63. So some work needs to be done in the future toremove this limitation. For now we'll fix the memory corruption.Also, the patch that this fixes says "allow greater than 64 cores" butthat's not across the entire application, it's only for the out-of-bandmonitoring. I'll add a notice for an API change in the next release toclean this up, i.e. depricate any API calls that use masks.Fixes: 6453b9284b64 ("examples/vm_power: allow greater than 64 cores")Cc: stable@dpdk.orgSigned-off-by: David Hunt List of files: /dpdk/examples/vm_power_manager/power_manager.c

711f43ba - examples/vm_power: make branch ratio configurable

Fri, 13 Jul 2018 14:23:02 +0000

examples/vm_power: make branch ratio configurableFor different workloads and poll loops, the thesholdmay be different for when you want to scale up and down.This patch allows changing of the default branch ratioby using the -b command line argument (or --branch-ratio=)Signed-off-by: David Hunt Acked-by: Radu Nicolau List of files: /dpdk/examples/vm_power_manager/power_manager.c

6453b928 - examples/vm_power: allow greater than 64 cores

Fri, 13 Jul 2018 14:22:57 +0000

examples/vm_power: allow greater than 64 coresTo facilitate more info per core, change the global_cpu_maskfrom a uint64_t to an array. This also removes the limit on64 cores, allocing the aray at run-time based on the number ofcores found in the system.Signed-off-by: David Hunt Acked-by: Radu Nicolau List of files: /dpdk/examples/vm_power_manager/power_manager.c

99a968fa - examples/vm_power: add core list parameter

Fri, 13 Jul 2018 14:22:55 +0000

examples/vm_power: add core list parameterAdd in the '-l' command line parameter (also --core-list)So the user can now pass --corelist=4,6,8-10 and it willexpand out to 4,6,8,9,10 using the parse function providedin parse.c (parse_set).This list of cores is then used to enable out-of-band monitoringto scale up and down these cores based on the ratio of branchhits versus branch misses. The ratio will be low when a pollloop is spinning with no packets being received, so the frequencywill be scaled down.Also , as part of this change, we introduce a core_info structwhich keeps information on each core in the system, and whetherwe're doing out of band monitoring on them.Signed-off-by: David Hunt Acked-by: Radu Nicolau List of files: /dpdk/examples/vm_power_manager/power_manager.c

3998e2a0 - examples: use SPDX tag for Intel copyright files

Tue, 19 Dec 2017 15:49:02 +0000

examples: use SPDX tag for Intel copyright filesReplace the BSD license header with the SPDX tag for fileswith only an Intel copyright on them.Signed-off-by: Bruce Richardson List of files: /dpdk/examples/vm_power_manager/power_manager.c

7f472f74 - examples/vm_power_mgr: add scale to medium freq fn

Wed, 11 Oct 2017 16:18:50 +0000

examples/vm_power_mgr: add scale to medium freq fnSigned-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt Reviewed-by: Santosh Shukla Acked-by: Konstantin Ananyev List of files: /dpdk/examples/vm_power_manager/power_manager.c

567997b9 - examples/vm_power_manager: add per-core turbo

Wed, 13 Sep 2017 10:44:17 +0000

examples/vm_power_manager: add per-core turboAdd extra commands to command line to allow enable/disable ofper-core turbo.When a core has turbo enabled, calling for max frequency will allow it togo to a turbo frequency (P0n).When a core has turbo disabled, calling for max frequency will allow it togo to the maximum non-turbo frequency (P1), but not beyond.Signed-off-by: David Hunt List of files: /dpdk/examples/vm_power_manager/power_manager.c

50810f09 - config: remove useless explicit includes of generated header

Mon, 08 Feb 2016 14:18:22 +0000

config: remove useless explicit includes of generated headerThe file rte_config.h is automatically generated and included.No need to #include it.The example performance-thread needs a makefile fix to avoidoverwriting the default cflags.Signed-off-by: Thomas Monjalon List of files: /dpdk/examples/vm_power_manager/power_manager.c

d26c18c9 - examples/vm_power: cpu frequency in host

Tue, 25 Nov 2014 16:18:04 +0000

examples/vm_power: cpu frequency in hostA wrapper around librte_power(using ACPI cpufreq), providing locking around thenon-threadsafe library, allowing for frequency changes based on core masks andcore numbers from both the CLI thread and epoll monitor thread.Signed-off-by: Alan Carew Signed-off-by: Pablo de Lara List of files: /dpdk/examples/vm_power_manager/power_manager.c