Changes in qede_ethdev.c

a41f593f - ethdev: introduce generic dummy packet burst function

Fri, 11 Feb 2022 19:11:42 +0000

ethdev: introduce generic dummy packet burst functionMultiple PMDs have dummy/noop Rx/Tx packet burst functions.These dummy functions are very simple, introduce a common function inthe ethdev and update drivers to use it instead of each driver havingits own functions.Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Acked-by: Viacheslav Ovsiienko Acked-by: Thomas Monjalon List of files: /dpdk/drivers/net/qede/qede_ethdev.c

7be78d02 - fix spelling in comments and strings

Mon, 29 Nov 2021 16:08:02 +0000

fix spelling in comments and stringsThe tool comes from https://github.com/jsorefSigned-off-by: Josh Soref Signed-off-by: Thomas Monjalon List of files: /dpdk/drivers/net/qede/qede_ethdev.c

2fe6f1b7 - drivers/net: advertise no support for keeping flow rules

Tue, 02 Nov 2021 17:01:32 +0000

drivers/net: advertise no support for keeping flow rulesWhen RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero,the specified behavior is the same as it had been beforethis bit was introduced. Explicitly reset it in all PMDssupporting rte_flow API in order to attract the attentionof maintainers, who should eventually choose to advertisethe new capability or not. It is already known thatmlx4 and mlx5 will not support this capability.For RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEPsimilar action is not performed,because no PMD except mlx5 supports indirect actions.Any PMD that starts doing so will anyway have to considerall relevant API, including this capability.Suggested-by: Ferruh Yigit Signed-off-by: Dmitry Kozlyuk Acked-by: Ajit Khaparde Acked-by: Somnath Kotur Acked-by: Hyong Youb Kim Reviewed-by: Ferruh Yigit List of files: /dpdk/drivers/net/qede/qede_ethdev.c

d61138d4 - drivers: remove direct access to interrupt handle

Fri, 22 Oct 2021 20:49:32 +0000

drivers: remove direct access to interrupt handleRemoving direct access to interrupt handle structure fields,rather use respective get set APIs for the same.Making changes to all the drivers access the interrupt handle fields.Signed-off-by: Harman Kalra Acked-by: Hyong Youb Kim Signed-off-by: David Marchand Tested-by: Raslan Darawsheh List of files: /dpdk/drivers/net/qede/qede_ethdev.c

295968d1 - ethdev: add namespace

Fri, 22 Oct 2021 11:03:12 +0000

ethdev: add namespaceAdd 'RTE_ETH' namespace to all enums & macros in a backward compatibleway. The macros for backward compatibility can be removed in next LTS.Also updated some struct names to have 'rte_eth' prefix.All internal components switched to using new names.Syntax fixed on lines that this patch touches.Signed-off-by: Ferruh Yigit Acked-by: Tyler Retzlaff Acked-by: Andrew Rybchenko Acked-by: Ajit Khaparde Acked-by: Jerin Jacob Acked-by: Wisam Jaddo Acked-by: Rosen Xu Acked-by: Chenbo Xia Acked-by: Hemant Agrawal Acked-by: Somnath Kotur List of files: /dpdk/drivers/net/qede/qede_ethdev.c

b563c142 - ethdev: remove jumbo offload flag

Mon, 18 Oct 2021 13:48:51 +0000

ethdev: remove jumbo offload flagRemoving 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag.Instead of drivers announce this capability, application can deduct thecapability by checking reported 'dev_info.max_mtu' or'dev_info.max_rx_pktlen'.And instead of application setting this flag explicitly to enable jumboframes, this can be deduced by driver by comparing requested 'mtu' to'RTE_ETHER_MTU'.Removing this additional configuration for simplification.Suggested-by: Konstantin Ananyev Signed-off-by: Ferruh Yigit Acked-by: Andrew Rybchenko Reviewed-by: Rosen Xu Acked-by: Somnath Kotur Acked-by: Konstantin Ananyev Acked-by: Huisong Li Acked-by: Hyong Youb Kim Acked-by: Michal Krawczyk List of files: /dpdk/drivers/net/qede/qede_ethdev.c

f7e04f57 - ethdev: move MTU set check to library

Mon, 18 Oct 2021 13:48:50 +0000

ethdev: move MTU set check to libraryMove requested MTU value check to the API to prevent the duplicatedcode.Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Rosen Xu Acked-by: Somnath Kotur Acked-by: Konstantin Ananyev List of files: /dpdk/drivers/net/qede/qede_ethdev.c

dd4e429c - ethdev: move jumbo frame offload check to library

Mon, 18 Oct 2021 13:48:49 +0000

ethdev: move jumbo frame offload check to librarySetting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support,and application should enable the jumbo frame offload support for it.When jumbo frame offload is not enabled by application, but MTU biggerthan RTE_ETHER_MTU is requested there are two options, either fail orenable jumbo frame offload implicitly.Enabling jumbo frame offload implicitly is selected by many driverssince setting a big MTU value already implies it, and this increasesusability.This patch moves this logic from drivers to the library, both to reducethe duplicated code in the drivers and to make behaviour more visible.Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Rosen Xu Acked-by: Ajit Khaparde Acked-by: Somnath Kotur Acked-by: Konstantin Ananyev Acked-by: Huisong Li List of files: /dpdk/drivers/net/qede/qede_ethdev.c

1bb4a528 - ethdev: fix max Rx packet length

Mon, 18 Oct 2021 13:48:48 +0000

ethdev: fix max Rx packet lengthThere is a confusion on setting max Rx packet length, this patch aims toclarify it.'rte_eth_dev_configure()' API accepts max Rx packet size via'uint32_t max_rx_pkt_len' field of the config struct 'structrte_eth_conf'.Also 'rte_eth_dev_set_mtu()' API can be used to set the MTU, and resultstored into '(struct rte_eth_dev)->data->mtu'.These two APIs are related but they work in a disconnected way, theystore the set values in different variables which makes hard to figureout which one to use, also having two different method for a relatedfunctionality is confusing for the users.Other issues causing confusion is:* maximum transmission unit (MTU) is payload of the Ethernet frame. And 'max_rx_pkt_len' is the size of the Ethernet frame. Difference is Ethernet frame overhead, and this overhead may be different from device to device based on what device supports, like VLAN and QinQ.* 'max_rx_pkt_len' is only valid when application requested jumbo frame, which adds additional confusion and some APIs and PMDs already discards this documented behavior.* For the jumbo frame enabled case, 'max_rx_pkt_len' is an mandatory field, this adds configuration complexity for application.As solution, both APIs gets MTU as parameter, and both saves the resultin same variable '(struct rte_eth_dev)->data->mtu'. For this'max_rx_pkt_len' updated as 'mtu', and it is always valid independentfrom jumbo frame.For 'rte_eth_dev_configure()', 'dev->data->dev_conf.rxmode.mtu' is userrequest and it should be used only within configure function and resultshould be stored to '(struct rte_eth_dev)->data->mtu'. After that pointboth application and PMD uses MTU from this variable.When application doesn't provide an MTU during 'rte_eth_dev_configure()'default 'RTE_ETHER_MTU' value is used.Additional clarification done on scattered Rx configuration, inrelation to MTU and Rx buffer size.MTU is used to configure the device for physical Rx/Tx size limitation,Rx buffer is where to store Rx packets, many PMDs use mbuf data buffersize as Rx buffer size.PMDs compare MTU against Rx buffer size to decide enabling scattered Rxor not. If scattered Rx is not supported by device, MTU bigger than Rxbuffer size should fail.Signed-off-by: Ferruh Yigit Acked-by: Ajit Khaparde Acked-by: Somnath Kotur Acked-by: Huisong Li Acked-by: Andrew Rybchenko Acked-by: Konstantin Ananyev Acked-by: Rosen Xu Acked-by: Hyong Youb Kim List of files: /dpdk/drivers/net/qede/qede_ethdev.c

7483341a - ethdev: change queue release callback

Wed, 06 Oct 2021 11:18:22 +0000

ethdev: change queue release callbackCurrently, most ethdev callback API use queue ID as parameter, but Rxand Tx queue release callback use queue object which is used by Rx andTx burst data plane callback.To align with other eth device queue configuration callbacks:- queue release callbacks are changed to use queue ID- all drivers are adaptedSigned-off-by: Xueming Li Reviewed-by: Andrew Rybchenko Acked-by: Ajit Khaparde Acked-by: Somnath Kotur Acked-by: Ferruh Yigit List of files: /dpdk/drivers/net/qede/qede_ethdev.c

a7db3afc - net: add macro to extract MAC address bytes

Wed, 25 Aug 2021 17:27:34 +0000

net: add macro to extract MAC address bytesAdded macros to simplify print of MAC address.The six bytes of a MAC address are extracted ina macro here, to improve code readablity.Signed-off-by: Aman Deep Singh Reviewed-by: Ferruh Yigit List of files: /dpdk/drivers/net/qede/qede_ethdev.c

c2c4f87b - net: add macro for MAC address print

Wed, 25 Aug 2021 17:27:33 +0000

net: add macro for MAC address printAdded macro to print six bytes of MAC address.The MAC addresses will be printed in upper casehexadecimal format.In case there is a specific check for lower caseMAC address, the user may need to make a change insuch test case after this patch.Signed-off-by: Aman Deep Singh Reviewed-by: Ferruh Yigit List of files: /dpdk/drivers/net/qede/qede_ethdev.c

eeded204 - log: register with standardized names

Mon, 26 Apr 2021 12:51:08 +0000

log: register with standardized namesLet's try to enforce the convention where most drivers use a pmd. logtypewith their class reflected in it, and libraries use a lib. logtype.Introduce two new macros:- RTE_LOG_REGISTER_DEFAULT can be used when a single logtype is used in a component. It is associated to the default name provided by the build system,- RTE_LOG_REGISTER_SUFFIX can be used when multiple logtypes are used, and then the passed name is appended to the default name,RTE_LOG_REGISTER is left untouched for existing external usersand for components that do not comply with the convention.There is a new Meson variable log_prefix to adapt the default namefor baseband (pmd.bb.), bus (no pmd.) and mempool (no pmd.) classes.Note: achieved with below commands + reverted change on net/bonding +edits on crypto/virtio, compress/mlx5, regex/mlx5$ git grep -l RTE_LOG_REGISTER drivers/ | while read file; do pattern=${file##drivers/}; class=${pattern%%/*}; pattern=${pattern#$class/}; drv=${pattern%%/*}; case "$class" in baseband) pattern=pmd.bb.$drv;; bus) pattern=bus.$drv;; mempool) pattern=mempool.$drv;; *) pattern=pmd.$class.$drv;; esac sed -i -e 's/RTE_LOG_REGISTER($.*$, '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file; sed -i -e 's/RTE_LOG_REGISTER($.*$, '$pattern'\.$.*$,/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file; done$ git grep -l RTE_LOG_REGISTER lib/ | while read file; do pattern=${file##lib/}; pattern=lib.${pattern%%/*}; sed -i -e 's/RTE_LOG_REGISTER($.*$, '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file; sed -i -e 's/RTE_LOG_REGISTER($.*$, '$pattern'\.$.*$,/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file; doneSigned-off-by: David Marchand Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson List of files: /dpdk/drivers/net/qede/qede_ethdev.c

d345d6c9 - drivers/net: fix FW version query

Wed, 21 Apr 2021 16:20:57 +0000

drivers/net: fix FW version queryFixes a few different things:* Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is zero, 'fw_version' being NULL but 'fw_size' not zero condition checked in ethdev layer* Be sure required buffer size is returned if provided one is not big enough, instead of returning success (0)* Document in doxygen comment the '-EINVAL' is a valid return type* Take into account that 'snprintf' can return negative value* Cast length to 'size_t' to compare it with 'fw_size'Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")Fixes: ff70acdf4299 ("net/axgbe: support reading FW version")Fixes: e2652b0a20a0 ("net/bnxt: support get FW version")Fixes: cf0fab1d2ca5 ("net/dpaa: support firmware version get API")Fixes: 748eccb97cdc ("net/dpaa2: add support for firmware version get")Fixes: b883c0644a24 ("net/e1000: add firmware version get")Fixes: 293430677e9c ("net/enic: add handler to return firmware version")Fixes: 1f5ca0b460cd ("net/hns3: support some device operations")Fixes: bd5b86732bc7 ("net/hns3: modify format for firmware version")Fixes: ed0dfdd0e976 ("net/i40e: add firmware version get")Fixes: e31cb9a36298 ("net/ice: support FW version getting")Fixes: 4f09bc55ac3d ("net/igc: implement device base operations")Fixes: eec10fb0ce6b ("net/ionic: support FW version")Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get")Fixes: 4d9f5b8adc02 ("net/octeontx2: add FW version get operation")Fixes: f97b56f9f12e ("net/qede: support FW version query")Fixes: 83fef46a22b2 ("net/sfc: add callback to retrieve FW version")Fixes: bc84ac0fadef ("net/txgbe: support getting FW version")Fixes: 21913471202f ("ethdev: add firmware version get")Cc: stable@dpdk.orgSigned-off-by: Ferruh Yigit Acked-by: Ajit Khaparde Acked-by: Andrew Rybchenko Acked-by: Haiyue Wang Acked-by: Rasesh Mody Acked-by: Jiawen Wu Acked-by: Beilei Xing Acked-by: Hemant Agrawal List of files: /dpdk/drivers/net/qede/qede_ethdev.c

fb7ad441 - ethdev: replace callback getting filter operations

Sun, 21 Mar 2021 09:00:00 +0000

ethdev: replace callback getting filter operationsSince rte_flow is the only API for filtering operations,the legacy driver interface filter_ctrl was too much complicatedfor the simple task of getting the struct rte_flow_ops.The filter type RTE_ETH_FILTER_GENERIC andthe filter operarion RTE_ETH_FILTER_GET are removed.The new driver callback flow_ops_get replaces filter_ctrl.Signed-off-by: Thomas Monjalon Acked-by: Ajit Khaparde Acked-by: Haiyue Wang Acked-by: Rosen Xu Acked-by: Hemant Agrawal Reviewed-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit List of files: /dpdk/drivers/net/qede/qede_ethdev.c

6ceb7ab8 - net/qede: accept bigger RSS table

Fri, 19 Mar 2021 09:46:56 +0000

net/qede: accept bigger RSS tableSome dpdk applications blindly pass fixed side RSS hash tables,and do not check driver/device capabilities.Moreover, many other drivers do not do such a strong check as well.Fix it by making qede accept any size rss_key. For larger keytables we just crop it with notice trace message.Cc: stable@dpdk.orgSigned-off-by: Igor Russkikh Acked-by: Rasesh Mody List of files: /dpdk/drivers/net/qede/qede_ethdev.c

f9a69f8b - net/qede: fix jumbo frame flag condition for MTU set

Mon, 18 Jan 2021 07:04:19 +0000

net/qede: fix jumbo frame flag condition for MTU setThe jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition,but the Ether overhead is larger than 18 when it supports dual VLAN tags.That will cause the jumbo flag rx offload is wrong when MTU size is'RTE_ETHER_MTU'.This fix will change the boundary condition with 'RTE_ETHER_MTU' andoverhead, that perhaps impacts the cases of the jumbo frame related.Fixes: 200645ac7909 ("net/qede: set MTU")Cc: stable@dpdk.orgSigned-off-by: Steve Yang Reviewed-by: Ferruh Yigit List of files: /dpdk/drivers/net/qede/qede_ethdev.c

a91fb48a - net/qede: fix promiscuous enable

Wed, 23 Dec 2020 14:15:49 +0000

net/qede: fix promiscuous enableWhen calling rte_eth_promiscuous_enable(port_id) followed byrte_eth_allmulticast_enable(port_id), the port is not in promisc modeanymore. This patch ensures that promisc mode takes precedence overallmulticast mode fixing the regression introduced by b10231aed1ed.Fixes: b10231aed1ed ("net/qede: fix multicast drop in promiscuous mode")Cc: stable@dpdk.orgSigned-off-by: Balazs Nemeth Acked-by: Rasesh Mody List of files: /dpdk/drivers/net/qede/qede_ethdev.c

f30e69b4 - ethdev: add device flag to bypass auto-filled queue xstats

Wed, 14 Oct 2020 02:26:47 +0000

ethdev: add device flag to bypass auto-filled queue xstatsQueue stats are stored in 'struct rte_eth_stats' as array and array sizeis defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queuestatistics from 'struct rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, thisgives more flexibility on the number of the queues supported.Currently queue stats in the xstats are filled by ethdev layer, usingsome basic stats, when queue stats removed from basic stats theresponsibility to fill the relevant xstats will be pushed to the PMDs.During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS'device flag is created. Initially all PMDs using xstats set this flag.The PMDs implemented queue stats in the xstats should clear the flag.When all PMDs switch to the xstats for the queue stats, queue statsrelated fields from 'struct rte_eth_stats' will be removed, as well as'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can beremoved.Signed-off-by: Ferruh Yigit Acked-by: Haiyue Wang Acked-by: Xiao Wang Acked-by: Thomas Monjalon List of files: /dpdk/drivers/net/qede/qede_ethdev.c

62024eb8 - ethdev: change stop operation callback to return int

Thu, 15 Oct 2020 13:30:45 +0000

ethdev: change stop operation callback to return intChange eth_dev_stop_t return value from void to int.Make eth_dev_stop_t implementations across all drivers to returnnegative errno values if case of error conditions.Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit List of files: /dpdk/drivers/net/qede/qede_ethdev.c