Changes in axgbe_phy_impl.c

a935a4c3 - net/axgbe: alter port speed bit range

Tue, 25 Jan 2022 12:17:47 +0000

net/axgbe: alter port speed bit rangeNewer generation Hardware uses the slightly differentport speed bit widths, so alter the existing port speedbit range to extend support to the newer generation hardwarewhile maintaining the backward compatibility with oldergeneration hardware.The previously reserved bits are now being used whichthen requires the adjustment to the BIT values, e.g.:Before: PORT_PROPERTY_0[22:21] - Reserved PORT_PROPERTY_0[26:23] - Supported SpeedsAfter: PORT_PROPERTY_0[21] - Reserved PORT_PROPERTY_0[26:22] - Supported SpeedsTo make this backwards compatible, the existing BITdefinitions for the port speeds are incremented by oneto maintain the original position.Signed-off-by: Selwin Sebastian Acked-by: Chandubabu Namburu List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

443ab5aa - net/axgbe: support no-autoneg port mode

Tue, 25 Jan 2022 12:17:46 +0000

net/axgbe: support no-autoneg port modeAdd support for a new port mode that is a backplaneconnection without support for auto negotiation.Signed-off-by: Selwin Sebastian Acked-by: Chandubabu Namburu List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

cd48955b - net/axgbe: reset PHY Rx when mailbox command timeout

Tue, 25 Jan 2022 12:17:45 +0000

net/axgbe: reset PHY Rx when mailbox command timeoutSometimes mailbox commands timeout when the RX data path becomesunresponsive. This prevents the submission of new mailbox commandsto DXIO. This patch identifies the timeout and resets the RX datapath so that the next message can be submitted properly.Signed-off-by: Selwin Sebastian Acked-by: Chandubabu Namburu List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

0df8d8df - net/axgbe: simplify rate change mailbox interface

Tue, 25 Jan 2022 12:17:44 +0000

net/axgbe: simplify rate change mailbox interfaceSimplify and centralize the mailbox command rate change interface byhaving a single function perform the writes to the mailbox registersto issue the request.Signed-off-by: Selwin Sebastian Acked-by: Chandubabu Namburu List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

09b0a36c - net/axgbe: toggle PLL settings during rate change

Tue, 25 Jan 2022 12:17:43 +0000

net/axgbe: toggle PLL settings during rate changeFor each rate change command submission, the FW has to do a phypower off sequence internally. For this to happen correctly, thePLL re-initialization control setting has to be turned off beforesending mailbox commands and re-enabled once the command submissionis complete. Without the PLL control setting, the link up takeslonger time in a fixed phy configuration.Signed-off-by: Selwin Sebastian Acked-by: Chandubabu Namburu List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

7be78d02 - fix spelling in comments and strings

Mon, 29 Nov 2021 16:08:02 +0000

fix spelling in comments and stringsThe tool comes from https://github.com/jsorefSigned-off-by: Josh Soref Signed-off-by: Thomas Monjalon List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

4216cdc0 - net/axgbe: add debug logs

Tue, 11 Feb 2020 08:19:39 +0000

net/axgbe: add debug logsAdd debug logs in various modules in axgbeSigned-off-by: Chandu Babu N Acked-by: Ravi Kumar List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

102b6ec3 - net/axgbe: support auto-negotiation for 1Gbps

Fri, 10 Jan 2020 13:00:11 +0000

net/axgbe: support auto-negotiation for 1GbpsAdded CL37 Auto-neg support for 1Gbps interface in axgbe DPDK driverSigned-off-by: Girish Nandibasappa Acked-by: Ravi Kumar List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

936e294c - net/axgbe: support 1/2.5Gbps

Fri, 10 Jan 2020 12:59:37 +0000

net/axgbe: support 1/2.5GbpsAdded support for 1Gbps and 2.5Gbps in axgbe dpdk driverSigned-off-by: Girish Nandibasappa Acked-by: Ravi Kumar List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

c8c2296b - net/axgbe: fix double unlock

Thu, 19 Sep 2019 11:01:47 +0000

net/axgbe: fix double unlockOne issue caught by Coverity 340835*unlock: axgbe_phy_set_mode unlocks pdata->phy_mutex*double_unlock: axgbe_phy_sfp_detect unlocks pdata->phy_mutexwhile it is unlocked.In axgbe_phy_sfp_detect()/axgbe_phy_set_redrv_mode(),axgbe_phy_get_comm_ownership() and axgbe_phy_put_comm_ownership()are invoked subsequently.Currently in axgbe_phy_get_comm_ownership(), during one of the case'phy_data->comm_owned' is not protected and before returning 0, lock isnot called and unlock is called in axgbe_phy_put_comm_ownership()directly which is incorrect.Ideally, the variable 'phy_data->comm_owned' needs to be protected.During success scenario, lock is called inaxgbe_phy_get_comm_ownership() followed by unlock inaxgbe_phy_put_comm_ownership(). In failure case, unlock is invoked inaxgbe_phy_get_comm_ownership() itself appropriately.The fix is to protect 'phy_data->comm_owned' in the identified caseensuring locks/unlocks properly exist.Coverity issue: 340835Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs")Cc: stable@dpdk.orgSigned-off-by: Pallantla Poornima Acked-by: Ravi Kumar List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

27578231 - net/axgbe: fix EEPROM string comparison

Mon, 14 May 2018 05:00:17 +0000

net/axgbe: fix EEPROM string comparisondrivers/net/axgbe/axgbe_phy_impl.c:576:6: error:‘__builtin_memcmp_eq’ reading 16 bytes from a region of size 9[-Werror=stringop-overflow=] if (memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_NAME], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AXGBE_BEL_FUSE_VENDOR, AXGBE_SFP_BASE_VENDOR_NAME_LEN))Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs")Signed-off-by: Andy Green Acked-by: Pablo de Lara List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

00072056 - net/axgbe: add workaround for ethernet training

Fri, 06 Apr 2018 12:36:50 +0000

net/axgbe: add workaround for ethernet trainingSigned-off-by: Ravi Kumar List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

a5c72737 - net/axgbe: add phy programming APIs

Fri, 06 Apr 2018 12:36:39 +0000

net/axgbe: add phy programming APIsSigned-off-by: Ravi Kumar List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c

4ac7516b - net/axgbe: add phy init and related APIs

Fri, 06 Apr 2018 12:36:38 +0000

net/axgbe: add phy init and related APIsAdded device phy initialization, read/write and othermaintenance apis to be used within PMD.Signed-off-by: Ravi Kumar List of files: /dpdk/drivers/net/axgbe/axgbe_phy_impl.c