Changes in libabigail.abignore

a95d7054 - eal: factorize lcore main loop

Tue, 05 Apr 2022 16:34:47 +0000

eal: factorize lcore main loopAll OS implementations provide the same main loop.Introduce helpers (shared for Linux and FreeBSD) to handle synchronisationbetween main and threads and factorize the rest as common code.Thread id are now logged as string in a common format across OS.Note:- this change also fixes Windows EAL: worker threads cpu affinity was incorrectly reported in log.- libabigail flags this change as breaking ABI in clang builds: 1 function with some indirect sub-type change: [C] 'function int rte_eal_remote_launch(int (void*)*, void*, unsigned int)' at eal_common_launch.c:35:1 has some indirect sub-type changes: parameter 1 of type 'int (void*)*' changed: in pointed to type 'function type int (void*)' at rte_launch.h:31:1: entity changed from 'function type int (void*)' to 'typedef lcore_function_t' at rte_launch.h:31:1 type size hasn't changed This is being investigated on libabigail side. For now, we don't have much choice but to waive reports on this symbol.Signed-off-by: David Marchand Acked-by: Morten Brørup Acked-by: Tyler Retzlaff List of files: /dpdk/devtools/libabigail.abignore

381813e6 - devtools: document ABI check suppression rules

Wed, 23 Mar 2022 09:24:00 +0000

devtools: document ABI check suppression rulesSuppression rules are being added during the life of an ABI and cleanedwhen bumping the major version.Sort and document those rules to avoid pruning rules that should be kept.Signed-off-by: David Marchand List of files: /dpdk/devtools/libabigail.abignore

b403498e - build: hide local symbols in shared libraries

Sun, 06 Mar 2022 09:20:23 +0000

build: hide local symbols in shared librariesThe symbols which are not listed in the version scriptare exported by default.Adding a local section with a wildcard make non-listed functionsand variables as hidden, as it should be in all version.map files.These are the changes done in the shared libraries:- DF .text Base auxiliary_add_device- DF .text Base auxiliary_dev_exists- DF .text Base auxiliary_dev_iterate- DF .text Base auxiliary_insert_device- DF .text Base auxiliary_is_ignored_device- DF .text Base auxiliary_match- DF .text Base auxiliary_on_scan- DF .text Base auxiliary_scan- DO .bss Base auxiliary_bus_logtype- DO .data Base auxiliary_bus- DO .bss Base gpu_logtypeThere is no impact on regexdev library.Because these local symbols were exported as non-internalin DPDK 21.11, any change in these functions would break the ABI.Exception rules are added for these experimental libraries,so the ABI check will skip them until the next ABI version.A check is added to avoid such miss in future.Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus")Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library")Cc: stable@dpdk.orgSigned-off-by: Thomas Monjalon List of files: /dpdk/devtools/libabigail.abignore

89e290eb - regexdev: fix section attribute of symbols

Sun, 06 Mar 2022 09:20:22 +0000

regexdev: fix section attribute of symbolsThe functions used by the drivers must be internal,while the function and variables used in inline functionsmust be experimental.These are the changes done in the shared library:- DF .text Base rte_regexdev_get_device_by_name+ DF .text INTERNAL rte_regexdev_get_device_by_name- DF .text Base rte_regexdev_register+ DF .text INTERNAL rte_regexdev_register- DF .text Base rte_regexdev_unregister+ DF .text INTERNAL rte_regexdev_unregister- DF .text Base rte_regexdev_is_valid_dev+ DF .text EXPERIMENTAL rte_regexdev_is_valid_dev- DO .bss Base rte_regex_devices+ DO .bss EXPERIMENTAL rte_regex_devices- DO .bss Base rte_regexdev_logtype+ DO .bss EXPERIMENTAL rte_regexdev_logtypeBecause these symbols were exported in the default section in DPDK 21.11,any change in these functions would be seen as incompatibleby the ABI compatibility check.An exception rule is added for this experimental library,so the ABI check will skip it until the next ABI version.Fixes: bab9497ef78b ("regexdev: introduce API")Cc: stable@dpdk.orgSigned-off-by: Thomas Monjalon Acked-by: Ori Kam List of files: /dpdk/devtools/libabigail.abignore

8fdcd513 - devtools: use libabigail rule for mlx glue drivers

Tue, 01 Mar 2022 16:54:04 +0000

devtools: use libabigail rule for mlx glue driversConvert the existing exception in the ABI script into a libabigailsuppression rule.Note: file_name_regexp could be used to achieve the same with versions oflibabigail < 1.7 but soname_regexp has been preferred here since it isalready used with a recent change on common/mlx5.While at it, fix indent from a recent change.Signed-off-by: David Marchand Acked-by: Ray Kinsella List of files: /dpdk/devtools/libabigail.abignore

c2e3059a - common/mlx5: consider local functions as internal

Thu, 24 Feb 2022 23:25:06 +0000

common/mlx5: consider local functions as internalThe functions which are not explicitly marked as internalwere exported because the local catch-all rule was missing in theversion script.After adding the missing rule, all local functions are hidden.The function mlx5_get_device_guid is used in another library,so it needs to be exported (as internal).Because the local functions were exported as non-internalin DPDK 21.11, any change in these functions would break the ABI.An ABI exception is added for this library, considering that allfunctions are either local or internal.Signed-off-by: Michael Baum Acked-by: Matan Azrad List of files: /dpdk/devtools/libabigail.abignore

a678c5d3 - cryptodev: add DSA random number k

Fri, 11 Feb 2022 16:02:35 +0000

cryptodev: add DSA random number kThis commit adds random number 'k' to DSAop param struct for asymmetric crypto ops.This parameter is crucial in stiuations where:- PMD cannot generate random number- User would like to provide random sourceAdditionally, it makes DSA consistent with ECDSAin terms of 'k' which includes this parameter.Signed-off-by: Arek Kusztal Acked-by: Akhil Goyal List of files: /dpdk/devtools/libabigail.abignore

8507a169 - security: add IPsec option for IP reassembly

Tue, 08 Feb 2022 22:20:27 +0000

security: add IPsec option for IP reassemblyA new option is added in IPsec to enable and attempt reassemblyof inbound IP packets.Signed-off-by: Akhil Goyal List of files: /dpdk/devtools/libabigail.abignore

fdab8f2e - version: 21.11-rc0

Sun, 08 Aug 2021 19:26:58 +0000

version: 21.11-rc0Start a new release cycle with empty release notes.The ABI version becomes 22.0.The map files are updated to the new ABI major number (22).The ABI exceptions are dropped and CI ABI checks are disabled becausecompatibility is not preserved.Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit Acked-by: David Marchand List of files: /dpdk/devtools/libabigail.abignore

02edbfab - ethdev: add dev configured flag

Wed, 07 Jul 2021 09:53:34 +0000

ethdev: add dev configured flagCurrently, if dev_configure is not called or fails to be called, userscan still call dev_start successfully. So it is necessary to have a flagwhich indicates whether the device is configured, to control whetherdev_start can be called and eliminate dependency on user invocation order.The flag stored in "struct rte_eth_dev_data" is more reasonable than "enum rte_eth_dev_state". "enum rte_eth_dev_state" is private to theprimary and secondary processes, and can be independently controlled.However, the secondary process does not make resource allocations anddoes not call dev_configure(). These are done by the primary processand can be obtained or used by the secondary process. So this patchadds a "dev_configured" flag in "rte_eth_dev_data", like "dev_started".Signed-off-by: Huisong Li Reviewed-by: Andrew Rybchenko Acked-by: Konstantin Ananyev libabigail raised a warning on this change.This change is fine wrt ABI as far as we understand, but we can'texpress an exception rule (see libabigail bug #28060) to waive thechanges only in this part of the rte_eth_dev_data struct.The solution for now is to globally waive any change on therte_eth_dev_data structure.Signed-off-by: David Marchand List of files: /dpdk/devtools/libabigail.abignore

9ad9ff47 - ethdev: add queue state in queried queue information

Mon, 19 Apr 2021 08:57:30 +0000

ethdev: add queue state in queried queue informationCurrently, upper-layer application could get queue state onlythrough pointers such as dev->data->tx_queue_state[queue_id],this is not the recommended way to access it. So this patchadd get queue state when call rte_eth_rx_queue_info_get andrte_eth_tx_queue_info_get API.Note: After add queue_state field, the 'struct rte_eth_rxq_info' sizeremains 128B, and the 'struct rte_eth_txq_info' size remains 64B, soit could be ABI compatible.Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou Acked-by: Konstantin Ananyev Acked-by: Thomas Monjalon Reviewed-by: Ferruh Yigit List of files: /dpdk/devtools/libabigail.abignore

f96a8ebb - eventdev: introduce crypto adapter enqueue API

Thu, 15 Apr 2021 09:13:49 +0000

eventdev: introduce crypto adapter enqueue APIIn case an event from a previous stage is required to be forwardedto a crypto adapter and PMD supports internal event port in cryptoadapter, exposed via capabilityRTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not havea way to check in the API rte_event_enqueue_burst(), whether it isfor crypto adapter or for eth tx adapter.Hence we need a new API similar to rte_event_eth_tx_adapter_enqueue(),which can send to a crypto adapter.Note that RTE_EVENT_TYPE_* cannot be used to make that decision,as it is meant for event source and not event destination.And event port designated for crypto adapter is designed to be usedfor OP_NEW mode.Hence, in order to support an event PMD which has an internal event portin crypto adapter (RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode), exposedvia capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD,application should use rte_event_crypto_adapter_enqueue() API to enqueueevents.When internal port is not available(RTE_EVENT_CRYPTO_ADAPTER_OP_NEW mode),application can use API rte_event_enqueue_burst() as it was doing earlier,i.e. retrieve event port used by crypto adapter and bind its event queuesto that port and enqueue events using the API rte_event_enqueue_burst().Signed-off-by: Akhil Goyal Acked-by: Abhinandan Gujjar Acked-by: Jerin Jacob List of files: /dpdk/devtools/libabigail.abignore

d014dddb - cryptodev: support multiple cipher data-units

Wed, 14 Apr 2021 20:21:58 +0000

cryptodev: support multiple cipher data-unitsIn cryptography, a block cipher is a deterministic algorithm operatingon fixed-length groups of bits, called blocks.A block cipher consists of two paired algorithms, one for encryptionand the other for decryption. Both algorithms accept two inputs:an input block of size n bits and a key of size k bits; and both yieldan n-bit output block. The decryption algorithm is defined to be theinverse function of the encryption.For AES standard the block size is 16 bytes.For AES in XTS mode, the data to be encrypted\decrypted does not have tobe multiple of 16B size, the unit of data is called data-unit.The data-unit size can be any size in range [16B, 2^24B], so, in thiscase, a data stream is divided into N amount of equal data-units andmust be encrypted\decrypted in the same data-unit resolution.For ABI compatibility reason, the size is limited to 64K (16-bit field).The new field dataunit_len is inserted in a struct padding hole,which is only 2 bytes long in 32-bit build.It could be moved and extended later during an ABI-breakage window.The current cryptodev API doesn't allow the user to select a specificdata-unit length supported by the devices.In addition, there is no definition how the IV is detected per data-unitwhen single operation includes more than one data-unit.That causes applications to use single operation per data-unit even thoughall the data is continuous in memory what reduces datapath performance.Add a new feature flag to support multiple data-unit sizes, calledRTE_CRYPTODEV_FF_CIPHER_MULTIPLE_DATA_UNITS.Add a new field in cipher capability, called dataunit_set,where the devices can report the range of the supported data-unit sizes.Add a new cipher transformation field, called dataunit_len, where the usercan select the data-unit length for all the operations.All the new fields do not change the size of their structures,by filling some struct padding holes.They are added as exceptions in the ABI check file libabigail.abignore.Using a bitmap to report the supported data-unit sizes capability allowsthe devices to report a range simply as same as the user to read itsimply. also, thus sizes are usually common and probably will be sharedamong different devices.Signed-off-by: Matan Azrad Signed-off-by: Thomas Monjalon Acked-by: Akhil Goyal List of files: /dpdk/devtools/libabigail.abignore

1a3022b2 - devtools: remove ethdev ABI exception

Mon, 01 Feb 2021 18:08:52 +0000

devtools: remove ethdev ABI exceptionNow that the ethernet driver dev_ops structure definition is notexported anymore, there is no need for an exception.abidiff will only consider structures defined in the installed headers(passed with --headers-dirX options).Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")Signed-off-by: David Marchand Acked-by: Ferruh Yigit Acked-by: Maxime Coquelin List of files: /dpdk/devtools/libabigail.abignore

8d935fff - bus/vdev: add driver IOVA VA mode requirement

Tue, 26 Jan 2021 10:15:57 +0000

bus/vdev: add driver IOVA VA mode requirementThis patch adds driver flag in vdev bus driver so thatvdev drivers can require VA IOVA mode to be used, whichfor example the case of Virtio-user PMD.The patch implements the .get_iommu_class() callback, thatis called before devices probing to determine the IOVA modeto be used, and adds a check right before the device isprobed to ensure compatible IOVA mode has been selected.It also adds a ABI exception rule to accommodate with anupdate on the driver registration APISigned-off-by: Maxime Coquelin Acked-by: David Marchand Reviewed-by: Chenbo Xia List of files: /dpdk/devtools/libabigail.abignore

78d3dd3e - devtools: fix cryptodev ABI suppress rule

Wed, 20 Jan 2021 14:25:57 +0000

devtools: fix cryptodev ABI suppress ruleUpdate the ignore entry for crytodev to use named fieldsinstead of bit positions.It is allowing changes between the last field (attached) in ABI 21.0,and the end of the padded struct in ABI 21.Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks")Signed-off-by: Ray Kinsella Acked-by: Thomas Monjalon List of files: /dpdk/devtools/libabigail.abignore

f0f93a7a - buildtools: use Python pmdinfogen

Sun, 24 Jan 2021 20:51:56 +0000

buildtools: use Python pmdinfogenUse the same interpreter to run pmdinfogen as for other build scripts.Adjust wrapper script accordingly and also don't suppress stderr from arand pmdinfogen. Add configure-time check for elftools Python module forUnix hosts.Add pyelftools to CI configuration and build requirements for Linux andFreeBSD. Windows targets are not currently using pmdinfogen.Suppress ABI warnings about generated PMD information strings.Signed-off-by: Dmitry Kozlyuk Acked-by: Neil Horman Tested-by: Jie Zhou List of files: /dpdk/devtools/libabigail.abignore

1c3ffb95 - cryptodev: add enqueue and dequeue callbacks

Tue, 22 Dec 2020 14:42:42 +0000

cryptodev: add enqueue and dequeue callbacksThis patch adds APIs to add/remove callback functions on cryptoenqueue/dequeue burst. The callback function will be called foreach burst of crypto ops received/sent on a given crypto devicequeue pair.Signed-off-by: Abhinandan Gujjar Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal List of files: /dpdk/devtools/libabigail.abignore

1fe3eef5 - ethdev: add simple power management API

Thu, 14 Jan 2021 14:46:08 +0000

ethdev: add simple power management APIAdd a simple API to allow getting the monitor conditions forpower-optimized monitoring of the Rx queues from the PMD, as well asrelease notes information.Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Andrew Rybchenko List of files: /dpdk/devtools/libabigail.abignore

4f86c0ba - version: 20.11-rc0

Mon, 10 Aug 2020 15:10:20 +0000

version: 20.11-rc0Start a new release cycle with empty release notes.The ABI version becomes 21.0.The ABI major is back to normal, having only one number (21 vs 20.0).The map files are updated to the new ABI major number (21).The ABI exceptions are dropped.Travis ABI check is disabled because compatibility is not preserved.Signed-off-by: Thomas Monjalon Acked-by: Ray Kinsella List of files: /dpdk/devtools/libabigail.abignore