Changes in test_link_bonding.c

b3eaaf1d - net/bonding: fix slaves initializing on MTU setting

Tue, 15 Feb 2022 10:59:40 +0000

net/bonding: fix slaves initializing on MTU settingIf a initial process for the bonding device is like:rte_eth_dev_configurerte_eth_dev_set_mtuqueue setup and start, etc.Pass the vdev args to application, and init bonding device only.-a 0000:af:00.0 --vdev="net_bonding0,mode=2,slave=0000:af:00.0"It will fail and complain for the slave device"Port 0 must be configured before MTU set"Test can be reproduced with ovs.Fixes: b26bee10ee37 ("ethdev: forbid MTU set before device configure")Cc: stable@dpdk.orgSigned-off-by: Junjie Wan Tested-by: Ferruh Yigit Acked-by: Min Hu (Connor) List of files: /dpdk/app/test/test_link_bonding.c

06c047b6 - remove unnecessary null checks

Wed, 09 Feb 2022 19:17:15 +0000

remove unnecessary null checksFunctions like free, rte_free, and rte_mempool_freealready handle NULL pointer so the checks here are not necessary.Remove redundant NULL pointer checks before free functionsfound by nullfree.cocciSigned-off-by: Stephen Hemminger List of files: /dpdk/app/test/test_link_bonding.c

4a6672c2 - fix spelling in comments and doxygen

Fri, 12 Nov 2021 00:02:09 +0000

fix spelling in comments and doxygenFix spelling errors in comments including doxygen found using codespell.Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev Acked-by: Vladimir Medvedkin Reviewed-by: Honnappa Nagarahalli Acked-by: Ray Kinsella Acked-by: Cristian Dumitrescu Acked-by: Chenbo Xia List of files: /dpdk/app/test/test_link_bonding.c

295968d1 - ethdev: add namespace

Fri, 22 Oct 2021 11:03:12 +0000

ethdev: add namespaceAdd 'RTE_ETH' namespace to all enums & macros in a backward compatibleway. The macros for backward compatibility can be removed in next LTS.Also updated some struct names to have 'rte_eth' prefix.All internal components switched to using new names.Syntax fixed on lines that this patch touches.Signed-off-by: Ferruh Yigit Acked-by: Tyler Retzlaff Acked-by: Andrew Rybchenko Acked-by: Ajit Khaparde Acked-by: Jerin Jacob Acked-by: Wisam Jaddo Acked-by: Rosen Xu Acked-by: Chenbo Xia Acked-by: Hemant Agrawal Acked-by: Somnath Kotur List of files: /dpdk/app/test/test_link_bonding.c

1bb4a528 - ethdev: fix max Rx packet length

Mon, 18 Oct 2021 13:48:48 +0000

ethdev: fix max Rx packet lengthThere is a confusion on setting max Rx packet length, this patch aims toclarify it.'rte_eth_dev_configure()' API accepts max Rx packet size via'uint32_t max_rx_pkt_len' field of the config struct 'structrte_eth_conf'.Also 'rte_eth_dev_set_mtu()' API can be used to set the MTU, and resultstored into '(struct rte_eth_dev)->data->mtu'.These two APIs are related but they work in a disconnected way, theystore the set values in different variables which makes hard to figureout which one to use, also having two different method for a relatedfunctionality is confusing for the users.Other issues causing confusion is:* maximum transmission unit (MTU) is payload of the Ethernet frame. And 'max_rx_pkt_len' is the size of the Ethernet frame. Difference is Ethernet frame overhead, and this overhead may be different from device to device based on what device supports, like VLAN and QinQ.* 'max_rx_pkt_len' is only valid when application requested jumbo frame, which adds additional confusion and some APIs and PMDs already discards this documented behavior.* For the jumbo frame enabled case, 'max_rx_pkt_len' is an mandatory field, this adds configuration complexity for application.As solution, both APIs gets MTU as parameter, and both saves the resultin same variable '(struct rte_eth_dev)->data->mtu'. For this'max_rx_pkt_len' updated as 'mtu', and it is always valid independentfrom jumbo frame.For 'rte_eth_dev_configure()', 'dev->data->dev_conf.rxmode.mtu' is userrequest and it should be used only within configure function and resultshould be stored to '(struct rte_eth_dev)->data->mtu'. After that pointboth application and PMD uses MTU from this variable.When application doesn't provide an MTU during 'rte_eth_dev_configure()'default 'RTE_ETHER_MTU' value is used.Additional clarification done on scattered Rx configuration, inrelation to MTU and Rx buffer size.MTU is used to configure the device for physical Rx/Tx size limitation,Rx buffer is where to store Rx packets, many PMDs use mbuf data buffersize as Rx buffer size.PMDs compare MTU against Rx buffer size to decide enabling scattered Rxor not. If scattered Rx is not supported by device, MTU bigger than Rxbuffer size should fail.Signed-off-by: Ferruh Yigit Acked-by: Ajit Khaparde Acked-by: Somnath Kotur Acked-by: Huisong Li Acked-by: Andrew Rybchenko Acked-by: Konstantin Ananyev Acked-by: Rosen Xu Acked-by: Hyong Youb Kim List of files: /dpdk/app/test/test_link_bonding.c

df96fd0d - ethdev: make driver-only headers private

Fri, 29 Jan 2021 16:48:19 +0000

ethdev: make driver-only headers privateThe rte_ethdev_driver.h, rte_ethdev_vdev.h and rte_ethdev_pci.h files arefor drivers only and should be a private to DPDK and not installed.Signed-off-by: Bruce Richardson Reviewed-by: Maxime Coquelin Acked-by: Thomas Monjalon Acked-by: Steven Webster List of files: /dpdk/app/test/test_link_bonding.c

0ead65af - test: check stop call status

Thu, 15 Oct 2020 13:30:36 +0000

test: check stop call statusrte_eth_dev_stop() return value was changed from void to int,so this patch modify usage of this function across test/eventaccording to new return type.Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko List of files: /dpdk/app/test/test_link_bonding.c

7de47c3c - test/bonding: fix LSC timeout unit

Fri, 23 Aug 2019 08:16:59 +0000

test/bonding: fix LSC timeout unitFixes: 76d29903f5f5 ("bond: support link status interrupt")Cc: stable@dpdk.orgSigned-off-by: Krzysztof Kanas Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c

88524d6b - test/bonding: fix LSC related cases

Fri, 23 Aug 2019 08:16:58 +0000

test/bonding: fix LSC related casesOn rare situation test_link_bonding test case fail due to timespectv_nsec overflow, which causes pthread_cond_timedwait to return EINVALand test to fail.Fixes: 76d29903f5f5 ("bond: support link status interrupt")Cc: stable@dpdk.orgSigned-off-by: Krzysztof Kanas Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c

6fcf8586 - app: check status of getting MAC address

Tue, 10 Sep 2019 08:52:17 +0000

app: check status of getting MAC addressThe return value of rte_eth_macaddr_get() was changed from void to int.Update the usage of the functions according to the new return type.Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko List of files: /dpdk/app/test/test_link_bonding.c

844949ec - app: check status of getting link info

Tue, 10 Sep 2019 08:25:47 +0000

app: check status of getting link infoThe return value of rte_eth_link_get() and rte_eth_link_get_nowait()was changed from void to int. Update the usage of the functionsaccording to the new return type.Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko List of files: /dpdk/app/test/test_link_bonding.c

70e51a0e - app: check code of promiscuous mode switch

Sat, 14 Sep 2019 11:37:26 +0000

app: check code of promiscuous mode switchrte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() returnvalue was changed from void to int, so this patch modify usageof these functions across apps according to new return type.Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko List of files: /dpdk/app/test/test_link_bonding.c

0c9da755 - net: replace IPv4/v6 constants with uppercase name

Wed, 29 May 2019 11:29:16 +0000

net: replace IPv4/v6 constants with uppercase nameSince we change these macros, we might as well avoid triggering complaintsfrom checkpatch because of mixed case.old=RTE_IPv4new=RTE_IPV4git grep -lw $old | xargs sed -i -e "s/\<$old\>/$new/g"old=RTE_ETHER_TYPE_IPv4new=RTE_ETHER_TYPE_IPV4git grep -lw $old | xargs sed -i -e "s/\<$old\>/$new/g"old=RTE_ETHER_TYPE_IPv6new=RTE_ETHER_TYPE_IPV6git grep -lw $old | xargs sed -i -e "s/\<$old\>/$new/g"Signed-off-by: David Marchand Reviewed-by: Olivier Matz List of files: /dpdk/app/test/test_link_bonding.c

e73e3547 - net: add rte prefix to UDP structure

Tue, 21 May 2019 16:13:14 +0000

net: add rte prefix to UDP structureAdd 'rte_' prefix to structures:- rename struct udp_hdr as struct rte_udp_hdr.Signed-off-by: Olivier Matz Reviewed-by: Stephen Hemminger Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c

a7c528e5 - net: add rte prefix to IP structure

Tue, 21 May 2019 16:13:10 +0000

net: add rte prefix to IP structureAdd 'rte_' prefix to structures:- rename struct ipv4_hdr as struct rte_ipv4_hdr.- rename struct ipv6_hdr as struct rte_ipv6_hdr.Signed-off-by: Olivier Matz Reviewed-by: Stephen Hemminger Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c

35b2d13f - net: add rte prefix to ether defines

Tue, 21 May 2019 16:13:05 +0000

net: add rte prefix to ether definesAdd 'RTE_' prefix to defines:- rename ETHER_ADDR_LEN as RTE_ETHER_ADDR_LEN.- rename ETHER_TYPE_LEN as RTE_ETHER_TYPE_LEN.- rename ETHER_CRC_LEN as RTE_ETHER_CRC_LEN.- rename ETHER_HDR_LEN as RTE_ETHER_HDR_LEN.- rename ETHER_MIN_LEN as RTE_ETHER_MIN_LEN.- rename ETHER_MAX_LEN as RTE_ETHER_MAX_LEN.- rename ETHER_MTU as RTE_ETHER_MTU.- rename ETHER_MAX_VLAN_FRAME_LEN as RTE_ETHER_MAX_VLAN_FRAME_LEN.- rename ETHER_MAX_VLAN_ID as RTE_ETHER_MAX_VLAN_ID.- rename ETHER_MAX_JUMBO_FRAME_LEN as RTE_ETHER_MAX_JUMBO_FRAME_LEN.- rename ETHER_MIN_MTU as RTE_ETHER_MIN_MTU.- rename ETHER_LOCAL_ADMIN_ADDR as RTE_ETHER_LOCAL_ADMIN_ADDR.- rename ETHER_GROUP_ADDR as RTE_ETHER_GROUP_ADDR.- rename ETHER_TYPE_IPv4 as RTE_ETHER_TYPE_IPv4.- rename ETHER_TYPE_IPv6 as RTE_ETHER_TYPE_IPv6.- rename ETHER_TYPE_ARP as RTE_ETHER_TYPE_ARP.- rename ETHER_TYPE_VLAN as RTE_ETHER_TYPE_VLAN.- rename ETHER_TYPE_RARP as RTE_ETHER_TYPE_RARP.- rename ETHER_TYPE_QINQ as RTE_ETHER_TYPE_QINQ.- rename ETHER_TYPE_ETAG as RTE_ETHER_TYPE_ETAG.- rename ETHER_TYPE_1588 as RTE_ETHER_TYPE_1588.- rename ETHER_TYPE_SLOW as RTE_ETHER_TYPE_SLOW.- rename ETHER_TYPE_TEB as RTE_ETHER_TYPE_TEB.- rename ETHER_TYPE_LLDP as RTE_ETHER_TYPE_LLDP.- rename ETHER_TYPE_MPLS as RTE_ETHER_TYPE_MPLS.- rename ETHER_TYPE_MPLSM as RTE_ETHER_TYPE_MPLSM.- rename ETHER_VXLAN_HLEN as RTE_ETHER_VXLAN_HLEN.- rename ETHER_ADDR_FMT_SIZE as RTE_ETHER_ADDR_FMT_SIZE.- rename VXLAN_GPE_TYPE_IPV4 as RTE_VXLAN_GPE_TYPE_IPV4.- rename VXLAN_GPE_TYPE_IPV6 as RTE_VXLAN_GPE_TYPE_IPV6.- rename VXLAN_GPE_TYPE_ETH as RTE_VXLAN_GPE_TYPE_ETH.- rename VXLAN_GPE_TYPE_NSH as RTE_VXLAN_GPE_TYPE_NSH.- rename VXLAN_GPE_TYPE_MPLS as RTE_VXLAN_GPE_TYPE_MPLS.- rename VXLAN_GPE_TYPE_GBP as RTE_VXLAN_GPE_TYPE_GBP.- rename VXLAN_GPE_TYPE_VBNG as RTE_VXLAN_GPE_TYPE_VBNG.- rename ETHER_VXLAN_GPE_HLEN as RTE_ETHER_VXLAN_GPE_HLEN.Do not update the command line library to avoid adding a dependency tolibrte_net.Signed-off-by: Olivier Matz Reviewed-by: Stephen Hemminger Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c

538da7a1 - net: add rte prefix to ether functions

Tue, 21 May 2019 16:13:04 +0000

net: add rte prefix to ether functionsAdd 'rte_' prefix to functions:- rename is_same_ether_addr() as rte_is_same_ether_addr().- rename is_zero_ether_addr() as rte_is_zero_ether_addr().- rename is_unicast_ether_addr() as rte_is_unicast_ether_addr().- rename is_multicast_ether_addr() as rte_is_multicast_ether_addr().- rename is_broadcast_ether_addr() as rte_is_broadcast_ether_addr().- rename is_universal_ether_addr() as rte_is_universal_ether_addr().- rename is_local_admin_ether_addr() as rte_is_local_admin_ether_addr().- rename is_valid_assigned_ether_addr() as rte_is_valid_assigned_ether_addr().- rename eth_random_addr() as rte_eth_random_addr().- rename ether_addr_copy() as rte_ether_addr_copy().- rename ether_format_addr() as rte_ether_format_addr().Signed-off-by: Olivier Matz Reviewed-by: Stephen Hemminger Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c

6d13ea8e - net: add rte prefix to ether structures

Tue, 21 May 2019 16:13:03 +0000

net: add rte prefix to ether structuresAdd 'rte_' prefix to structures:- rename struct ether_addr as struct rte_ether_addr.- rename struct ether_hdr as struct rte_ether_hdr.- rename struct vlan_hdr as struct rte_vlan_hdr.- rename struct vxlan_hdr as struct rte_vxlan_hdr.- rename struct vxlan_gpe_hdr as struct rte_vxlan_gpe_hdr.Do not update the command line library to avoid adding a dependency tolibrte_net.Signed-off-by: Olivier Matz Reviewed-by: Stephen Hemminger Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c

e482e0fa - net: add rte prefix to ARP defines

Tue, 21 May 2019 16:13:02 +0000

net: add rte prefix to ARP definesAdd 'RTE_' prefix to defines:- rename ARP_HRD_ETHER as RTE_ARP_HRD_ETHER.- rename ARP_OP_REQUEST as RTE_ARP_OP_REQUEST.- rename ARP_OP_REPLY as RTE_ARP_OP_REPLY.- rename ARP_OP_REVREQUEST as RTE_ARP_OP_REVREQUEST.- rename ARP_OP_REVREPLY as RTE_ARP_OP_REVREPLY.- rename ARP_OP_INVREQUEST as RTE_ARP_OP_INVREQUEST.- rename ARP_OP_INVREPLY as RTE_ARP_OP_INVREPLY.Signed-off-by: Olivier Matz Reviewed-by: Stephen Hemminger Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c

f2745bfe - net: add rte prefix to ARP structures

Tue, 21 May 2019 16:13:01 +0000

net: add rte prefix to ARP structuresAlso rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fieldsto avoid conflict with the #defines in gnu libc.Signed-off-by: Olivier Matz Reviewed-by: Stephen Hemminger Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit List of files: /dpdk/app/test/test_link_bonding.c