Lines Matching refs:commit

37 those requested during any post-commit review.
44 Post-commit review is encouraged, and can be accomplished using any of the
46 promptly to post-commit feedback and address it. Failure to do so is cause for
49 If a community member expresses a concern about a recent commit, and this
51 pre-commit review (including around the need for more design discussions),
56 this is inherent to our post-commit review practices.
67 Please note: The bar for post-commit feedback is not higher than for pre-commit
70 pre-commit (had you noticed it earlier), please feel free to provide that
75 address the issues than comment on the original commit. The original patch
81 Pre-commit code reviews are conducted on our web-based code-review tool (see
82 :doc:`Phabricator`). Post-commit reviews can be done on Phabricator, by email
83 on the relevant project's commit mailing list, on the project's development
117 commit message).
141 When providing an unqualified LGTM (approval to commit), it is the
169 then you shouldn't be providing final approval to commit. A reviewer providing
170 final approval should have commit access to the LLVM project.