| #
c9db3de7 |
| 18-Sep-2023 |
Kadi Kraman <[email protected]> |
[expo-dev-menu] fix ts and linting (#24497)
# Why
The `expo-dev-menu` package is set up a bit differently from the others
and includes code in the `./app` directory whereas the `lint` command
o
[expo-dev-menu] fix ts and linting (#24497)
# Why
The `expo-dev-menu` package is set up a bit differently from the others
and includes code in the `./app` directory whereas the `lint` command
only lints the `./src` directory.
A similar issue applies for the `tsc` command (the `app` directory was
not in the `tsconfig.json`).
# How
- updated the `lint` script to also lint the `./app` directory
- added a `ts:check` script
- added `./app` to `tsconfig.json`
# Test Plan
I loaded the dev menu in `bare-expo` locally to ensure no regressions
after the type changes.
# Checklist
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|
| #
a087816b |
| 14-Sep-2023 |
Kadi Kraman <[email protected]> |
[dev-menu] [ENG-10036] update dev menu to make refresh more prominent (#24426)
# Why
Refresh is the most often used button in the dev menu, but it is not the
one that stands out the most.
This
[dev-menu] [ENG-10036] update dev menu to make refresh more prominent (#24426)
# Why
Refresh is the most often used button in the dev menu, but it is not the
one that stands out the most.
This change will clean up the dev menu to separate out the refresh
button and make it stand out more.
# How
- move the "copy link" button next to the URL (since that's the link
you're copying)
- make the whole link section peessable (not just the link icon)
- move "home" next to the other buttons
- move "reload" next to the other buttons, but separate it out to its
own section
show more ...
|
| #
ec820491 |
| 14-Sep-2023 |
Alan Hughes <[email protected]> |
[dev-menu] Add new hotkey binding (#24434)
|
| #
63fb203d |
| 21-Aug-2023 |
Kudo Chien <[email protected]> |
chore: update react-native to 0.72.4 (#24044)
close ENG-9814
- update react-native to 0.72.4 - [react-native-lab] cherry pick native changes - [babel-preset-expo] bump `metro-react-native-babel-pre
chore: update react-native to 0.72.4 (#24044)
close ENG-9814
- update react-native to 0.72.4 - [react-native-lab] cherry pick native changes - [babel-preset-expo] bump `[email protected]` - [android][ios] re-version sdk-49 code - [dev-menu][dev-launcher] rebuild js bundles
versioned expo go + sdk 49 project smoke test
show more ...
|
| #
6b843f31 |
| 03-Aug-2023 |
Evan Bacon <[email protected]> |
Migrate parts of repo to expo cli (#23806)
|
| #
895fafd4 |
| 03-Jul-2023 |
Kudo Chien <[email protected]> |
chore: update react-native to 0.72.1 (#23262)
# Why
update react-native 0.72.1 for sdk 49
# How
- bump react-native to 0.72.1
- re-version android/ios sdk 49 code
- [react-native-lab] che
chore: update react-native to 0.72.1 (#23262)
# Why
update react-native 0.72.1 for sdk 49
# How
- bump react-native to 0.72.1
- re-version android/ios sdk 49 code
- [react-native-lab] cherry-pick necessary commits between 0.72.0..0.72.1
# Test Plan
- ci passed
- bare-expo
- versioned expo go
show more ...
|
| #
a9c42bb2 |
| 22-Jun-2023 |
Kudo Chien <[email protected]> |
chore: update [email protected] (#23014)
# Why
update 0.72.0 for sdk 49
# How
- there's no new changes since rc.6, it's just version bumps and lock file updates.
- [react-native-lab] reb
chore: update [email protected] (#23014)
# Why
update 0.72.0 for sdk 49
# How
- there's no new changes since rc.6, it's just version bumps and lock file updates.
- [react-native-lab] rebase our changes on top of 0.72.0. also brings a new commit for ios versioning in #23012
---------
Co-authored-by: Brent Vatne <[email protected]>
show more ...
|
| #
8b069ce6 |
| 20-Jun-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[android][dev-launcher][dev-menu] Fix eventemitter error when fabric is enabled (#22977)
# Why
Updating react-native to the new RC revealed a misconfiguration on
dev-client when using the new ar
[android][dev-launcher][dev-menu] Fix eventemitter error when fabric is enabled (#22977)
# Why
Updating react-native to the new RC revealed a misconfiguration on
dev-client when using the new architecture, which was causing the app to
crash.
<img width="402" alt="image"
src="https://github.com/expo/expo/assets/11707729/51c381d3-b41f-430a-a20c-9d9a7ddd8722">
Closes ENG-7955
# How
- Replace `ReactActivityDelegate` with the new
`DefaultReactActivityDelegate` class
- Close the DevMenu from the native side before opening Dev Menu from
React Native
- Update DevMenu bundle
# Test Plan
Run dev-client locally through fabric-tester and bare-expo
<table>
<tr><th>fabric-tester</th><th>bare-expo</th></tr>
<tr>
<td>
<video
src="https://github.com/expo/expo/assets/11707729/f6bacf5d-f257-4d7c-9864-65df9b734048"/>
</td>
<td>
<video
src="https://github.com/expo/expo/assets/11707729/99205a53-2144-4ee0-981e-bcd2d8285212"
/>
</td>
</tr>
</table>
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|
| #
7603b8a1 |
| 16-Jun-2023 |
Kudo Chien <[email protected]> |
chore: update [email protected] (#22898)
# Why
0.72.0-rc.6 coming with some meaningful fixes, let bump this version for sdk 49 development & testing.
# How
- update [email protected]
chore: update [email protected] (#22898)
# Why
0.72.0-rc.6 coming with some meaningful fixes, let bump this version for sdk 49 development & testing.
# How
- update [email protected]
- [react-native-lab] cherry-picks commits between rc.5..rc.6
- [templates][go][bare-expo][fabric-tester] apply workaround for gradle 8 + java 17 build error
- [go] update to gradle 8 (i missed this one when updating 0.72)
# Test Plan
ci passed
show more ...
|
| #
c0a96678 |
| 07-Jun-2023 |
Kudo Chien <[email protected]> |
Upgrade react-native 0.72.0-rc.5 (#22588)
# Why
upgrade react-native 0.72 for sdk 49
close ENG-8011
# How
- bump package versions
- `react-native 0.71.3 -> 0.72.0-rc.5`
- `metro-reac
Upgrade react-native 0.72.0-rc.5 (#22588)
# Why
upgrade react-native 0.72 for sdk 49
close ENG-8011
# How
- bump package versions
- `react-native 0.71.3 -> 0.72.0-rc.5`
- `metro-react-native-babel-preset 0.73.9 -> 0.76.5`
- [bare-expo][templates][fabric-tester] migrate template base on [upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.71.7&to=0.72.0-rc.5)
- [expo-template-tabs] remove the metro version overrides for expo-router.
- [core][dev-laucher][dev-menu][media-library][screen-orientation][splash-screen][updates-interface][updates] add the `install_modules_dependencies` to support new architecture + use_frameworks!
- [core][autolinking] fix some new architecture error on ios
- [react-native-lab] update our fork to 0.72.0-rc.5 based
- [go][tools] fix **react-native-lab/react-native/packages/react-native** path move because of react-native's repo monorepo changes
- [go][android] fix gradle 8 errors
- [go][ios] add `RCT_REMOTE_PROFILE=0` to fix the `RCT_ENABLE_INSPECTOR needs to be set to fulfill RCT_REMOTE_PROFILE` build error
- [ncl] remove `ProgressViewIOS` / `ProgressBarAndroid` since they are deprecated/removed in 0.72
- [dev-menu][dev-launcher] rebuild bundles
# Note
- react-native-web is not bumped because of the [issue](https://github.com/necolas/react-native-web/issues/2523), so it's still react-native-web@~0.18.10.
- currently disable ci typecheck for @expo/cli because of upstream metro typescript support. i'll have another pr to fix those errors.
- updates e2e ci on android is broken at [here](https://github.com/expo/expo/blob/fada3d764957779fbfc3d7b723d185db1d933d95/packages/expo-updates/e2e/fixtures/Updates.e2e.ts#L518). i doubt if that's related to the react scheduler change. i'd disabled the failed test case.
- the react-native upstream [migrated away the `@types/jest`](https://github.com/facebook/react-native/pull/36068). i was afraid that will be a breaking change to the existing jest test code since it requires the explicit `@jest/globals` import. i didn't do this in this upgrade.
# Test Plan
- ✅ fabric-tester (without expo-dev-client)
- ✅ ci passed. there are some errors which are known:
- updates e2e on android: as mentioned above
- ios expo go on eas build: versioned expo go are broken on eas build m1 worker. this is also happening on main.
- android client: no space left on the ubuntu worker. this is also happening on main.
- ✅ bare-expo
- ✅ unversioned expo go + ncl
---------
Co-authored-by: Tomasz Sapeta <[email protected]>
show more ...
|
| #
210d3757 |
| 30-May-2023 |
Łukasz Kosmaty <[email protected]> |
[menu][Android] Rewrite safe area view using new API (#21609)
|
| #
c516e737 |
| 19-May-2023 |
Łukasz Kosmaty <[email protected]> |
[menu][Android] Start using new modules API (#21582)
# Why
Rewrite some menu modules to use the new API.
# Test Plan
- bare-expo ✅
|
| #
ab35a1c5 |
| 26-Apr-2023 |
Kudo Chien <[email protected]> |
Upgrade react-native 0.71.7 (#22253)
upgrade react-native 0.71.7 for ios hermes performance regression and samsung textinput issues: https://github.com/facebook/react-native/releases/tag/v0.71.7
-
Upgrade react-native 0.71.7 (#22253)
upgrade react-native 0.71.7 for ios hermes performance regression and samsung textinput issues: https://github.com/facebook/react-native/releases/tag/v0.71.7
- update `[email protected]` in package.json - update our react-native fork to 0.71.7 - re-version sdk 48 code because there are ios hermes changes and android java code changes - [skia] fix build error on xcode 14.3 - [dev-menu][dev-launcher] update bundles
- ci passed - cli and versioned ios client eas build are expected to fail on sdk-48. - android/ios versioned expo go + ncl
(cherry picked from commit b0d7000924600e305b68b8a1f873d575bbfec7ec)
show more ...
|
| #
220bab53 |
| 03-Apr-2023 |
Kudo Chien <[email protected]> |
[packages][templates] update react-native 0.71.6 (#21909)
# Why
update react-native 0.71.6 for sdk 48. the changelog is at https://github.com/facebook/react-native/releases/tag/v0.71.5 and https:
[packages][templates] update react-native 0.71.6 (#21909)
# Why
update react-native 0.71.6 for sdk 48. the changelog is at https://github.com/facebook/react-native/releases/tag/v0.71.5 and https://github.com/facebook/react-native/releases/tag/v0.71.6 which has some meaningful fixes.
# How
update package versions
# Test Plan
ci passed
show more ...
|
| #
1171baab |
| 22-Mar-2023 |
Łukasz Kosmaty <[email protected]> |
[client] Remove vendored gesture handler (#21502)
# Why
Removes vendored gesture handler.
Another step to support Fabric by the dev-client.
> Note: To support fabric in the dev-client, we nee
[client] Remove vendored gesture handler (#21502)
# Why
Removes vendored gesture handler.
Another step to support Fabric by the dev-client.
> Note: To support fabric in the dev-client, we need to rewrite the safe area context, but that won't be difficult, because that module is pretty straightforward and we can use our API to support both renderers.
# How
- Removed vendored code.
- Mocked functions required by react-navigation.
- Disabled gesture in the stack navigator.
The swipe gesture won't longer close a screen, but I think it's something that we can sacrifice. Also, most of our screens are rendered inside the bottom tab navigator.
# Test Plan
- bare-expo on both platforms ✅
- ensures that the stack navigator works correctly ✅
show more ...
|
| #
52945175 |
| 22-Mar-2023 |
Kudo Chien <[email protected]> |
[dev-client] rebuild js for react-native version bump
|
| #
169f3220 |
| 03-Mar-2023 |
Łukasz Kosmaty <[email protected]> |
[menu] Improve bottom sheet behaviour (#21486)
# Why
Improves the behavior of the native bottom sheet.
Closes https://github.com/expo/expo/issues/21356.
# How
- Started a collapse animati
[menu] Improve bottom sheet behaviour (#21486)
# Why
Improves the behavior of the native bottom sheet.
Closes https://github.com/expo/expo/issues/21356.
# How
- Started a collapse animation when the menu action was pressed
- Added a way for users to close or hide the menu from js
- Added small padding on Android to improve user experience
- Extensions can now decide if executing them should trigger collapse animation. It's set to true by default.
# Test Plan
- bare-expo ✅
- https://snack.expo.dev/@honeycomb-wallwisher/forlorn-soda ✅
show more ...
|
| #
e870aeee |
| 24-Feb-2023 |
Łukasz Kosmaty <[email protected]> |
[menu] Reimplement the bottom sheet using native languages (#21268)
# Why
Closes ENG-7280.
Reimplemented the bottom sheet using native languages and removed reanimated from vendored modules.
B
[menu] Reimplement the bottom sheet using native languages (#21268)
# Why
Closes ENG-7280.
Reimplemented the bottom sheet using native languages and removed reanimated from vendored modules.
By doing that we improve the build speed.
# How
- On Android, I've used the material design bottom sheet. We may want to copy the implementation from the original repo to ours to avoid extra dependency.
- On iOS, I've copied the implementation from https://github.com/applidium/OverlayContainer. I managed to test a couple of different libraries and that one works the best with RN.
# Test Plan
- bare-expo on both platforms ✅
show more ...
|
| #
95b09b82 |
| 08-Feb-2023 |
Łukasz Kosmaty <[email protected]> |
[dev-menu] Update vendored reanimated to `2.14.4` (#21082)
# Why
Updates vendored reanimated module to `2.14.4`
# How
Run and adjust the output of:
```
et vendor -c "[dev-menu] reanimated
[dev-menu] Update vendored reanimated to `2.14.4` (#21082)
# Why
Updates vendored reanimated module to `2.14.4`
# How
Run and adjust the output of:
```
et vendor -c "[dev-menu] reanimated"
```
# Test Plan
- NCL with bare-expo
- JSC ✅
- Hermes ✅
show more ...
|
| #
3e3ca024 |
| 21-Nov-2022 |
Łukasz Kosmaty <[email protected]> |
[dev-client] Fix `RCTStatusBarManager` module requires that the `UIViewControllerBasedStatusBarAppearance` to be false (#20104)
# Why
Fixes https://github.com/expo/expo/issues/20047.
# How
[dev-client] Fix `RCTStatusBarManager` module requires that the `UIViewControllerBasedStatusBarAppearance` to be false (#20104)
# Why
Fixes https://github.com/expo/expo/issues/20047.
# How
Made sure that `StatusBar` won't be imported by any dev-client code.
# Test Plan
- bare-expo ✅
- simple app outside of the expo/expo repo
show more ...
|
| #
12075537 |
| 07-Nov-2022 |
aleqsio <[email protected]> |
Add manifest key to allow RTL in expo go experiences (#19634)
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Łukasz Kosmaty <[email protected]>
Co
Add manifest key to allow RTL in expo go experiences (#19634)
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Łukasz Kosmaty <[email protected]>
Co-authored-by: Tomasz Sapeta <[email protected]>
show more ...
|
| #
1daf3609 |
| 27-Oct-2022 |
lukmccall <[email protected]> |
[dev-client] Fix rnscreen was not found in the UIManager & rebuild js
|
| #
9902b0d5 |
| 07-Oct-2022 |
Łukasz Kosmaty <[email protected]> |
[menu] Bump reanimated to `2.10.0` (#19428)
# Why
Closes ENG-6573.
The current version of reanimated doesn't work with RN 0.70. So, I've bumped it to `2.10.0`.
# How
- Used our vendored sc
[menu] Bump reanimated to `2.10.0` (#19428)
# Why
Closes ENG-6573.
The current version of reanimated doesn't work with RN 0.70. So, I've bumped it to `2.10.0`.
# How
- Used our vendored script to bump rea version.
# Test Plan
- bare-expo - hermes - rn 0.70.2 ✅
- bare-expo - jsc - rn 0.70.2 ✅
show more ...
|
| #
9d94b613 |
| 16-Sep-2022 |
lukmccall <[email protected]> |
[dev-client] Rebuild js
|
| #
4b49ecde |
| 11-Aug-2022 |
lukmccall <[email protected]> |
[dev-client] Rebuild js
|