History log of /expo/packages/@expo/config-plugins/src/plugins/mod-compiler.ts (Results 1 – 5 of 5)
Revision Date Author Comments
# 8a424beb 11-Aug-2023 James Ide <[email protected]>

[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)

Why
---
Prettier 3 is out. Add support for it with this linter config.

**Note for reviewer:** the first commit is the one with th

[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)

Why
---
Prettier 3 is out. Add support for it with this linter config.

**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).

How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).

Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.

Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...


# 42d6b312 30-Jun-2023 Cedric van Putten <[email protected]>

refactor(config-plugins): add existing native files ignore option (#23165)

# Why

Part of ENG-8481

This option helps to align the entitlements more to what users would
expect. With this, we ca

refactor(config-plugins): add existing native files ignore option (#23165)

# Why

Part of ENG-8481

This option helps to align the entitlements more to what users would
expect. With this, we can fetch the entitlements without the native
files, if the user has gitignored them.

> Note, this is an opt-in and does not change the default behavior.

# How

- Added opt-in option `ignoreExistingNativeFiles` to `evalModsAsync`

# Todo

In EAS CLI, we already know if the user has ignored certain paths. With
this feature, we can enable this option (with the proper warnings and
opt-out if they need to).

See: https://github.com/expo/eas-cli/pull/1906

# Test Plan

See added tests.

> **Note**
> I created the glob mocks by using the vscode launch config, and added
a breakpoint whenever an "unexpected" glob was used. By doing that
through vscode, I could quickly find all globs that were executed for
this test. See config below if you want to try it too.

<details><summary>vscode launch config</summary>

```json
{
"configurations": [
{
"name": "Test mods",
"request": "launch",
"runtimeArgs": ["jest", "--verbose", "withIosBaseMods"],
"runtimeExecutable": "yarn",
"cwd": "${workspaceFolder}/packages/@expo/config-plugins",
"skipFiles": ["<node_internals>/**"],
"type": "node",
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen"
}
]
}

```

</details>

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

show more ...


# edc75823 26-Apr-2023 Evan Bacon <[email protected]>

feat(config plugins): better support out of tree support (#22209)

# Why

Fix various validation issues when using `nexpo prebuild --platform
windows --template
https://github.com/microsoft/react

feat(config plugins): better support out of tree support (#22209)

# Why

Fix various validation issues when using `nexpo prebuild --platform
windows --template
https://github.com/microsoft/react-native-windows-samples/tree/main/samples/AppServiceDemo`

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...


# ed94abb0 21-Apr-2023 Cedric van Putten <[email protected]>

fix(config-plugins): default to `['dangerous']` sort order when using unknown platforms (#22224)

# Why

Follow-up of #22201

# How

When using arbitrary platforms, like `foobar`, the sort orde

fix(config-plugins): default to `['dangerous']` sort order when using unknown platforms (#22224)

# Why

Follow-up of #22201

# How

When using arbitrary platforms, like `foobar`, the sort order is not
defined. This results in errors like:


![image](https://user-images.githubusercontent.com/1203991/233685476-24afd065-77a5-4f39-9d09-a49c20dd7b4f.png)

Instead, this change adds a default sorting order of `['dangerous']`
when using arbitrary platforms.

# Test Plan

- Clone the example repository:
https://github.com/byCedric/custom-prebuild-example
- Create a tarball from template `$ cd ./template && npm pack`
- Run `$ expo prebuild --platform macos --template
../template/custom-prebuild-template-1.0.0.tgz`

This should not fail as the screenshot above.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

show more ...


# 082815dc 28-Jun-2022 Evan Bacon <[email protected]>

chore: migrate config, config-plugins, config-types, prebuild-config (#17958)