[config-plugins] mark target as signable/non-signable (#22454)# Why Part of a fix for https://github.com/expo/eas-cli/issues/1812. A user has a project with a framework target. EAS CLI expects
[config-plugins] mark target as signable/non-signable (#22454)# Why Part of a fix for https://github.com/expo/eas-cli/issues/1812. A user has a project with a framework target. EAS CLI expects him to set up credentials for that target. # How - `findApplicationTargetWithDependenciesAsync` is used in EAS CLI to find targets for which we need to set up credentials. - Framework targets are not signable. Mark them as non-signable. # Test Plan Added test case.
show more ...
feat(expo)!: use Expo CLI when building for development in Xcode (#21397)# Why - Related #21396 - Use `npx expo start --dev-client` instead of `npx react-native start` when building a project
feat(expo)!: use Expo CLI when building for development in Xcode (#21397)# Why - Related #21396 - Use `npx expo start --dev-client` instead of `npx react-native start` when building a project from Xcode. This ensures we use the correct version of Metro regardless of where the project is started. - It's unclear if building from Android Studio is supposed to trigger the bundler in development but I couldn't get it to do so, so this PR is iOS-only. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Copy over a bunch of the default scripts from `react-native/scripts` into the same locations in `expo/scripts` to make it easy to maintain this change and simple to migrate. I decided to omit the following as it appeared to be unused (sets RCT_METRO_PORT): ``` source "$THIS_DIR/.packager.env" ``` I also dropped: - Support for `$RCT_PACKAGER_LOGS_DIR`. - The `Process terminated. Press <enter> to close the window` log that is presented after closing the dev server. - Support for a custom React Native CLI config (this is not supported in Expo CLI). <!-- How did you build this feature or fix this bug and why? --> # Test Plan - TBD - Building for development from Xcode causes a terminal window running `npx expo start` will open instead of the community version. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <[email protected]> Co-authored-by: Kudo Chien <[email protected]>
chore(prebuild-config, config-plugins): rewrite tests to use latest template for fixtures (#21339)# Why - The previous tests were using static representations of the versioned fixtures. This me
chore(prebuild-config, config-plugins): rewrite tests to use latest template for fixtures (#21339)# Why - The previous tests were using static representations of the versioned fixtures. This meant that many tests were possibly outdated. - Now that the CLI is versioned, we can test against the latest templates to ensure our config plugins are always up to date. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Pull in fixtures from the local template. - Rewrite tests to work with new fixtures. <!-- How did you build this feature or fix this bug and why? --> # Test Plan - Tests should continue to pass. --------- Co-authored-by: Expo Bot <[email protected]>
[config-plugins] Apply react-native-maps AppDelegate plugin fix from @pchmn (#21333)# Why Fixes #21282 # How Copy over @pchmn's [suggested fix](https://github.com/expo/expo/issues/21282#i
[config-plugins] Apply react-native-maps AppDelegate plugin fix from @pchmn (#21333)# Why Fixes #21282 # How Copy over @pchmn's [suggested fix](https://github.com/expo/expo/issues/21282#issuecomment-1437421616) and update tests to ensure it works as expected. # Test Plan Run tests. Copy code to node_modules and test prebuild against [repro](https://github.com/pchmn/test-expo-sdk-48) # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
chore: migrate config, config-plugins, config-types, prebuild-config (#17958)