| #
b47ee281 |
| 13-Mar-2023 |
Evan Bacon <[email protected]> |
feat(expo)!: use Expo CLI when building for development in Xcode (#21397)
# Why
- Related #21396
- Use `npx expo start --dev-client` instead of `npx react-native start`
when building a project
feat(expo)!: use Expo CLI when building for development in Xcode (#21397)
# Why
- Related #21396
- Use `npx expo start --dev-client` instead of `npx react-native start`
when building a project from Xcode. This ensures we use the correct
version of Metro regardless of where the project is started.
- It's unclear if building from Android Studio is supposed to trigger
the bundler in development but I couldn't get it to do so, so this PR is
iOS-only.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Copy over a bunch of the default scripts from `react-native/scripts`
into the same locations in `expo/scripts` to make it easy to maintain
this change and simple to migrate.
I decided to omit the following as it appeared to be unused (sets
RCT_METRO_PORT):
```
source "$THIS_DIR/.packager.env"
```
I also dropped:
- Support for `$RCT_PACKAGER_LOGS_DIR`.
- The `Process terminated. Press <enter> to close the window` log that
is presented after closing the dev server.
- Support for a custom React Native CLI config (this is not supported in
Expo CLI).
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- TBD
- Building for development from Xcode causes a terminal window running
`npx expo start` will open instead of the community version.
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Kudo Chien <[email protected]>
show more ...
|
| #
ed3bd27b |
| 01-Mar-2023 |
Evan Bacon <[email protected]> |
chore(prebuild-config, config-plugins): rewrite tests to use latest template for fixtures (#21339)
# Why
- The previous tests were using static representations of the versioned
fixtures. This me
chore(prebuild-config, config-plugins): rewrite tests to use latest template for fixtures (#21339)
# Why
- The previous tests were using static representations of the versioned
fixtures. This meant that many tests were possibly outdated.
- Now that the CLI is versioned, we can test against the latest
templates to ensure our config plugins are always up to date.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Pull in fixtures from the local template.
- Rewrite tests to work with new fixtures.
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- Tests should continue to pass.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|