| #
ed3bd27b |
| 01-Mar-2023 |
Evan Bacon <[email protected]> |
chore(prebuild-config, config-plugins): rewrite tests to use latest template for fixtures (#21339)
# Why
- The previous tests were using static representations of the versioned
fixtures. This me
chore(prebuild-config, config-plugins): rewrite tests to use latest template for fixtures (#21339)
# Why
- The previous tests were using static representations of the versioned
fixtures. This meant that many tests were possibly outdated.
- Now that the CLI is versioned, we can test against the latest
templates to ensure our config plugins are always up to date.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Pull in fixtures from the local template.
- Rewrite tests to work with new fixtures.
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- Tests should continue to pass.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
857ad32f |
| 21-Feb-2023 |
Brent Vatne <[email protected]> |
[config-plugins] Apply react-native-maps AppDelegate plugin fix from @pchmn (#21333)
# Why
Fixes #21282
# How
Copy over @pchmn's [suggested
fix](https://github.com/expo/expo/issues/21282#i
[config-plugins] Apply react-native-maps AppDelegate plugin fix from @pchmn (#21333)
# Why
Fixes #21282
# How
Copy over @pchmn's [suggested
fix](https://github.com/expo/expo/issues/21282#issuecomment-1437421616)
and update tests to ensure it works as expected.
# Test Plan
Run tests. Copy code to node_modules and test prebuild against
[repro](https://github.com/pchmn/test-expo-sdk-48)
# Checklist
- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|