| #
3216ce43 |
| 24-Jun-2023 |
Kudo Chien <[email protected]> |
[config-plugins][prebuild-config] remove deprecated package in AndroidManifext.xml (#23056)
# Why
seeing a gradle build warning from a sdk49 project after prebuild:
```
> Task :app:processDeb
[config-plugins][prebuild-config] remove deprecated package in AndroidManifext.xml (#23056)
# Why
seeing a gradle build warning from a sdk49 project after prebuild:
```
> Task :app:processDebugMainManifest
package="com.sdk49" found in source AndroidManifest.xml: /Users/kudo/sdk49/android/app/src/main/AndroidManifest.xml.
Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.
Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace
This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.
/Users/kudo/sdk49/android/app/src/debug/AndroidManifest.xml:21:9-30:20 Warning:
provider#expo.modules.filesystem.FileSystemFileProvider@android:authorities was tagged at AndroidManifest.xml:21 to replace other declarations but no other declaration present
```
# How
we have the filled the application id to **build.gradle** `namespace` in the `withPackageGradle` plugin already. this pr just removes the deprecated `withPackageManifest` plugin.
# Test Plan
- ci passed
show more ...
|
| #
ed3bd27b |
| 01-Mar-2023 |
Evan Bacon <[email protected]> |
chore(prebuild-config, config-plugins): rewrite tests to use latest template for fixtures (#21339)
# Why
- The previous tests were using static representations of the versioned
fixtures. This me
chore(prebuild-config, config-plugins): rewrite tests to use latest template for fixtures (#21339)
# Why
- The previous tests were using static representations of the versioned
fixtures. This meant that many tests were possibly outdated.
- Now that the CLI is versioned, we can test against the latest
templates to ensure our config plugins are always up to date.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Pull in fixtures from the local template.
- Rewrite tests to work with new fixtures.
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- Tests should continue to pass.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
399179d8 |
| 19-Jan-2023 |
Kudo Chien <[email protected]> |
[config-plugins] add build.gradle namespace test (#20866)
# Why
follow up https://github.com/expo/expo/pull/20799#discussion_r1072511176 to add unit test for build.gradle namespace updates
# H
[config-plugins] add build.gradle namespace test (#20866)
# Why
follow up https://github.com/expo/expo/pull/20799#discussion_r1072511176 to add unit test for build.gradle namespace updates
# How
add namespace unit test
# Test Plan
ci passed
show more ...
|