| #
42d6b312 |
| 30-Jun-2023 |
Cedric van Putten <[email protected]> |
refactor(config-plugins): add existing native files ignore option (#23165)
# Why
Part of ENG-8481
This option helps to align the entitlements more to what users would
expect. With this, we ca
refactor(config-plugins): add existing native files ignore option (#23165)
# Why
Part of ENG-8481
This option helps to align the entitlements more to what users would
expect. With this, we can fetch the entitlements without the native
files, if the user has gitignored them.
> Note, this is an opt-in and does not change the default behavior.
# How
- Added opt-in option `ignoreExistingNativeFiles` to `evalModsAsync`
# Todo
In EAS CLI, we already know if the user has ignored certain paths. With
this feature, we can enable this option (with the proper warnings and
opt-out if they need to).
See: https://github.com/expo/eas-cli/pull/1906
# Test Plan
See added tests.
> **Note**
> I created the glob mocks by using the vscode launch config, and added
a breakpoint whenever an "unexpected" glob was used. By doing that
through vscode, I could quickly find all globs that were executed for
this test. See config below if you want to try it too.
<details><summary>vscode launch config</summary>
```json
{
"configurations": [
{
"name": "Test mods",
"request": "launch",
"runtimeArgs": ["jest", "--verbose", "withIosBaseMods"],
"runtimeExecutable": "yarn",
"cwd": "${workspaceFolder}/packages/@expo/config-plugins",
"skipFiles": ["<node_internals>/**"],
"type": "node",
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen"
}
]
}
```
</details>
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|