| #
4eadc459 |
| 25-Jul-2023 |
Frank Calise <[email protected]> |
fix(cli): Fix `Connecting` typo when opening React DevTools (#23672)
# Why
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests
fix(cli): Fix `Connecting` typo when opening React DevTools (#23672)
# Why
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
There is a typo in the waiting to connect static page when launching
React DevTools

# How
<!--
How did you build this feature or fix this bug and why?
-->
Fixed the typo
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
n/a
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|
| #
fd055557 |
| 06-Mar-2023 |
Kudo Chien <[email protected]> |
[cli][dev-menu][go] add react devtools (#21462)
# Why
close ENG-7468
close ENG-7469
# How
- [cli] add websocket proxy to forward react-devtools events.
- [cli] add static page for react-d
[cli][dev-menu][go] add react devtools (#21462)
# Why
close ENG-7468
close ENG-7469
# How
- [cli] add websocket proxy to forward react-devtools events.
- [cli] add static page for react-devtools frontend. since react-devtools only ships commonjs format, this pr tries to use jspm to support it on browsers.
- [dev-menu][go] listen `reconnectDevTools` metro websocket event and send `RCTDevMenuShown` to js for app to reconnect devtools websocket
# Test Plan
manual test only. please let me know if there's any proper points to add unit tests
show more ...
|