fix(cli): add additional isRouteFile check before generating Expo Router types (#23694)

# Why

Expo Router's is still generating some types for invalid files.

# How

Add additional guard insi

fix(cli): add additional isRouteFile check before generating Expo Router types (#23694)

# Why

Expo Router's is still generating some types for invalid files.

# How

Add additional guard inside the `addFilePath` method

show more ...

fix: Expo Router type generation for whitespace filenames (#23662)

# Why

Expo Router type generation normalised whitespace when we should
preserve it. This keeps the types inline with edge case

fix: Expo Router type generation for whitespace filenames (#23662)

# Why

Expo Router type generation normalised whitespace when we should
preserve it. This keeps the types inline with edge case usage.

`/(my group, my other group )/my page.tsx` is a valid filename.

It should be typed as

```
/(my group)/my page
/(my other group)/my page
/my page
```

# How

Removed the URL normalisation and changed the group regex's to preserve
white space. Group names are now trimmed

# Test Plan

Updated unit tests

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: evanbacon <[email protected]>

show more ...

fix: ensure folder exists (#23664)

# Why

If the user deletes the `.expo` or `.expo/types` folder while running
Expo Router type generation, the CLI process would crash. This ensures
the folder

fix: ensure folder exists (#23664)

# Why

If the user deletes the `.expo` or `.expo/types` folder while running
Expo Router type generation, the CLI process would crash. This ensures
the folder always exists before writing to it.

show more ...

fix(cli): Fix running typed routes without an app directory. (#23661)

# Why

- Using typed routes without an app directory doesn't work.

<!--
Please describe the motivation for this PR, and li

fix(cli): Fix running typed routes without an app directory. (#23661)

# Why

- Using typed routes without an app directory doesn't work.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix: Expo Router generating types for invalid route files (#23650)

New PR after revert of

https://github.com/expo/expo/pull/23421
https://github.com/expo/expo/pull/23609

---------

Co-auth

fix: Expo Router generating types for invalid route files (#23650)

New PR after revert of

https://github.com/expo/expo/pull/23421
https://github.com/expo/expo/pull/23609

---------

Co-authored-by: evanbacon <[email protected]>

show more ...

fix(cli): add deprecation notice to typed routes export and fix types (#23636)

# Why

- The Router type was missing new functions like `canGoBack`.
- The `router` object was not typed.
- The `us

fix(cli): add deprecation notice to typed routes export and fix types (#23636)

# Why

- The Router type was missing new functions like `canGoBack`.
- The `router` object was not typed.
- The `useSearchParams` deprecation warning was being removed.
- Added missing docs.
- Add missing `Redirect` component.
- Add missing doc block for the Link component.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix(cli): allow multiple `--platform` flags in `expo export` (#23621)

# Why

Part of ENG-9308

When creating an export for EAS updates, we need to be able to select
specific platforms with more

fix(cli): allow multiple `--platform` flags in `expo export` (#23621)

# Why

Part of ENG-9308

When creating an export for EAS updates, we need to be able to select
specific platforms with more flexibility than the current `all`. If
users have configured Metro web, we still need to be able to _only_
build for `android` and `ios` (the only 2 supported platforms for EAS
updates at the moment).

Running multiple separate instances of `expo export` doesn't seem like a
great alternative either. On every `expo export` run, the exported
folder is emptied. That would force EAS CLI to stitch this together,
which requires assumptions that we likely want to keep in `expo export`
only.

Unfortunately, we likely have to backport this to older SDK versions, or
we have to add a check in the EAS CLI to warn users about this
incompatibility.

# How

- Made `expo export --platform` a variadic flag
- Updated platform resolution to only return a combination of unique
`android`, `ios`, or `web` values

# Test Plan

See added tests, and to manually test it:

- `$ yarn create expo ./test-export -t tabs@49` (comes with Metro web
configured)
- `$ cd ./test-export`
- `$ yarn expo export -p android -p=ios`
→ _Should export `android` and `ios`_
- `$ yarn expo export -p android -p all`
→ _Should export `android`, `ios`, and `web`_
- `$ yarn expo export -p web -p ios`
→ _Should export `ios` and `web`_

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

show more ...

Revert "fix: Expo Router generating types for invalid route files" (#23609)

Reverts expo/expo#23421

fix: Expo Router generating types for invalid route files (#23421)

# Why

https://github.com/expo/router/issues/736

Additionally, I noticed that `+html` files were not handled correctly.

# H

fix: Expo Router generating types for invalid route files (#23421)

# Why

https://github.com/expo/router/issues/736

Additionally, I noticed that `+html` files were not handled correctly.

# How

We return early inside the Metro watcher if the file is not a route file

# Test Plan

Reproduction steps in linked issue

# Checklist

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

show more ...

Rework ExpoRouter HrefObject (#23507)

# Why

Reworks how `Href` and `HrefObject` works to fix multiple issues with
Expo Router types

Fixes:
- Issues where HrefObject required `as const` typing unde

Rework ExpoRouter HrefObject (#23507)

# Why

Reworks how `Href` and `HrefObject` works to fix multiple issues with
Expo Router types

Fixes:
- Issues where HrefObject required `as const` typing under some
conditions (https://github.com/expo/router/issues/769)
- HrefObject now auto-completes all dynamic routes (previously only did
static routes)
- HrefObject `params` is no longer strict and can accept extra arguments
- `useLocalSearchParams`/`useSearchParams`/`useGlobalSearchParams` now
allow for arbitrary generics
- If a route is passed as the genertic for
`useLocalSearchParams`/`useSearchParams`/`useGlobalSearchParams` will
return an object with keys typed for the known parameters, but still
allow for arbitrary search params
- Top level catch all routes (e.g `/[...missing]`) no longer cause
typing to fail
- e.g `<Link href="/(test)/[value]" />` will now correctly error that it
should be a HrefObject and not a Href
- When setting a `param` it can be a `string` or `number` - however it
will always be a string when returned from
`useLocalSearchParams`/`useSearchParams`/`useGlobalSearchParams`

PR superseeds https://github.com/expo/expo/pull/23422

# Test Plan

Type tests were updated but some things need to be manually tested (like
autocomplete)

The project generated by `npx create-expo-app@latest --template tabs@49`
can be used to easily test.

show more ...

Fix port in use message for unidentified process (#22814)

# Why

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

T

Fix port in use message for unidentified process (#22814)

# Why

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

The current message when the port is in use is confusing when the
running process cannot be identified; it just says "Port <#> is." This
happens for example on Windows/PowerShell where the running process
detector does not work. Closes #22774.

# How

<!--
How did you build this feature or fix this bug and why?
-->
Added "being used by another process" to the message in the `else`
block.

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
Had trouble writing a unit test due to the dynamic imports in the
function, which don't seem to play well with Jest. However, I was able
to test it locally:



# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix(cli): Set `preferNativePlatform` to `false` for all web requests. (#23527)

# Why

- Currently we fallback on the default or user-defined resolver if the
expo resolver fails. Now we'll skip th

fix(cli): Set `preferNativePlatform` to `false` for all web requests. (#23527)

# Why

- Currently we fallback on the default or user-defined resolver if the
expo resolver fails. Now we'll skip the default if the expo resolver
asserts.
- If the user-defined resolver is called, it will now have
`preferNativePlatform` disabled. This ensures we never attempt to
resolve a web file with `.native` extensions.

# Test Plan

- Unit tests

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

[cli] Add styling to SSO auth redirect completion page (#23477)

[cli] Use node server default port selection for SSO login server (#23505)

fix(cli): Added improved error message for static metro when a package is missing (#23499)

Co-authored-by: Expo Bot <[email protected]>

Update react-native to 0.72.2 (#23476)

# Why

Updating RN to 0.72.2

# How

- Updated the submodule
- Updated versions in dependencies (including templates)
- Updated Podfile locks

# Test

Update react-native to 0.72.2 (#23476)

# Why

Updating RN to 0.72.2

# How

- Updated the submodule
- Updated versions in dependencies (including templates)
- Updated Podfile locks

# Test Plan

Checked if bare-expo builds and quickly ran through some tests and
examples – all seem good.

---------

Co-authored-by: Tomasz Sapeta <[email protected]>
Co-authored-by: Brent Vatne <[email protected]>

show more ...

[cli] Add support for SSO user type and log in with SSO (#22945)

fix(cli): generate correct route types on Windows (#23386)

# Why

- CLI was generating wrong route types in windows
- Fixes [issue in
expo/router](https://github.com/expo/router/issues/719)
- W

fix(cli): generate correct route types on Windows (#23386)

# Why

- CLI was generating wrong route types in windows
- Fixes [issue in
expo/router](https://github.com/expo/router/issues/719)
- Watcher not adding/deleting route type in some cases, e.g. route name
with space

# How

<!--
How did you build this feature or fix this bug and why?
-->

- Normalized appRoot to use POSIX separator in windows, allowing to
remove appRoot from path
- Normalized file path from watcher to match route generated

# Test Plan
Needs to be tested on Windows:

1. Build the cli: ```yarn build```
2. Create an alias to the cli: ```alias
nexpo="/path/to/expo/packages/@expo/cli/build/bin/cli"```
3. Run expo on new project and check generated types on
```.expo\types\router.d.ts```

> Not sure it's the best way to test this, First PR to expo open to
feedback

# Checklist

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Mark Lawlor <[email protected]>

show more ...

[cli][inspector-proxy] fix devtools websocket connection on windows (#23367)

# Why

fixes #23332
close ENG-9233

# How

windows does not support `0.0.0.0` or `[::]` as loopback address. in th

[cli][inspector-proxy] fix devtools websocket connection on windows (#23367)

# Why

fixes #23332
close ENG-9233

# How

windows does not support `0.0.0.0` or `[::]` as loopback address. in these case, we should fallback to `localhost` or `[::1]`.

# Test Plan

test devtools on windows

show more ...

refactor(cli): drop extraneous source fetch workaround for `metro@<0.75.1` (#23259)

# Why

This was required for SDK 48, but with 49 we are using a newer Metro
that has this workaround built-in.

refactor(cli): drop extraneous source fetch workaround for `metro@<0.75.1` (#23259)

# Why

This was required for SDK 48, but with 49 we are using a newer Metro
that has this workaround built-in. ([see
commit](https://github.com/facebook/metro/commit/6690b393cc1812af02f8eb20853504f0a6188a83))

# How

- Dropped the `DebuggerScriptSource` handler
- Updated tests

# Test Plan

- Try debugging the code with the vscode extension

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix(cli, dev-server): add `SYSTEMROOT` for `open` when opening browsers on Windows (#23287)

# Why

Fixes #23252

# How

- `open` has a bug on Windows, where it [uses
`process.env.SYSTEMROOT`]

fix(cli, dev-server): add `SYSTEMROOT` for `open` when opening browsers on Windows (#23287)

# Why

Fixes #23252

# How

- `open` has a bug on Windows, where it [uses
`process.env.SYSTEMROOT`](https://github.com/sindresorhus/open/blob/main/index.js#L173)
instead of
[`process.env.SystemRoot`](https://en.wikipedia.org/wiki/Environment_variable#:~:text=The%20%25SystemRoot%25%20variable%20is%20a,including%20the%20drive%20and%20path.)
- This causes the executed command to run with `undefined\\...`
- There has been no fix yet, and due to `open` being fully ESM now, we
probably can't upgrade too

> See various issues
[#300](https://github.com/sindresorhus/open/issues/300),
[#292](https://github.com/sindresorhus/open/issues/292),
[#270](https://github.com/sindresorhus/open/issues/270), or
[#205](https://github.com/sindresorhus/open/issues/205)

This basically sets the missing `SYSTEMROOT` when trying to open a
browser on Windows. It's fixed in both `@expo/cli` as well as
`@expo/dev-server` (to open the Chrome DevTools).

# Test Plan

This has to be tested on Windows.

- `$ yarn create expo ./test-browser -t tabs@beta`
- `$ cd ./test-browser`
- `$ yarn start`
- Try pressing the following keys:
- `j` -> to open the Chrome DevTools, after connecting a device. Should
work as expected.
- `w` -> to open the browser with Metro web. Should work as expected.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

refactor(cli): disable inspector proxy inline source maps for vscode only (#23258)

# Why

With SDK 49, I noticed a multi-second delay in breakpoints getting
bound. This is likely due to [Metro in

refactor(cli): disable inspector proxy inline source maps for vscode only (#23258)

# Why

With SDK 49, I noticed a multi-second delay in breakpoints getting
bound. This is likely due to [Metro inlining sourcemaps as base64
strings](https://github.com/facebook/metro/commit/6690b393cc1812af02f8eb20853504f0a6188a83)
for tools like the chrome debugger. In practice, it generates a huge
base64 string that causes this delay when decoding in vscode.

# How

- Added `debuggerType` to connect to the inspector proxy as a certain
debugger type (e.g. `vscode` or `generic` <- default)
- Added override for `Debugger.scriptParsed` to disable inline
sourcemaps for vscode only.

# Test Plan

~~TBD, since this also requires an update in vscode-expo (add the
`type=vscode` as query param when connecting to the inspector proxy).~~

This is now included in `[email protected]`

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat: add generated types for Expo Router useSegment (#22629)

# Why

* Add type generation for Expo Router's `useSegment`
* Adds code comments and renames a few internal types.
* Refactored the

feat: add generated types for Expo Router useSegment (#22629)

# Why

* Add type generation for Expo Router's `useSegment`
* Adds code comments and renames a few internal types.
* Refactored the `useSearchParams` types
* Add default to `Href<T>`

Note that this is not a breaking change as the generated types are only
present inside the users' cache and should not be committed. Next time
the user starts the dev server they will get the new generated types.

## Questions

@EvanBacon Given the route `/(app)/note/[note]/` does useSegments return
the group?

## `useSearchParams`

This hook was a bit strange as its signature changed when you enabled
types routes.

Without: `useSearchParams<T extends Record<string, string>(): T`
With: `useSearchParams<T extends Route>(): SearchParams<T>`

This PR updates the TypedRoutes version to accept either a `Route` or a
`Record`. This `Record` is still typed checked and it must satisfy a
possible SearchParams object.

For example

```tsx
// This will only work if you have a [test] route somewhere in your app
const { test } = useSearchParams<{ test: string }>()
```

I quite like this as it allows you to cherry-pick the param that you
need.

Note that this obviously doesn't do a runtime check for it maybe be
correct, but its a start.

## Href<T>

Href<T> has a default value and by default now represents all possible
Hrefs. You can use the generic to reduce it down.

---------

Co-authored-by: evanbacon <[email protected]>

show more ...

Fix tsconfig paths and other SDK 49 Metro features. (#23276)

# Why

We install an additional metro config modification **after** loading the
metro config, this additional function adds dynamic fu

Fix tsconfig paths and other SDK 49 Metro features. (#23276)

# Why

We install an additional metro config modification **after** loading the
metro config, this additional function adds dynamic functionality like
listening for tsconfig changes. This wasn't being added to the
expo-updates metro config which resulted in tsconfig paths not working.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

- Ran locally with `npx expo run:ios --configuration Release`

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix(cli): only warn users when using non-recommended versions of important dependencies (#23232)

# Why

<img width="937" alt="image"
src="https://github.com/expo/expo/assets/1203991/0352e5db-dc19

fix(cli): only warn users when using non-recommended versions of important dependencies (#23232)

# Why

<img width="937" alt="image"
src="https://github.com/expo/expo/assets/1203991/0352e5db-dc19-46d4-a348-cb84b3b624c2">

This warning was over-eagerly displayed to users during the SDK 49 beta.
This change fixes that behavior to only warn when the used versions and
recommended versions do not intersect.

# How

- Turned out it was `finally` always returning `false`, replaced with
`catch`

# Test Plan

- `$ yarn create expo ./test-prebuild-version-warning -t tabs@beta`
- `$ cd ./test-prebuild-version-warning`
- `$ yarn expo prebuild`
- Should not warn in its current state

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...