| #
51740f69 |
| 30-Aug-2023 |
Evan Bacon <[email protected]> |
feat(cli): validate android package name (#24194)
# Why
- resolve https://github.com/expo/expo/issues/22428
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issue
feat(cli): validate android package name (#24194)
# Why
- resolve https://github.com/expo/expo/issues/22428
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Added a list of reserved java keywords from wikipedia.
- Tested each category against a gradle build.
- Added additional info to the validation prompt so users have a hint as
to what is incorrect.
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- Added unit tests, ran locally
<img width="491" alt="Screenshot 2023-08-30 at 3 23 02 PM"
src="https://github.com/expo/expo/assets/9664363/e5d42702-3818-48f4-ad23-f9f6e821223f">
show more ...
|
| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
8d307f52 |
| 23-Mar-2022 |
Evan Bacon <[email protected]> |
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* f
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* fix e2e tests
* lint before build
* use mock version
show more ...
|