chore(router): pull in stable changes from #23795 (#23890)

# Why

- #23795 is blocked on some difficult issues. This PR pulls in the safe
changes from that PR so they don't get lost.

---------

chore(router): pull in stable changes from #23795 (#23890)

# Why

- #23795 is blocked on some difficult issues. This PR pulls in the safe
changes from that PR so they don't get lost.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli, metro): add inverse import error stack (#23551)

# Why

Many users encounter issues where a library reaches into react-native
internals on web and the error isn't helpful. This PR create

feat(cli, metro): add inverse import error stack (#23551)

# Why

Many users encounter issues where a library reaches into react-native
internals on web and the error isn't helpful. This PR creates a graph of
resolutions to print the full stack of imports that lead to an invalid
resolution. This helps show which application code can be modified to
fix a bug.

Unclear if we want to add an experimental version of this in Expo CLI or
in Metro. For now, I'm opening the draft so some power-users can pull
the branch and use it to debug their projects.

I'll be splitting parts of this PR out and merging them into upstream
(expo/expo) in the meantime.

### Before

<img width="1140" alt="Screenshot 2023-07-15 at 4 24 21 PM"
src="https://github.com/expo/expo/assets/9664363/d75291e8-7ba0-45ae-b236-e688be8eee16">


### After

<img width="1148" alt="Screenshot 2023-07-15 at 4 17 21 PM"
src="https://github.com/expo/expo/assets/9664363/4da8cbb7-c55e-4697-a09b-fb2e4752d5ec">

## Usage in dev

- Pull this branch
- [Setup local CLI in
dev](https://github.com/expo/expo/blob/main/packages/%40expo/cli/README.md#contributing).
- Start your project with local CLI in dev.

# Test Plan

- TBD

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

[cli] Use node server default port selection for SSO login server (#23505)

[cli] Add support for SSO user type and log in with SSO (#22945)

feat(cli): improve offline support (#22961)

# Why

Offline support is sometimes needed in parts of other commands besides
`start`, this PR introduces an `EXPO_OFFLINE` env var which can be
gener

feat(cli): improve offline support (#22961)

# Why

Offline support is sometimes needed in parts of other commands besides
`start`, this PR introduces an `EXPO_OFFLINE` env var which can be
generally used to force offline support.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

- `EXPO_OFFLINE`
- Show a better error message when your computer is connected to wifi
but there's no signal.
- Assert in `npx expo login` and `npx expo register` when `EXPO_OFFLINE`
is set.
- Fail better when validating versions offline.

In the case of running `npx expo` without wifi:

## Before

```
june-16 �� nexpo
Starting project at /Users/evanbacon/Documents/GitHub/lab/june-16
Starting Metro Bundler
Unable to reach Expo servers. Falling back to using the cached dependency map (bundledNativeModules.json) from the package "expo" installed in your project.
FetchError: request to https://api.expo.dev/v2/versions/latest failed, reason: getaddrinfo ENOTFOUND api.expo.dev
FetchError: request to https://api.expo.dev/v2/versions/latest failed, reason: getaddrinfo ENOTFOUND api.expo.dev
at ClientRequest.<anonymous> (/Users/evanbacon/Documents/GitHub/expo/node_modules/node-fetch/lib/index.js:1491:11)
at ClientRequest.emit (node:events:513:28)
at TLSSocket.socketErrorListener (node:_http_client:502:9)
at TLSSocket.emit (node:events:513:28)
at emitErrorNT (node:internal/streams/destroy:151:8)
at emitErrorCloseNT (node:internal/streams/destroy:116:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
```

## After

```
june-16 �� nexpo
Starting project at /Users/evanbacon/Documents/GitHub/lab/june-16
Starting Metro Bundler
Unable to reach Expo servers. Falling back to using the cached dependency map (bundledNativeModules.json) from the package "expo" installed in your project.
CommandError: Network connection is unreliable. Try again with the environment variable `EXPO_OFFLINE=1` to skip network requests.
```


<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

- Updated tests and added new tests for things like the register
command.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

chore(cli, docs): update typed routes (#22848)

# Why

I keep getting DMs about this feature being confusing so I'm doing a
pass to try and bring it to parity with the rest of our offering.

<!-

chore(cli, docs): update typed routes (#22848)

# Why

I keep getting DMs about this feature being confusing so I'm doing a
pass to try and bring it to parity with the rest of our offering.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

- Update the experimental docs to not be a general "TypeScript" guide
but rather, be focused on the "Typed Routes" feature.
- Use the new `experiments.typedRoutes` flag and not an environment
variable. https://github.com/expo/universe/pull/12590
- Drop flag misinfo in the Expo CLI docs "This includes support for the
network inspector."
- Add a slightly more e2e test for the side-effects.
- Document how to actually turn the feature on.

---------

Co-authored-by: Aman Mittal <[email protected]>
Co-authored-by: Expo Bot <[email protected]>

show more ...

refactor(cli): enable inspector proxy with network support by default (#22936)

# Why

Flipping this switch to be opt-out for SDK 49.

# How

- Renamed `EXPO_USE_CUSTOM_INSPECTOR_PROXY=true` to

refactor(cli): enable inspector proxy with network support by default (#22936)

# Why

Flipping this switch to be opt-out for SDK 49.

# How

- Renamed `EXPO_USE_CUSTOM_INSPECTOR_PROXY=true` to
`EXPO_NO_INSPECTOR_PROXY=false`

> This change made more sense as you would have to set
`EXPO_USE_CUSTOM_INSPECTOR_PROXY=false` to revert back to the original
(Metro) inspector proxy.

# Test Plan

- `$ EXPO_DEBUG=true expo start` -> should mention `Expo inspector proxy
enabled` in the debug logs.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli): Add support for Metro lazy bundling (#22724)

# Why

- Companion to https://github.com/expo/router/pull/622

<!--
Please describe the motivation for this PR, and link to relevant GitH

feat(cli): Add support for Metro lazy bundling (#22724)

# Why

- Companion to https://github.com/expo/router/pull/622

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

- Add `lazy` query parameter for Metro requests and `EXPO_NO_METRO_LAZY`
to disable the feature. Abiding by
https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md#__loadbundleasync-in-metro

# Test Plan

- Works when used with https://github.com/expo/router/pull/622

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(metro-config, cli): CSS serializer (#22325)

# Why

In order to support static CSS in development mode, we need to update
the metro serializer to support returning the JS and CSS assets. We n

feat(metro-config, cli): CSS serializer (#22325)

# Why

In order to support static CSS in development mode, we need to update
the metro serializer to support returning the JS and CSS assets. We now
inline the CSS in the HTML before sending to the client, this allows for
testing how the website works with JS disabled. We use the same style
tag id to continue to support HMR for styles during subsequent updates.

This change also refactors how exports work to serialize JS and CSS at
the same time (i.e. after the native transformations).

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat: typed route generation for expo router (#21651)

> Draft PR - just seeking feedback on the implementation.

# Why

WIP implementation of route generation for Expo Router.

# How

## Typ

feat: typed route generation for expo router (#21651)

> Draft PR - just seeking feedback on the implementation.

# Why

WIP implementation of route generation for Expo Router.

# How

## Typescript bootstrapping

This is expands the Typescript bootstrapping to also accommodate for
long-lived typescript watchers.
- Changes `waitForMetroToObserveTypeScriptFile` to
`metroWatchTypeScriptFiles`
- Processes are now responsible to disabling their watcher
- tsconfig can optionally be watched

## Type generation

`typedRouteGenerator` is invokes after the CLI has bootstrapped
TypeScript.
- Generates types only for absolute paths
- Supports static and dynamic routes
- Supports URL normalisation (TODO: Need unit tests for these!)
- Supports dynamic route parameter typing

# Test Plan

`EXPO_ROUTER_TYPED_ROUTES=true nexpo start`

// Todo

# Checklist

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

---------

Co-authored-by: Evan Bacon <[email protected]>

show more ...

chore(cli): switch `EXPO_USE_PATH_ALIASES` to `expo.experiments.tsconfigPaths`. (#21897)

# Why

- It's a bit harder to set env vars and users will want this either
always on or always off.
- Exp

chore(cli): switch `EXPO_USE_PATH_ALIASES` to `expo.experiments.tsconfigPaths`. (#21897)

# Why

- It's a bit harder to set env vars and users will want this either
always on or always off.
- Expo Config makes it easier to deprecate values on a per-version
basis. https://github.com/expo/universe/pull/11872
- Comment out references to the path aliases feature until we're closer
to launch. Users are getting confused when they see the feature
documented.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli): add basic static rendering for router projects (#21572)

# Why

- Implement an experimental static rendering system for Metro websites
using Expo Router.
- Behavior is undocumented and

feat(cli): add basic static rendering for router projects (#21572)

# Why

- Implement an experimental static rendering system for Metro websites
using Expo Router.
- Behavior is undocumented and highly experimental.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

- Add support to `start` and `export` which pre-renders static web pages
to HTML to improve SEO support on web.
- The system implements [React Navigation's
SSR](https://reactnavigation.org/docs/server-rendering) support.
- Head elements can be used with `import { Head } from
'expo-router/head'`.
- The root HTML is not exposed to the user.
- There are no data fetching mechanisms.
- There's no ability to provide a 404 page or other server features.


<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

- e2e test for exporting a router project statically.
- `EXPO_USE_STATIC=1 yarn expo` -> websites are pre-rendered before
being served.
- `EXPO_USE_STATIC=1 yarn expo export -p web` -> static routes are
rendered to static HTML files by the same name (dynamic routes are not
supported).


<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feature(cli): add custom inspector proxy based on `metro-inspector-proxy` (#21449)

# Why

Fixes ENG-7467

Related #21265

This is an initial draft to extend the CDP functionality of
`metro-in

feature(cli): add custom inspector proxy based on `metro-inspector-proxy` (#21449)

# Why

Fixes ENG-7467

Related #21265

This is an initial draft to extend the CDP functionality of
`metro-inspector-proxy`.

# How

The implementation is slightly wonky around the `ExpoInspectorDevice`.
We want to reuse as much as possible from `metro-inspector-proxy`, but
we need to add stateful data per device.

In order to achieve that, we generate a new class type, based on the
user's installed `metro-inspector-proxy`. This makes everything less
readable but should include future updates in these classes.

As for the `ExpoInspectorProxy`, to avoid having to do the same thing,
we just wrap the whole inspector class and reuse what we can. The device
map is "linked" within the original inspector proxy instance, making the
data available to all methods that need it.

# Test Plan

Enable this feature with `EXPO_USE_CUSTOM_INSPECTOR_PROXY=1`

- [x] See tests for the actual CDP events we handle.
- [ ] See tests on the "bootstrapping code" to create the inspector and
devices.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

---------

Co-authored-by: Evan Bacon <[email protected]>

show more ...

feat(cli): add support for path aliases and absolute imports (#21262)

# Why

- In Expo Router, you have to import outside of the `app` directory
which does not spark joy at scale (e.g. `../../../

feat(cli): add support for path aliases and absolute imports (#21262)

# Why

- In Expo Router, you have to import outside of the `app` directory
which does not spark joy at scale (e.g. `../../../../../../`).
- This is pretty standard functionality in web development, feels odd
not having it in our "Metro for web" system.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

- Add support for `compilerOptions.baseUrl` from `tsconfig.json` and
`jsconfig.json` files to Metro. This enables absolute imports.
- Add support for `compilerOptions.paths` aliases from `tsconfig.json`
and `jsconfig.json` files to Metro. This enables path aliases. Tried to
keep the implementation as close to TypeScript as possible to reduce
maintenance.
- Absolute imports utilize built-in Metro behavior making it more
reliable. We basically just register the baseUrl as a location to search
for node modules.
- Couldn't decide where to document the feature so I put it in multiple
places.
- We might need to update expo jest to have similar functionality in the
future (it might already support these fields, didn't check).


<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

- Added some unit tests for path aliases (non-exhaustive).
- For correctness, you can use this feature in vscode and all
autocomplete suggestions should work as the bundling now matches the
built-in resolution.

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli, metro-config): implement new unstable_serverRoot feature (#21088)

# Why

- Metro web doesn't work with monorepos because requests that look up
past the project root like `/../../` will

feat(cli, metro-config): implement new unstable_serverRoot feature (#21088)

# Why

- Metro web doesn't work with monorepos because requests that look up
past the project root like `/../../` will be collapsed to `/` which
breaks a number of features.
- Metro added `unstable_serverRoot` which we now automatically set to
the workspace root when `EXPO_USE_METRO_WORKSPACE_ROOT=1` is enabled. If
this works well at scale, we'll enable the feature by default.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix(cli): prevent using default port 80 with tunnels (#18475)

feat(cli): add proxy support (#19592)

* feat: add proxy support

* Update expo-cli.mdx

* Update wrapFetchWithProxy.ts

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <34

feat(cli): add proxy support (#19592)

* feat: add proxy support

* Update expo-cli.mdx

* Update wrapFetchWithProxy.ts

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

* Create wrapFetchWithProxy.test.ts

* Update env.ts

* Update docs/pages/workflow/expo-cli.mdx

Co-authored-by: Aman Mittal <[email protected]>

Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>

show more ...

feat: add EXPO_TUNNEL_SUBDOMAIN to control the ngrok subdomain config (#19507)

* feat: add EXPO_TUNNEL_SUBDOMAIN to control the ngrok subdomain configuration

* Update packages/@expo/cli/CHANGELOG

feat: add EXPO_TUNNEL_SUBDOMAIN to control the ngrok subdomain config (#19507)

* feat: add EXPO_TUNNEL_SUBDOMAIN to control the ngrok subdomain configuration

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

* Update AsyncNgrok-test.ts

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli): Make Expo Metro config for web resolve projects using same `package.json` main fields as Expo Webpack (#19529)

* fix: ensure web is setup every time

* fix(cli): use correct main fields

feat(cli): Make Expo Metro config for web resolve projects using same `package.json` main fields as Expo Webpack (#19529)

* fix: ensure web is setup every time

* fix(cli): use correct main fields for Metro web

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

* Update docs/pages/workflow/expo-cli.mdx

Co-authored-by: Aman Mittal <[email protected]>

* Update docs/pages/workflow/expo-cli.mdx

Co-authored-by: Aman Mittal <[email protected]>

Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>

show more ...

[cli] ensure that development build is installed when opening interstitial page (#18836)

Co-authored-by: evanbacon <[email protected]>

feat(cli): add EXPO_NO_DEFAULT_PORT to skip proxy port (#18464)

feat: add support for $EXPO_EDITOR (#18285)

* feat: add support for $EXPO_EDITOR

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

feat: add support for $EXPO_EDITOR (#18285)

* feat: add support for $EXPO_EDITOR

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli): add web support to metro (#17927)

* feat: add web support for metro

* undo patch

* Update index.js

* Update MetroBundlerDevServer.ts

* Add second bundler dev server

* Add d

feat(cli): add web support to metro (#17927)

* feat: add web support for metro

* undo patch

* Update index.js

* Update MetroBundlerDevServer.ts

* Add second bundler dev server

* Add dev loading view to web

* Put feature behind EXPO_USE_METRO_WEB flag

* Move custom config into CLI

* Add support for assets across platforms

* reduce

* Added upstream web support

* Update webTemplate.ts

* Update CHANGELOG.md

* Update instantiateMetro.ts

* Update instantiateMetro.ts

* Update index.js

* Added bundle splitting support

* Update startAsync.ts

* Fixed default settings

* Add ability to copy from public folder

* wip: redirect unmatched routes to `/` on web

* fix fallback api

* Update exportApp.ts

* Update instantiateMetro.ts

* Update exportApp.ts

* clean up handler

* fixup

* clean up

* add web to export test

* Update start-test.ts

* added static serving for web

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

* Update yarn.lock

lint fix

fix tests

* Update export-test.ts

* added template tests

* Create HistoryFallbackMiddleware-test.ts

* test ManifestMiddleware

* Create ServeStaticMiddleware-test.ts

* refactor multiplatform

* Update ManifestMiddleware-test.ts

* Update withMetroMultiPlatform.ts

* Update for latest metro

* Update packages/@expo/cli/src/export/resolveOptions.ts

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli): add `export` command (#17034)

* feat(cli): add export command

* Update CHANGELOG.md

* update tests

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+

feat(cli): add `export` command (#17034)

* feat(cli): add export command

* Update CHANGELOG.md

* update tests

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

* reduce interface

* refactor

refactor

refactor

* refactor

* remove all merging code

* drop aliases

* Added asset saving tests

* refactor export code up

* Update env.ts

* Drop unused

* added e2e tests

* Dropped --quiet flag

* PR Feedback

* fix tests

* fix export tests

* Update export-test.ts

Co-authored-by: Expo Bot <[email protected]>

show more ...

chore(cli): lazy load all env vars (#17082)

* chore(cli): lazy load all env vars

lazily loading all environment variables makes it easier to test different cases since you can change the value of

chore(cli): lazy load all env vars (#17082)

* chore(cli): lazy load all env vars

lazily loading all environment variables makes it easier to test different cases since you can change the value of things like `CI` between tests.

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

Co-authored-by: Expo Bot <[email protected]>

show more ...