| #
0b50ef93 |
| 19-Jan-2023 |
Cedric van Putten <[email protected]> |
fix(cli): use known Expo schemes to use as dev client urls (#20888)
# Why
Fixes #20887
# How
Instead of always picking the longest scheme, this adds "search for
known expo schemes, startin
fix(cli): use known Expo schemes to use as dev client urls (#20888)
# Why
Fixes #20887
# How
Instead of always picking the longest scheme, this adds "search for
known expo schemes, starting with `exp+`". If that's found, it's still
sorting on longest. And if it's not found, it's doing what it's doing
now.
# Test Plan
(see added tests)
- Add a custom scheme to the native files that includes a very long
scheme
- Start the project (should be a bad scheme)
- Add a shorter `exp+...` scheme
- Start the project (should be that `expo+...` scheme)
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|