[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)

Why
---
Prettier 3 is out. Add support for it with this linter config.

**Note for reviewer:** the first commit is the one with th

[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)

Why
---
Prettier 3 is out. Add support for it with this linter config.

**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).

How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).

Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.

Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(expo)!: drop logging endpoint (#18596)

# Why

- In the new versioned CLI we don't support the logging endpoint,
instead favoring the logging WebSocket setup by `metro-runtime`.
- Dropping s

feat(expo)!: drop logging endpoint (#18596)

# Why

- In the new versioned CLI we don't support the logging endpoint,
instead favoring the logging WebSocket setup by `metro-runtime`.
- Dropping support for `logUrl` will break logging in the legacy
`expo-cli start` command, no logs will show up.
- Drop `Logs` module: `import { Logs } from 'expo';`.
- Drop stack trace filter that removes `react-native-logging.fx` since
we no longer need it.
- Also removes the "temporary workaround"s from 2018 that filter out
warnings from the lottie package.
- Drop direct dependency on `invariant`, `pretty-format`, `fbemitter`

> This doesn't add breaking changes to the local Expo CLI, only the
deprecated global CLI.

# Test Plan

- Copied the JS expo files into a new project and websockets continued
to send logs.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

Always apply custom Metro resolver in Expo CLI. (#23784)

# Why

- mjs resolver must always be applied.
- There are probably other side effects but everything is getting more
test coverage this w

Always apply custom Metro resolver in Expo CLI. (#23784)

# Why

- mjs resolver must always be applied.
- There are probably other side effects but everything is getting more
test coverage this way.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(metro): support mjs extensions in Expo (#23528)

# Why

- A number of libraries are using this file, unclear how we should use
it though.
- This PR doesn't enable `unstable_packageExports` b

feat(metro): support mjs extensions in Expo (#23528)

# Why

- A number of libraries are using this file, unclear how we should use
it though.
- This PR doesn't enable `unstable_packageExports` but it does pull in
the default `unstable_conditionNames` from the recommended react-native
metro config.
- mjs is resolved after js/ts files when bundling for Node.js
environments.

# Test Plan

- Expo Camera works in Expo Router on web.
- Added tests for continuous functionality.

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli, metro): add inverse import error stack (#23551)

# Why

Many users encounter issues where a library reaches into react-native
internals on web and the error isn't helpful. This PR create

feat(cli, metro): add inverse import error stack (#23551)

# Why

Many users encounter issues where a library reaches into react-native
internals on web and the error isn't helpful. This PR creates a graph of
resolutions to print the full stack of imports that lead to an invalid
resolution. This helps show which application code can be modified to
fix a bug.

Unclear if we want to add an experimental version of this in Expo CLI or
in Metro. For now, I'm opening the draft so some power-users can pull
the branch and use it to debug their projects.

I'll be splitting parts of this PR out and merging them into upstream
(expo/expo) in the meantime.

### Before

<img width="1140" alt="Screenshot 2023-07-15 at 4 24 21 PM"
src="https://github.com/expo/expo/assets/9664363/d75291e8-7ba0-45ae-b236-e688be8eee16">


### After

<img width="1148" alt="Screenshot 2023-07-15 at 4 17 21 PM"
src="https://github.com/expo/expo/assets/9664363/4da8cbb7-c55e-4697-a09b-fb2e4752d5ec">

## Usage in dev

- Pull this branch
- [Setup local CLI in
dev](https://github.com/expo/expo/blob/main/packages/%40expo/cli/README.md#contributing).
- Start your project with local CLI in dev.

# Test Plan

- TBD

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

Fix Metro externals test. (#23741)

# Why

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did y

Fix Metro externals test. (#23741)

# Why

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

feat(cli): dynamically enable lazy bundling (#23675)

# Why

If a package is using `import()` syntax, it needs to have
`@expo/metro-runtime` installed and imported somewhere. This issue
partially

feat(cli): dynamically enable lazy bundling (#23675)

# Why

If a package is using `import()` syntax, it needs to have
`@expo/metro-runtime` installed and imported somewhere. This issue
partially goes away in RN 73, and is not a problem in `expo-router`.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix(cli): add additional isRouteFile check before generating Expo Router types (#23694)

# Why

Expo Router's is still generating some types for invalid files.

# How

Add additional guard insi

fix(cli): add additional isRouteFile check before generating Expo Router types (#23694)

# Why

Expo Router's is still generating some types for invalid files.

# How

Add additional guard inside the `addFilePath` method

show more ...

fix: Expo Router type generation for whitespace filenames (#23662)

# Why

Expo Router type generation normalised whitespace when we should
preserve it. This keeps the types inline with edge case

fix: Expo Router type generation for whitespace filenames (#23662)

# Why

Expo Router type generation normalised whitespace when we should
preserve it. This keeps the types inline with edge case usage.

`/(my group, my other group )/my page.tsx` is a valid filename.

It should be typed as

```
/(my group)/my page
/(my other group)/my page
/my page
```

# How

Removed the URL normalisation and changed the group regex's to preserve
white space. Group names are now trimmed

# Test Plan

Updated unit tests

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: evanbacon <[email protected]>

show more ...

fix: ensure folder exists (#23664)

# Why

If the user deletes the `.expo` or `.expo/types` folder while running
Expo Router type generation, the CLI process would crash. This ensures
the folder

fix: ensure folder exists (#23664)

# Why

If the user deletes the `.expo` or `.expo/types` folder while running
Expo Router type generation, the CLI process would crash. This ensures
the folder always exists before writing to it.

show more ...

fix(cli): Fix running typed routes without an app directory. (#23661)

# Why

- Using typed routes without an app directory doesn't work.

<!--
Please describe the motivation for this PR, and li

fix(cli): Fix running typed routes without an app directory. (#23661)

# Why

- Using typed routes without an app directory doesn't work.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix: Expo Router generating types for invalid route files (#23650)

New PR after revert of

https://github.com/expo/expo/pull/23421
https://github.com/expo/expo/pull/23609

---------

Co-auth

fix: Expo Router generating types for invalid route files (#23650)

New PR after revert of

https://github.com/expo/expo/pull/23421
https://github.com/expo/expo/pull/23609

---------

Co-authored-by: evanbacon <[email protected]>

show more ...

fix(cli): add deprecation notice to typed routes export and fix types (#23636)

# Why

- The Router type was missing new functions like `canGoBack`.
- The `router` object was not typed.
- The `us

fix(cli): add deprecation notice to typed routes export and fix types (#23636)

# Why

- The Router type was missing new functions like `canGoBack`.
- The `router` object was not typed.
- The `useSearchParams` deprecation warning was being removed.
- Added missing docs.
- Add missing `Redirect` component.
- Add missing doc block for the Link component.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

Revert "fix: Expo Router generating types for invalid route files" (#23609)

Reverts expo/expo#23421

fix: Expo Router generating types for invalid route files (#23421)

# Why

https://github.com/expo/router/issues/736

Additionally, I noticed that `+html` files were not handled correctly.

# H

fix: Expo Router generating types for invalid route files (#23421)

# Why

https://github.com/expo/router/issues/736

Additionally, I noticed that `+html` files were not handled correctly.

# How

We return early inside the Metro watcher if the file is not a route file

# Test Plan

Reproduction steps in linked issue

# Checklist

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

show more ...

Rework ExpoRouter HrefObject (#23507)

# Why

Reworks how `Href` and `HrefObject` works to fix multiple issues with
Expo Router types

Fixes:
- Issues where HrefObject required `as const` typing unde

Rework ExpoRouter HrefObject (#23507)

# Why

Reworks how `Href` and `HrefObject` works to fix multiple issues with
Expo Router types

Fixes:
- Issues where HrefObject required `as const` typing under some
conditions (https://github.com/expo/router/issues/769)
- HrefObject now auto-completes all dynamic routes (previously only did
static routes)
- HrefObject `params` is no longer strict and can accept extra arguments
- `useLocalSearchParams`/`useSearchParams`/`useGlobalSearchParams` now
allow for arbitrary generics
- If a route is passed as the genertic for
`useLocalSearchParams`/`useSearchParams`/`useGlobalSearchParams` will
return an object with keys typed for the known parameters, but still
allow for arbitrary search params
- Top level catch all routes (e.g `/[...missing]`) no longer cause
typing to fail
- e.g `<Link href="/(test)/[value]" />` will now correctly error that it
should be a HrefObject and not a Href
- When setting a `param` it can be a `string` or `number` - however it
will always be a string when returned from
`useLocalSearchParams`/`useSearchParams`/`useGlobalSearchParams`

PR superseeds https://github.com/expo/expo/pull/23422

# Test Plan

Type tests were updated but some things need to be manually tested (like
autocomplete)

The project generated by `npx create-expo-app@latest --template tabs@49`
can be used to easily test.

show more ...

fix(cli): Set `preferNativePlatform` to `false` for all web requests. (#23527)

# Why

- Currently we fallback on the default or user-defined resolver if the
expo resolver fails. Now we'll skip th

fix(cli): Set `preferNativePlatform` to `false` for all web requests. (#23527)

# Why

- Currently we fallback on the default or user-defined resolver if the
expo resolver fails. Now we'll skip the default if the expo resolver
asserts.
- If the user-defined resolver is called, it will now have
`preferNativePlatform` disabled. This ensures we never attempt to
resolve a web file with `.native` extensions.

# Test Plan

- Unit tests

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

fix(cli): Added improved error message for static metro when a package is missing (#23499)

Co-authored-by: Expo Bot <[email protected]>

fix(cli): generate correct route types on Windows (#23386)

# Why

- CLI was generating wrong route types in windows
- Fixes [issue in
expo/router](https://github.com/expo/router/issues/719)
- W

fix(cli): generate correct route types on Windows (#23386)

# Why

- CLI was generating wrong route types in windows
- Fixes [issue in
expo/router](https://github.com/expo/router/issues/719)
- Watcher not adding/deleting route type in some cases, e.g. route name
with space

# How

<!--
How did you build this feature or fix this bug and why?
-->

- Normalized appRoot to use POSIX separator in windows, allowing to
remove appRoot from path
- Normalized file path from watcher to match route generated

# Test Plan
Needs to be tested on Windows:

1. Build the cli: ```yarn build```
2. Create an alias to the cli: ```alias
nexpo="/path/to/expo/packages/@expo/cli/build/bin/cli"```
3. Run expo on new project and check generated types on
```.expo\types\router.d.ts```

> Not sure it's the best way to test this, First PR to expo open to
feedback

# Checklist

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Mark Lawlor <[email protected]>

show more ...

[cli][inspector-proxy] fix devtools websocket connection on windows (#23367)

# Why

fixes #23332
close ENG-9233

# How

windows does not support `0.0.0.0` or `[::]` as loopback address. in th

[cli][inspector-proxy] fix devtools websocket connection on windows (#23367)

# Why

fixes #23332
close ENG-9233

# How

windows does not support `0.0.0.0` or `[::]` as loopback address. in these case, we should fallback to `localhost` or `[::1]`.

# Test Plan

test devtools on windows

show more ...

refactor(cli): drop extraneous source fetch workaround for `metro@<0.75.1` (#23259)

# Why

This was required for SDK 48, but with 49 we are using a newer Metro
that has this workaround built-in.

refactor(cli): drop extraneous source fetch workaround for `metro@<0.75.1` (#23259)

# Why

This was required for SDK 48, but with 49 we are using a newer Metro
that has this workaround built-in. ([see
commit](https://github.com/facebook/metro/commit/6690b393cc1812af02f8eb20853504f0a6188a83))

# How

- Dropped the `DebuggerScriptSource` handler
- Updated tests

# Test Plan

- Try debugging the code with the vscode extension

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...