| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
d7ad395f |
| 24-Jun-2023 |
Evan Bacon <[email protected]> |
fix(cli): remove invalid "none" platform (#23080)
# Why
- fix regression introduced in https://github.com/expo/expo/pull/19319
- `none` is passed to the bundler and implies the existence of
`.n
fix(cli): remove invalid "none" platform (#23080)
# Why
- fix regression introduced in https://github.com/expo/expo/pull/19319
- `none` is passed to the bundler and implies the existence of
`.none.js` files, and `Platform.select({ none: '...' })` which isn't
valid.
- The default in classic and all other implementations of the metro dev
server has been to fallback on `ios`.
- The most correct variation would be to fallback on `web` as the web is
a non-standard React Native client which doesn't implement the expo
manifest format. However, (metro) web isn't enabled in every project,
and if it were then the JSON manifest would be skipped in favor of the
HTML file.
- remove unneeded logs about offline and anonymous.
- add force-manifest-type options to help prompt.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
921ca1b4 |
| 14-Oct-2022 |
Jon Samp <[email protected]> |
[expo-cli] Add platform when running --dev-client (#19319)
* [expo-cli] Add platform when running --dev-client
* updates test
* remove .only
* Use "none" for platform when no platform is pr
[expo-cli] Add platform when running --dev-client (#19319)
* [expo-cli] Add platform when running --dev-client
* updates test
* remove .only
* Use "none" for platform when no platform is provided
* add changelog
* Update error message
* fix unit test
show more ...
|
| #
8d307f52 |
| 23-Mar-2022 |
Evan Bacon <[email protected]> |
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* f
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* fix e2e tests
* lint before build
* use mock version
show more ...
|