| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
033ea1fc |
| 04-Jul-2023 |
Cedric van Putten <[email protected]> |
refactor(cli): disable inspector proxy inline source maps for vscode only (#23258)
# Why
With SDK 49, I noticed a multi-second delay in breakpoints getting
bound. This is likely due to [Metro in
refactor(cli): disable inspector proxy inline source maps for vscode only (#23258)
# Why
With SDK 49, I noticed a multi-second delay in breakpoints getting
bound. This is likely due to [Metro inlining sourcemaps as base64
strings](https://github.com/facebook/metro/commit/6690b393cc1812af02f8eb20853504f0a6188a83)
for tools like the chrome debugger. In practice, it generates a huge
base64 string that causes this delay when decoding in vscode.
# How
- Added `debuggerType` to connect to the inspector proxy as a certain
debugger type (e.g. `vscode` or `generic` <- default)
- Added override for `Debugger.scriptParsed` to disable inline
sourcemaps for vscode only.
# Test Plan
~~TBD, since this also requires an update in vscode-expo (add the
`type=vscode` as query param when connecting to the inspector proxy).~~
This is now included in `[email protected]`
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
03d43e7d |
| 28-Mar-2023 |
Cedric van Putten <[email protected]> |
feature(cli): add basic `Page.reload` support to reload the app from inspector (#21827)
# Why
This implements the `Page.reload` CDP event, to reload the app itself.
> Would be nice if there is
feature(cli): add basic `Page.reload` support to reload the app from inspector (#21827)
# Why
This implements the `Page.reload` CDP event, to reload the app itself.
> Would be nice if there is a way to send this to _JUST_ the device you
are inspecting. But not sure what socket connection that would be, don't
think it's the actual device socket in the inspector (that's inspector
messages only).
# How
- Provided the reference of `MetroBundlerDevServer` to the inspector
- Called `MetroBundlerDevServer.broadcastMessage('reload')`
# Test Plan
- Open chrome inspector (`j`)
- Anywhere in the inspector, press `cmd+r`
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|