| #
da5824c9 |
| 12-Jun-2023 |
Kudo Chien <[email protected]> |
[cli] fix typecheck from react-native 0.72 upgrade (#22766)
# Why
follow up #22588 which disabled the cli typecheck
# How
using types from metro and fix typing issues
# Test Plan
cli
[cli] fix typecheck from react-native 0.72 upgrade (#22766)
# Why
follow up #22588 which disabled the cli typecheck
# How
using types from metro and fix typing issues
# Test Plan
cli ci passed
show more ...
|
| #
9580591f |
| 30-Apr-2023 |
Evan Bacon <[email protected]> |
feat(metro-config, cli): CSS serializer (#22325)
# Why
In order to support static CSS in development mode, we need to update
the metro serializer to support returning the JS and CSS assets. We n
feat(metro-config, cli): CSS serializer (#22325)
# Why
In order to support static CSS in development mode, we need to update
the metro serializer to support returning the JS and CSS assets. We now
inline the CSS in the HTML before sending to the client, this allows for
testing how the website works with JS disabled. We use the same style
tag id to continue to support HMR for styles during subsequent updates.
This change also refactors how exports work to serialize JS and CSS at
the same time (i.e. after the native transformations).
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|