History log of /expo/packages/@expo/cli/src/start/server/__tests__/UrlCreator-test.ts (Results 1 – 6 of 6)
Revision Date Author Comments
# 847c099d 15-Aug-2023 Cedric van Putten <[email protected]>

fix(cli): avoid creating dev client urls containing `_` in protocol (#23519)

# Why

Fixes #23440

Unfortunately, due to Node's limitation in URL, we can't use `_` in
protocols. Even when we do

fix(cli): avoid creating dev client urls containing `_` in protocol (#23519)

# Why

Fixes #23440

Unfortunately, due to Node's limitation in URL, we can't use `_` in
protocols. Even when we do fix it, we run into URL parsing issues in
Expo Router (that's also using Node's URL). Instead, this change makes
protocols containing `_` fully invalid as any dev client URL.

# How

- Prohibited dev client URLs with `_` characters in the protocol
- This will trigger the
[`_resolveAlternativeLaunchUrl`](https://github.com/expo/expo/blob/main/packages/%40expo/cli/src/start/platforms/android/AndroidPlatformManager.ts#L48-L53)
on Android and create `com.example.some_package/.MainActivity` instead


# Test Plan

- `$ yarn create expo ./fix-23440 --template tabs@49`
- `$ cd ./fix-23440`
- Update `app.json` with `expo.android.package =
"com.example.protocol_underscore"`
- `$ yarn expo run:android`
- Should fall back to `com.example.protocol_underscore/.MainActivity`
URL and open the app properly

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

show more ...


# 48783050 10-Nov-2022 Evan Bacon <[email protected]>

fix(cli): prevent using default port 80 with tunnels (#18475)


# 212e3a1a 26-Sep-2022 Eric Samelson <[email protected]>

[cli] ensure that development build is installed when opening interstitial page (#18836)

Co-authored-by: evanbacon <[email protected]>


# 9afd2165 04-Aug-2022 Evan Bacon <[email protected]>

feat(cli): add EXPO_NO_DEFAULT_PORT to skip proxy port (#18464)


# fa5bc561 30-Apr-2022 Will Schurman <[email protected]>

chore(cli): deduplicate asMock helper function (#17294)


# 8d307f52 23-Mar-2022 Evan Bacon <[email protected]>

chore: refactor `expo/cli` to `@expo/cli` package (#16717)

* chore: refactor `expo/cli` to `@expo/cli` package

* Update CODEOWNERS

* fix linking

* fix lint script

* fix build file

* f

chore: refactor `expo/cli` to `@expo/cli` package (#16717)

* chore: refactor `expo/cli` to `@expo/cli` package

* Update CODEOWNERS

* fix linking

* fix lint script

* fix build file

* fix e2e tests

* lint before build

* use mock version

show more ...