| #
9ba03fb0 |
| 23-Aug-2023 |
Will Schurman <[email protected]> |
[config][cli] Remove classic manifest types (#24054)
|
| #
065a44f7 |
| 04-Jul-2023 |
Cedric van Putten <[email protected]> |
fix(cli, dev-server): add `SYSTEMROOT` for `open` when opening browsers on Windows (#23287)
# Why
Fixes #23252
# How
- `open` has a bug on Windows, where it [uses
`process.env.SYSTEMROOT`]
fix(cli, dev-server): add `SYSTEMROOT` for `open` when opening browsers on Windows (#23287)
# Why
Fixes #23252
# How
- `open` has a bug on Windows, where it [uses
`process.env.SYSTEMROOT`](https://github.com/sindresorhus/open/blob/main/index.js#L173)
instead of
[`process.env.SystemRoot`](https://en.wikipedia.org/wiki/Environment_variable#:~:text=The%20%25SystemRoot%25%20variable%20is%20a,including%20the%20drive%20and%20path.)
- This causes the executed command to run with `undefined\\...`
- There has been no fix yet, and due to `open` being fully ESM now, we
probably can't upgrade too
> See various issues
[#300](https://github.com/sindresorhus/open/issues/300),
[#292](https://github.com/sindresorhus/open/issues/292),
[#270](https://github.com/sindresorhus/open/issues/270), or
[#205](https://github.com/sindresorhus/open/issues/205)
This basically sets the missing `SYSTEMROOT` when trying to open a
browser on Windows. It's fixed in both `@expo/cli` as well as
`@expo/dev-server` (to open the Chrome DevTools).
# Test Plan
This has to be tested on Windows.
- `$ yarn create expo ./test-browser -t tabs@beta`
- `$ cd ./test-browser`
- `$ yarn start`
- Try pressing the following keys:
- `j` -> to open the Chrome DevTools, after connecting a device. Should
work as expected.
- `w` -> to open the browser with Metro web. Should work as expected.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
33643b60 |
| 04-Mar-2023 |
Evan Bacon <[email protected]> |
feat(cli): auto setup typescript during start (#21475)
# Why
- Some users are confused about how to use the fully automated
TypeScript setup. It currently runs when you run `npx expo start` in a
feat(cli): auto setup typescript during start (#21475)
# Why
- Some users are confused about how to use the fully automated
TypeScript setup. It currently runs when you run `npx expo start` in a
project with `tsconfig.json` or any TypeScript file in the project.
- This change will run the TypeScript check continuously until
TypeScript is setup. This only applies to projects using Metro, and
currently is only run in `npx expo start`, and the run commands (when
the server is started in the current window, e.g. not headless mode).
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Fork the `runServer` function from Metro into the CLI so we can access
the Metro bundler instance directly.
- Use Metro's native file watching to observe new TypeScript files being
added to the project (within the observable files). This is fast and
ensures we don't accidentally block a thread that otherwise could've
been used for bundling.
- The TypeScript continuous check only runs once, if you remove
TypeScript and add it back in the same process, then nothing happens.
This is a performance optimization.
- If TypeScript is enabled while the process is running, the user will
not be prompted to install, the packages will just install in the
project. Failures will be displayed in the running process, and no more
attempts will be made.
- If TypeScript is detected on start then the existing system will be
used and the continuous check will be skipped, this means projects
already using TypeScript won't have any technical performance hit.
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- In a project without TypeScript:
- `npx expo`
- `touch tsconfig.json` or `mv index.js index.tsx` or `touch foo.tsx`
- TypeScript is automatically installed for the project.
- `EXPO_NO_TYPESCRIPT_SETUP` voids this behavior
- Added unit tests.
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Cedric van Putten <[email protected]>
show more ...
|
| #
e4018db2 |
| 10-Nov-2022 |
evanbacon <[email protected]> |
fix(cli): tests
|
| #
57a0d514 |
| 08-Nov-2022 |
Kudo Chien <[email protected]> |
[cli] Fix start hermes debugger crash when starting with --dev-client (#19919)
|
| #
a91e9b85 |
| 14-Oct-2022 |
Evan Bacon <[email protected]> |
feat(cli): open tunnels on web (#19504)
* feat: open tunnel urls with metro web
* Update CHANGELOG.md
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <34669131+expo-bot@us
feat(cli): open tunnels on web (#19504)
* feat: open tunnel urls with metro web
* Update CHANGELOG.md
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update BundlerDevServer-test.ts
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
212e3a1a |
| 26-Sep-2022 |
Eric Samelson <[email protected]> |
[cli] ensure that development build is installed when opening interstitial page (#18836)
Co-authored-by: evanbacon <[email protected]>
|
| #
6d6b81f9 |
| 23-Jun-2022 |
Evan Bacon <[email protected]> |
feat(cli): add web support to metro (#17927)
* feat: add web support for metro
* undo patch
* Update index.js
* Update MetroBundlerDevServer.ts
* Add second bundler dev server
* Add d
feat(cli): add web support to metro (#17927)
* feat: add web support for metro
* undo patch
* Update index.js
* Update MetroBundlerDevServer.ts
* Add second bundler dev server
* Add dev loading view to web
* Put feature behind EXPO_USE_METRO_WEB flag
* Move custom config into CLI
* Add support for assets across platforms
* reduce
* Added upstream web support
* Update webTemplate.ts
* Update CHANGELOG.md
* Update instantiateMetro.ts
* Update instantiateMetro.ts
* Update index.js
* Added bundle splitting support
* Update startAsync.ts
* Fixed default settings
* Add ability to copy from public folder
* wip: redirect unmatched routes to `/` on web
* fix fallback api
* Update exportApp.ts
* Update instantiateMetro.ts
* Update exportApp.ts
* clean up handler
* fixup
* clean up
* add web to export test
* Update start-test.ts
* added static serving for web
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update yarn.lock
lint fix
fix tests
* Update export-test.ts
* added template tests
* Create HistoryFallbackMiddleware-test.ts
* test ManifestMiddleware
* Create ServeStaticMiddleware-test.ts
* refactor multiplatform
* Update ManifestMiddleware-test.ts
* Update withMetroMultiPlatform.ts
* Update for latest metro
* Update packages/@expo/cli/src/export/resolveOptions.ts
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
3d6e487d |
| 27-Apr-2022 |
Evan Bacon <[email protected]> |
feat(cli): add `run:android` command (#17187)
* feat(cli): add `run:android` command
* added partial e2e test
* fix platforms showing up in terminal ui
* fix launching by link
* Update p
feat(cli): add `run:android` command (#17187)
* feat(cli): add `run:android` command
* added partial e2e test
* fix platforms showing up in terminal ui
* fix launching by link
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* fix platforms showing up in terminal ui
fix launching by link
fixup tests
Delete resolveArgs-test.ts.snap
* revert changes
* Update index-test.ts
Update WebpackBundlerDevServer.ts
Update WebpackBundlerDevServer.ts
Update WebpackBundlerDevServer.ts
Update PlatformManager.ts
* Update index-test.ts
* update structure
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
8d307f52 |
| 23-Mar-2022 |
Evan Bacon <[email protected]> |
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* f
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* fix e2e tests
* lint before build
* use mock version
show more ...
|