| #
847c099d |
| 15-Aug-2023 |
Cedric van Putten <[email protected]> |
fix(cli): avoid creating dev client urls containing `_` in protocol (#23519)
# Why
Fixes #23440
Unfortunately, due to Node's limitation in URL, we can't use `_` in
protocols. Even when we do
fix(cli): avoid creating dev client urls containing `_` in protocol (#23519)
# Why
Fixes #23440
Unfortunately, due to Node's limitation in URL, we can't use `_` in
protocols. Even when we do fix it, we run into URL parsing issues in
Expo Router (that's also using Node's URL). Instead, this change makes
protocols containing `_` fully invalid as any dev client URL.
# How
- Prohibited dev client URLs with `_` characters in the protocol
- This will trigger the
[`_resolveAlternativeLaunchUrl`](https://github.com/expo/expo/blob/main/packages/%40expo/cli/src/start/platforms/android/AndroidPlatformManager.ts#L48-L53)
on Android and create `com.example.some_package/.MainActivity` instead
# Test Plan
- `$ yarn create expo ./fix-23440 --template tabs@49`
- `$ cd ./fix-23440`
- Update `app.json` with `expo.android.package =
"com.example.protocol_underscore"`
- `$ yarn expo run:android`
- Should fall back to `com.example.protocol_underscore/.MainActivity`
URL and open the app properly
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|
| #
a7e47f4d |
| 16-Jun-2023 |
Evan Bacon <[email protected]> |
feat(cli): Add ability to switch runtimes during start. (#22924)
# Why
- We're going to start making the `--dev-client` flag be on more
aggressively, i.e. favoring custom builds over Expo Go mor
feat(cli): Add ability to switch runtimes during start. (#22924)
# Why
- We're going to start making the `--dev-client` flag be on more
aggressively, i.e. favoring custom builds over Expo Go more.
- This doesn't lean one way or the other, but it does make it easier to
course correct if we guess wrong. We'll also be adding an explicit flag
to force the initial mode.
- Some caveats:
- The custom `--scheme` is not currently respected.
- Non-dev-client runs will validate versions, here we don't validate
versions during the swap.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Press `s` to swap runtime modes. This can happen with `npx expo
start`, `run:ios`, and `run:android`
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- TBD
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Brent Vatne <[email protected]>
show more ...
|
| #
47d62600 |
| 16-Jun-2023 |
Kudo Chien <[email protected]> |
[cli][packages] unify the default dev server port to 8081 (#22880)
# Why
for historical reasons, when running `npx expo start` the dev-server listens to port 19000, and running `npx expo start --
[cli][packages] unify the default dev server port to 8081 (#22880)
# Why
for historical reasons, when running `npx expo start` the dev-server listens to port 19000, and running `npx expo start --dev-client` it listens to port 8081. since we are now on our effort to deprecate `--dev-client` option, it is better to unify the listening port.
close ENG-8936
# How
- update packages/**/*.ts for port 19000 -> 8081
- search more occurrences for 19000 to 8081
# Test Plan
- ci passed
- bare-expo
- unversioned expo go + ncl
show more ...
|
| #
48783050 |
| 10-Nov-2022 |
Evan Bacon <[email protected]> |
fix(cli): prevent using default port 80 with tunnels (#18475)
|
| #
212e3a1a |
| 26-Sep-2022 |
Eric Samelson <[email protected]> |
[cli] ensure that development build is installed when opening interstitial page (#18836)
Co-authored-by: evanbacon <[email protected]>
|
| #
9afd2165 |
| 04-Aug-2022 |
Evan Bacon <[email protected]> |
feat(cli): add EXPO_NO_DEFAULT_PORT to skip proxy port (#18464)
|
| #
474a7a4b |
| 21-Jun-2022 |
Evan Bacon <[email protected]> |
chore(cli): migrate to debug package (#17084)
* chore(cli): migrate to debug package
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]
chore(cli): migrate to debug package (#17084)
* chore(cli): migrate to debug package
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update checkPackages.ts
* Update packages/@expo/cli/src/start/platforms/android/ADBServer.ts
* Update ADBServer.ts
* Update activateWindow.ts
* Update adb.ts
* migrate new methods to debug
* Update variadic.ts
* Update yarn.lock
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
3d6e487d |
| 27-Apr-2022 |
Evan Bacon <[email protected]> |
feat(cli): add `run:android` command (#17187)
* feat(cli): add `run:android` command
* added partial e2e test
* fix platforms showing up in terminal ui
* fix launching by link
* Update p
feat(cli): add `run:android` command (#17187)
* feat(cli): add `run:android` command
* added partial e2e test
* fix platforms showing up in terminal ui
* fix launching by link
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* fix platforms showing up in terminal ui
fix launching by link
fixup tests
Delete resolveArgs-test.ts.snap
* revert changes
* Update index-test.ts
Update WebpackBundlerDevServer.ts
Update WebpackBundlerDevServer.ts
Update WebpackBundlerDevServer.ts
Update PlatformManager.ts
* Update index-test.ts
* update structure
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
29975bfd |
| 28-Mar-2022 |
Evan Bacon <[email protected]> |
fix(cli): fix type errors (#16724)
* fix(cli): fix type errors
* Update CHANGELOG.md
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]
fix(cli): fix type errors (#16724)
* fix(cli): fix type errors
* Update CHANGELOG.md
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* fix typecheck
* Update yarn.lock
* Update package.json
* Update MetroTerminalReporter.ts
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
8d307f52 |
| 23-Mar-2022 |
Evan Bacon <[email protected]> |
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* f
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* fix e2e tests
* lint before build
* use mock version
show more ...
|