| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
c10212b1 |
| 28-Apr-2023 |
Kudo Chien <[email protected]> |
[cli] fix activity starting error on android 13 (#22286)
# Why
fix `yarn run android` does not start activity on android 13 from a bare-minimum app
fix #22210
close ENG-8426
# How
from an
[cli] fix activity starting error on android 13 (#22286)
# Why
fix `yarn run android` does not start activity on android 13 from a bare-minimum app
fix #22210
close ENG-8426
# How
from android 13, starting will fail if there are no explicitly matched intent-filters: https://developer.android.com/guide/components/intents-filters#match-intent-filter
on an app from generated from bare-minimum template: `yarn create expo -t bare-minimum` without ever prebuilding. we will start the activity with `android.intent.action.RUN` action, but the app does not register this action and cause an error.
```
Starting: Intent { act=android.intent.action.RUN cmp=com.testapp/.MainActivity }
Error type 3
Error: Activity class {com.testapp/com.testapp.MainActivity} does not exist.
```
this pr tries to remove the `android.intent.action.RUN` given that `-n package/.MainActivity` should be good enough.
# Test Plan
- [x] ci passed
- [x] bare-minimum app on android 13
- [x] bare-minimum app on android 12
- [x] bare-minimum app after prebuild (will start with deep linking because we will generate scheme after prebuild: `adb shell am start -a android.intent.action.VIEW -d com.testapp://expo-development-client/?url=...`)
- [x] npx expo run:android with expo-dev-client (`adb shell am start -a android.intent.action.VIEW -d com.testapp://expo-development-client/?url=...`)
- [x] npx expo start (Expo Go case, `adb shell monkey -p host.exp.exponent -c android.intent.category.LAUNCHER 1` + `adb shell am start -a android.intent.action.VIEW -d exp://192.168.1.1:19000`)
show more ...
|
| #
8ce30dc2 |
| 14-Dec-2022 |
Evan Bacon <[email protected]> |
Escape ampersands in URLs sent to adb. (#20398)
# Why
- applies bug found in `uri-scheme`
https://github.com/expo/expo-cli/pull/4538
<!--
Please describe the motivation for this PR, and link
Escape ampersands in URLs sent to adb. (#20398)
# Why
- applies bug found in `uri-scheme`
https://github.com/expo/expo-cli/pull/4538
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# Test Plan
Added automated test
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
474a7a4b |
| 21-Jun-2022 |
Evan Bacon <[email protected]> |
chore(cli): migrate to debug package (#17084)
* chore(cli): migrate to debug package
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]
chore(cli): migrate to debug package (#17084)
* chore(cli): migrate to debug package
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update checkPackages.ts
* Update packages/@expo/cli/src/start/platforms/android/ADBServer.ts
* Update ADBServer.ts
* Update activateWindow.ts
* Update adb.ts
* migrate new methods to debug
* Update variadic.ts
* Update yarn.lock
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
cc6b646a |
| 05-May-2022 |
Cedric van Putten <[email protected]> |
[cli] Fix ADB device name filtering for windows (#17286)
|
| #
3d6e487d |
| 27-Apr-2022 |
Evan Bacon <[email protected]> |
feat(cli): add `run:android` command (#17187)
* feat(cli): add `run:android` command
* added partial e2e test
* fix platforms showing up in terminal ui
* fix launching by link
* Update p
feat(cli): add `run:android` command (#17187)
* feat(cli): add `run:android` command
* added partial e2e test
* fix platforms showing up in terminal ui
* fix launching by link
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* fix platforms showing up in terminal ui
fix launching by link
fixup tests
Delete resolveArgs-test.ts.snap
* revert changes
* Update index-test.ts
Update WebpackBundlerDevServer.ts
Update WebpackBundlerDevServer.ts
Update WebpackBundlerDevServer.ts
Update PlatformManager.ts
* Update index-test.ts
* update structure
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
29975bfd |
| 28-Mar-2022 |
Evan Bacon <[email protected]> |
fix(cli): fix type errors (#16724)
* fix(cli): fix type errors
* Update CHANGELOG.md
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]
fix(cli): fix type errors (#16724)
* fix(cli): fix type errors
* Update CHANGELOG.md
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* fix typecheck
* Update yarn.lock
* Update package.json
* Update MetroTerminalReporter.ts
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
8d307f52 |
| 23-Mar-2022 |
Evan Bacon <[email protected]> |
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* f
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* fix e2e tests
* lint before build
* use mock version
show more ...
|