| #
75a300d7 |
| 07-Sep-2023 |
Evan Bacon <[email protected]> |
feat(cli): ensure port is running after build. (#24315)
# Why
If a user runs either build command (`npx expo run:ios` or `npx expo
run:android`) simultaneously, then there is chance for a port c
feat(cli): ensure port is running after build. (#24315)
# Why
If a user runs either build command (`npx expo run:ios` or `npx expo
run:android`) simultaneously, then there is chance for a port conflict.
This change proposes we run a secondary port check after the build to
provide a slightly better user experience. If the port is taken by the
same app, the dev server will be skipped and the process will proceed in
headless-mode, if the port is taken by a different process, then an
error will be thrown.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
6a750d06 |
| 08-Apr-2023 |
Evan Bacon <[email protected]> |
feat(cli, metro-config): environment variable support (#21983)
# Why
- It's nice to be able to use uncommitted values in your app, based on
the environment. This feels very familiar to web devel
feat(cli, metro-config): environment variable support (#21983)
# Why
- It's nice to be able to use uncommitted values in your app, based on
the environment. This feels very familiar to web developers.
- Values that are prefixed with `EXPO_PUBLIC_` will be inlined in the
bundle when bundling normally (e.g. not for Node.js).
- `.env` files are loaded into memory and applied to the process during
a run. This also means that they're available in `app.config.js`.
- During development-only, environment variables are exposed on the
`process.env` object (non-enumerable) to ensure they're available
between fast refresh updates.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Create new package `@expo/env` which is used to hydrate env variables
in a unified way. I plan to open another PR in `eas-cli` which uses this
package to fill in environment variables before uploading. NOTE:
environment variables that are defined in eas.json are not available in
Expo CLI when building locally, but are available in the cloud since
they'll be on the process, this means they effectively emulate
`.env.production`.
- Update templates to gitignore local env files.
- Add basic documentation to the versioned metro guide (more to come).
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- [ ] E2E rendering test
- [ ] E2E Node.js rendering test
- [x] Unit tests for serializer
- [x] Tests for env package
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
2dd43328 |
| 24-Feb-2023 |
Evan Bacon <[email protected]> |
feat(cli)!: set node and babel env for CLI commands (#21337)
# Why
- User's may want to dynamically configure Metro or their Expo Config
file to work differently when bundling for production env
feat(cli)!: set node and babel env for CLI commands (#21337)
# Why
- User's may want to dynamically configure Metro or their Expo Config
file to work differently when bundling for production environments, they
can now do this by utilizing the standard `NODE_ENV` environment
variable. We've been doing this with Webpack since it was introduced.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Set `NODE_ENV` and `BABEL_ENV` environment variables to `development`
or `production` in `start`, `export`, `customize`, `install`, `run:ios`,
`run:android`, `config`, `prebuild` commands based on the input mode.
- This can be overwritten by setting `NODE_ENV` and `BABEL_ENV` manually
before running. `BABEL_ENV` will be set to `NODE_ENV` if defined.
- Most commands can safely default to assuming `development`.
- Only thing that this doesn't cover is `npx react-native bundle` and
`npx react-native start` (building from Xcode/Android Studio). We'll
need to change these commands in the future but it shouldn't be blocking
for this PR.
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
c4ef02ae |
| 03-May-2022 |
Evan Bacon <[email protected]> |
feat(cli): add `run:ios` command (#16662)
* [wip] Added expo run:ios command
* Clean up run:ios
* feat(cli): add headless server mode
* fix(cli): fix run:ios logic issues
* Update CHANGE
feat(cli): add `run:ios` command (#16662)
* [wip] Added expo run:ios command
* Clean up run:ios
* feat(cli): add headless server mode
* fix(cli): fix run:ios logic issues
* Update CHANGELOG.md
* Update packages/expo/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* clean up
* refine fixture
* refactor and test code signing
* Update resolveOptionsAsync.ts
* fix merge
* added new impl
* Update AppleDevice.ts
* Added more tests
* fixed e2e tests
* lint fix
* Update index-test.ts
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
3d6e487d |
| 27-Apr-2022 |
Evan Bacon <[email protected]> |
feat(cli): add `run:android` command (#17187)
* feat(cli): add `run:android` command
* added partial e2e test
* fix platforms showing up in terminal ui
* fix launching by link
* Update p
feat(cli): add `run:android` command (#17187)
* feat(cli): add `run:android` command
* added partial e2e test
* fix platforms showing up in terminal ui
* fix launching by link
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* fix platforms showing up in terminal ui
fix launching by link
fixup tests
Delete resolveArgs-test.ts.snap
* revert changes
* Update index-test.ts
Update WebpackBundlerDevServer.ts
Update WebpackBundlerDevServer.ts
Update WebpackBundlerDevServer.ts
Update PlatformManager.ts
* Update index-test.ts
* update structure
Co-authored-by: Expo Bot <[email protected]>
show more ...
|