fix(cli): only warn users when using non-recommended versions of important dependencies (#23232)

# Why

<img width="937" alt="image"
src="https://github.com/expo/expo/assets/1203991/0352e5db-dc19

fix(cli): only warn users when using non-recommended versions of important dependencies (#23232)

# Why

<img width="937" alt="image"
src="https://github.com/expo/expo/assets/1203991/0352e5db-dc19-46d4-a348-cb84b3b624c2">

This warning was over-eagerly displayed to users during the SDK 49 beta.
This change fixes that behavior to only warn when the used versions and
recommended versions do not intersect.

# How

- Turned out it was `finally` always returning `false`, replaced with
`catch`

# Test Plan

- `$ yarn create expo ./test-prebuild-version-warning -t tabs@beta`
- `$ cd ./test-prebuild-version-warning`
- `$ yarn expo prebuild`
- Should not warn in its current state

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

refactor(cli): avoid changing required dependency versions when prebuilding (#23146)

# Why

In the past, we've had issues with bugfixes and minor bumps causing
issues in user projects, without us

refactor(cli): avoid changing required dependency versions when prebuilding (#23146)

# Why

In the past, we've had issues with bugfixes and minor bumps causing
issues in user projects, without user knowledge of these bumps.

# How

Instead of overwriting, the user is prompted with a warning that they
arent using the recommended versions. This can be resolved with `expo
install --fix` before prebuilding.

# Test Plan

- `$ yarn create expo ./test`
- Downgrade (patch or minor) any of these packages:
- `expo`, `expo-splash-screen`, `react`, or `react-native`
- `$ yarn expo prebuild`
- This command should warn you that you are not using the recommended
versions. It should NOT change these versions.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...

[cli] remove --dev-client prebuild side effect (#23121)

# Why

the `--dev-client` is deprecated in sdk 49

# How

remove the side effect of adding `--dev-client` when prebuild

# Test Plan

[cli] remove --dev-client prebuild side effect (#23121)

# Why

the `--dev-client` is deprecated in sdk 49

# How

remove the side effect of adding `--dev-client` when prebuild

# Test Plan

ci pass

show more ...

refactor(cli): only add `react` and `react-native` when missing in prebuild (#22624)

# Why

Fixes ENG-8480

This prevents accidental overwrites during `expo prebuild`. It's
particularly painful

refactor(cli): only add `react` and `react-native` when missing in prebuild (#22624)

# Why

Fixes ENG-8480

This prevents accidental overwrites during `expo prebuild`. It's
particularly painful in monorepos where users might want to use a
specific react-native version, and not use the patch update.

# How

Marked both `react` and `react-native` as "add when missing" packages.
Meaning that if it's not defined, we still add it. But once it's
defined, we only warn when the semver range DOES NOT intersect (`react`
and `react-native` are defined as exact versions in the templates).

Note, that this still bumps `expo` and `expo-splash-screen`, which I
think makes sense due to us releasing patch fixes regularly. But we can
opt into fully disabling any bumps during prebuild in general.

# Test Plan

See added tests, and:

- `$ yarn create expo ./test-app && cd ./test-app`
- Modify the React / React Native version to a lower patch/minor bump
- `$ yarn expo prebuild`
- This should warn with `using current versions instead of the
recommended react@<version>, react-native@<version>`, it should not
change the versions anymore.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

show more ...

Remove entry file modification/index.js generation from `expo prebuild` (#22044)

# Why

- Possible since https://github.com/expo/expo/pull/21643
- Arbitrary entry files in development only work w

Remove entry file modification/index.js generation from `expo prebuild` (#22044)

# Why

- Possible since https://github.com/expo/expo/pull/21643
- Arbitrary entry files in development only work when using
`expo-dev-client` or `.expo/.virtual-metro-entry` (SDK +49).

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# Test Plan

- TBD

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>

show more ...

revert #18381 (#19712)

feat(cli)!: Auto resolve project entry point in `expo prebuild` (#18381)

* feat: drop requirement for index.js on iOS by using expo entry resolution.

- The Android version of this was added in #1

feat(cli)!: Auto resolve project entry point in `expo prebuild` (#18381)

* feat: drop requirement for index.js on iOS by using expo entry resolution.

- The Android version of this was added in #14964

* feat(cli)!: Drop support for copying `index.js` and removing `main` field in `package.json` during `expo prebuild`

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

* Update copyTemplateFiles.ts

* updated tests

* Update migrating.md

* Update docs/pages/build-reference/migrating.md

Co-authored-by: Aman Mittal <[email protected]>

* Update templates/expo-template-bare-minimum/ios/HelloWorld.xcodeproj/project.pbxproj

* Update project.pbxproj

* Update createManifest.js

* Update project.pbxproj

* Update project.pbxproj

* Update create-manifest-ios.sh

Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>

show more ...

fix: correct required packages in prebuild (#17447)

* fix: correct required packages in prebuild

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]

fix: correct required packages in prebuild (#17447)

* fix: correct required packages in prebuild

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <[email protected]>

Co-authored-by: Expo Bot <[email protected]>

show more ...

chore: refactor `expo/cli` to `@expo/cli` package (#16717)

* chore: refactor `expo/cli` to `@expo/cli` package

* Update CODEOWNERS

* fix linking

* fix lint script

* fix build file

* f

chore: refactor `expo/cli` to `@expo/cli` package (#16717)

* chore: refactor `expo/cli` to `@expo/cli` package

* Update CODEOWNERS

* fix linking

* fix lint script

* fix build file

* fix e2e tests

* lint before build

* use mock version

show more ...