| #
9f789f00 |
| 01-Sep-2023 |
Alan Hughes <[email protected]> |
[cli] Misleading build message (#24153)
|
| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
4149568c |
| 17-May-2023 |
Evan Bacon <[email protected]> |
Remove entry file modification/index.js generation from `expo prebuild` (#22044)
# Why
- Possible since https://github.com/expo/expo/pull/21643
- Arbitrary entry files in development only work w
Remove entry file modification/index.js generation from `expo prebuild` (#22044)
# Why
- Possible since https://github.com/expo/expo/pull/21643
- Arbitrary entry files in development only work when using
`expo-dev-client` or `.expo/.virtual-metro-entry` (SDK +49).
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# Test Plan
- TBD
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
show more ...
|
| #
bbb610b5 |
| 17-May-2023 |
Evan Bacon <[email protected]> |
Drop `metro.config.js` copy step in `expo prebuild` (#22045)
# Why
- Possible since https://github.com/expo/expo/issues/21396
- If the `metro.config.js` is missing, then the default,
`@expo/met
Drop `metro.config.js` copy step in `expo prebuild` (#22045)
# Why
- Possible since https://github.com/expo/expo/issues/21396
- If the `metro.config.js` is missing, then the default,
`@expo/metro-config`, will be used.
- Drop `metro.config.js` copy step in `expo prebuild` in favor of `expo
export:embed` and the new Xcode start script using Expo CLI--this only
works when using Expo CLI for all bundling (SDK +49).
- Maybe we could add a metro linting step to `npx expo-doctor` in the
future.
# Test Plan
- tbd
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
show more ...
|
| #
5492d26a |
| 20-Apr-2023 |
Cedric van Putten <[email protected]> |
feature(cli): improve prebuild for arbitrary template platforms (#22201)
# Why
This should improve users who have custom platforms for prebuild, like
`tvos`.
# How
- Lifted the limitation
feature(cli): improve prebuild for arbitrary template platforms (#22201)
# Why
This should improve users who have custom platforms for prebuild, like
`tvos`.
# How
- Lifted the limitation on the `expo prebuild --platform` flag
- Check if the template has `./${platform}` folder before copying files
over
# Examples
<details><summary>Platforms existing in the template</summary>
<img width="924" alt="image"
src="https://user-images.githubusercontent.com/1203991/233436089-c19a1e76-5f6d-4121-8570-a8152f8039fb.png">
</details>
<details><summary>Platforms not existing in the template</summary>
<img width="564" alt="image"
src="https://user-images.githubusercontent.com/1203991/233439559-bbe7cc4f-6272-4991-9d2a-fad302486b0a.png">
</details>
# Test Plan
- `$ yarn create expo-app ./test-platforms`
- `$ cd ./test-platforms`
- `$ yarn expo prebuild --platform windows --template
https://github.com/microsoft/react-native-windows-samples/tree/main/samples/AppServiceDemo`
The last step should use the `./windows` folder from the
[AppServiceDemo](https://github.com/microsoft/react-native-windows-samples/tree/main/samples/AppServiceDemo)
as template files inside this project.
If there are any plugins defined for that platform, they should be
picked up automatically.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
7977e438 |
| 28-Oct-2022 |
Evan Bacon <[email protected]> |
revert #18381 (#19712)
|
| #
6e1af36d |
| 29-Aug-2022 |
Evan Bacon <[email protected]> |
feat(cli)!: Auto resolve project entry point in `expo prebuild` (#18381)
* feat: drop requirement for index.js on iOS by using expo entry resolution.
- The Android version of this was added in #1
feat(cli)!: Auto resolve project entry point in `expo prebuild` (#18381)
* feat: drop requirement for index.js on iOS by using expo entry resolution.
- The Android version of this was added in #14964
* feat(cli)!: Drop support for copying `index.js` and removing `main` field in `package.json` during `expo prebuild`
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update copyTemplateFiles.ts
* updated tests
* Update migrating.md
* Update docs/pages/build-reference/migrating.md
Co-authored-by: Aman Mittal <[email protected]>
* Update templates/expo-template-bare-minimum/ios/HelloWorld.xcodeproj/project.pbxproj
* Update project.pbxproj
* Update createManifest.js
* Update project.pbxproj
* Update project.pbxproj
* Update create-manifest-ios.sh
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
show more ...
|
| #
8d307f52 |
| 23-Mar-2022 |
Evan Bacon <[email protected]> |
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* f
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* fix e2e tests
* lint before build
* use mock version
show more ...
|