| #
edc75823 |
| 26-Apr-2023 |
Evan Bacon <[email protected]> |
feat(config plugins): better support out of tree support (#22209)
# Why
Fix various validation issues when using `nexpo prebuild --platform
windows --template
https://github.com/microsoft/react
feat(config plugins): better support out of tree support (#22209)
# Why
Fix various validation issues when using `nexpo prebuild --platform
windows --template
https://github.com/microsoft/react-native-windows-samples/tree/main/samples/AppServiceDemo`
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
608dafdd |
| 22-Apr-2023 |
Cedric van Putten <[email protected]> |
fix(cli): skip verifying arbitrary platforms without verifier (#22228)
# Why
We can't validate platforms without verifiers
<img width="1285" alt="image"
src="https://user-images.githubuse
fix(cli): skip verifying arbitrary platforms without verifier (#22228)
# Why
We can't validate platforms without verifiers
<img width="1285" alt="image"
src="https://user-images.githubusercontent.com/1203991/233750020-4d7d47c3-ef3b-4c7d-82a7-872050443fca.png">
# How
- Filtered platforms on verification availability
# Test Plan
See added test
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
def098a4 |
| 27-Oct-2022 |
Evan Bacon <[email protected]> |
feat(cli): reduce multi target iOS warnings (#18890)
* feat(cli): handle multi-target ios app opening better
* Update scheme.ts
* Update clearNativeFolder.ts
* Update withIosBaseMods.ts
feat(cli): reduce multi target iOS warnings (#18890)
* feat(cli): handle multi-target ios app opening better
* Update scheme.ts
* Update clearNativeFolder.ts
* Update withIosBaseMods.ts
* check for pbxproj
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update scheme.ts
* Update clearNativeFolder-test.ts
* Update MetroBundlerDevServer-test.ts
* Update MetroBundlerDevServer-test.ts
* Update scheme.ts
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
8721fb84 |
| 03-Aug-2022 |
Wojciech Kozyra <[email protected]> |
chore(cli): Add warning when prebuilding with CI=1 (#18436)
|
| #
29128565 |
| 27-Jul-2022 |
Evan Bacon <[email protected]> |
feat(cli): disable prompts in non interactive processes (#18300)
* feat(cli): disable prompts in non interactive processes
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <34
feat(cli): disable prompts in non interactive processes (#18300)
* feat(cli): disable prompts in non interactive processes
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update startAsync.ts
* fix tests
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
814b6faf |
| 15-Apr-2022 |
Evan Bacon <[email protected]> |
chore(cli): lazy load all env vars (#17082)
* chore(cli): lazy load all env vars
lazily loading all environment variables makes it easier to test different cases since you can change the value of
chore(cli): lazy load all env vars (#17082)
* chore(cli): lazy load all env vars
lazily loading all environment variables makes it easier to test different cases since you can change the value of things like `CI` between tests.
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
98ecfc87 |
| 24-Mar-2022 |
James Ide <[email protected]> |
[lint] Add "caughtErrors: 'all'" to linter config (#16591)
Why
---
ES2019 added "optional catch bindings" so that `e`/`error`/etc. don't need to be specified in catch clauses if the thrown value i
[lint] Add "caughtErrors: 'all'" to linter config (#16591)
Why
---
ES2019 added "optional catch bindings" so that `e`/`error`/etc. don't need to be specified in catch clauses if the thrown value isn't used. This changes our lint rules to warn if unnecessary error variables are declared. https://2ality.com/2017/08/optional-catch-binding.html.
In JS, as opposed to TS, we allow unused catch bindings if the variable names are prefixed with an underscore. This is so that JS targeting older JS interpreters can write `catch (_) {}` if needed. With TS we disallow unused catch bindings since tsc can compile code to its target JS version.
How
---
Added `caughtErrors: 'all'` to the no-unused-vars rule's configuration. As part of this change, I made the TypeScript linting rules apply only to .ts/.tsx/.ts.d files and updated the unit test snapshots.
Test Plan
---
Added unit tests to the linter. Ran linter over all modules in this repo with expotools.
show more ...
|
| #
8d307f52 |
| 23-Mar-2022 |
Evan Bacon <[email protected]> |
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* f
chore: refactor `expo/cli` to `@expo/cli` package (#16717)
* chore: refactor `expo/cli` to `@expo/cli` package
* Update CODEOWNERS
* fix linking
* fix lint script
* fix build file
* fix e2e tests
* lint before build
* use mock version
show more ...
|