| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
6fb32ddd |
| 13-Jun-2023 |
Keith Kurak <[email protected]> |
[cli] Add dependency exclusion to `npx expo install` (#22736)
# Why
Fulfills
https://linear.app/expo/issue/ENG-8564/add-dependency-exclusion-to-npx-expo-install.
Developers will be able to suppre
[cli] Add dependency exclusion to `npx expo install` (#22736)
# Why
Fulfills
https://linear.app/expo/issue/ENG-8564/add-dependency-exclusion-to-npx-expo-install.
Developers will be able to suppress warnings from `npx expo install
--check` via a package.json config, and thus suppress doctor warnings
when they intentionally choose to install a different version,
especially when using dev builds and not needing to stick to the Expo
Go- bundled version.
# How
`npx expo install --check|fix` reads from `expo.install.exclude` if it's
available, and, if one of the packages it thinks it should fix is in
that list, it will skip asking/ fixing it. If you run `EXPO_DEBUG=1 npx
expo install --check`, the packages whose checks were actually skipped
will be listed in debug output; otherwise there are no warnings or
messages about the excluded packages.
The package.json configuration verbiage is intended to be similar to the
[autolinking
config](https://docs.expo.dev/modules/autolinking/#exclude).
~~It also seemed appropriate that `npx expo install` should behave
differently if you try to install an excluded package, so someone
doesn't come along and write over a version that another developer
determined was good and thus applied the override for. Currently, it
aborts if any of the packages are in the exclusion list. I could see
doing a warning and skipping the affected packages instead, but the
command outright failing is pretty hard to miss.~~
`npx expo install` now installs excluded packages with the latest
version, just like a package without a specified native version. It will
add a note describing what it's doing and why.
# Test Plan
- [x] test without `expo.install.exclude` (works the same)
- [x] test with empty exclusion list (works the same)
- [x] test with exclusions that aren't actual dependencies (works the
same)
- [x] test `expo install --fix|check` when excluding an actual
dependency (skips it)
- [x] test with `EXPO_DEBUG=1` (lists excluded packages)
- [x] test `expo install [package]` with exclusions (installs latest
with notes)
- [x] test `expo install [package]` without exclusions (proceeds as it
normally does)
## Output
`npx expo install --check`, showing note that it is skipping checking
packages in the exclude list:
<img width="884" alt="image"
src="https://github.com/expo/expo/assets/8053974/30cef729-af18-44cb-98ef-11fc9729ae3d">
Additional debug output for `EXPO_DEBUG=1 npx expo install --check`:
<img width="904" alt="image"
src="https://github.com/expo/expo/assets/8053974/9096a939-066c-431b-a467-6d3d70ef448d">
`expo install <package>` with exclusions:
<img width="932" alt="image"
src="https://github.com/expo/expo/assets/8053974/d51e9e5a-cc59-4aa4-9cb6-4a2294b01ccc">
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Brent Vatne <[email protected]>
show more ...
|
| #
8d3f3824 |
| 13-Feb-2023 |
Cedric van Putten <[email protected]> |
refactor(package-manager)!: extend the API and provide access to spawn child (#18576)
# Why
Fixes ENG-7545
This proposal PR changes the API of the (node) package managers, with
the goal of:
refactor(package-manager)!: extend the API and provide access to spawn child (#18576)
# Why
Fixes ENG-7545
This proposal PR changes the API of the (node) package managers, with
the goal of:
- Having the right API options to install/remove packages to
`dependencies`/`devDependencies`/global deps
- Having access to the actual `spawnAsync` child, to pipe logs into
different systems (for example in EAS build)
- Allowing us to fix a couple of annoying DX issues (see follow up PRs)
> This is further outlined in the Package Manager API proposal.
Before merging this one, we need to merge these other PRs to not-break
`main`. Any feedback on the proposal is welcome, especially while in
draft.
- https://github.com/expo/expo/pull/19343
- https://github.com/expo/expo/pull/19344
# How
See Package Manager API proposal.
# Test Plan
> These changes are backward incompatible and require a new version
update.
This change also allowed us to implement the following fixes (all
stacked PRs):
- https://github.com/expo/expo/pull/19343
- https://github.com/expo/expo/pull/19344
- https://github.com/expo/expo/pull/19342
- https://github.com/expo/expo/pull/19340
- https://github.com/expo/expo/pull/19341
- https://github.com/expo/expo/pull/19764
- https://github.com/expo/expo/pull/19835
- https://github.com/expo/expo/pull/21189
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
29128565 |
| 27-Jul-2022 |
Evan Bacon <[email protected]> |
feat(cli): disable prompts in non interactive processes (#18300)
* feat(cli): disable prompts in non interactive processes
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <34
feat(cli): disable prompts in non interactive processes (#18300)
* feat(cli): disable prompts in non interactive processes
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update startAsync.ts
* fix tests
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
474a7a4b |
| 21-Jun-2022 |
Evan Bacon <[email protected]> |
chore(cli): migrate to debug package (#17084)
* chore(cli): migrate to debug package
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]
chore(cli): migrate to debug package (#17084)
* chore(cli): migrate to debug package
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update checkPackages.ts
* Update packages/@expo/cli/src/start/platforms/android/ADBServer.ts
* Update ADBServer.ts
* Update activateWindow.ts
* Update adb.ts
* migrate new methods to debug
* Update variadic.ts
* Update yarn.lock
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
6caf5755 |
| 12-May-2022 |
Evan Bacon <[email protected]> |
feat(cli): add `--pnpm` option to `install` and `prebuild` command (#17366)
* feat(cli): add `--pnpm` option to `install` command
* Added pnpm support to prebuild command
* Update resolveOptio
feat(cli): add `--pnpm` option to `install` and `prebuild` command (#17366)
* feat(cli): add `--pnpm` option to `install` command
* Added pnpm support to prebuild command
* Update resolveOptions-test.ts
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update resolveOptions-test.ts
* update help
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
fbfc1f73 |
| 20-Apr-2022 |
Evan Bacon <[email protected]> |
fix(cli) fix typecheck (#17145)
* fix typecheck
* Update CHANGELOG.md
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
Co-au
fix(cli) fix typecheck (#17145)
* fix typecheck
* Update CHANGELOG.md
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
c94ad8a2 |
| 15-Apr-2022 |
Evan Bacon <[email protected]> |
feat(cli): add `--check` and `--fix` flags to install command (#17048)
* feat(cli): add `--check` and `--fix` flags to install command
Add a flag `--check` which runs the doctor check against the
feat(cli): add `--check` and `--fix` flags to install command (#17048)
* feat(cli): add `--check` and `--fix` flags to install command
Add a flag `--check` which runs the doctor check against the installed packages, then prompt to install the corrected packages. If the command is run in CI then no prompt will be given and the process with exit with non-zero exit code (1).
Additionally adds the `--fix` flag which skips the prompt and exiting behavior. This can be used in CI to naively ensure packages are always correct: `npx expo install --fix`.
In this logical scenario `--fix` acts as a more privileged version of `--check`. Meaning the flags should never be used together. I also considered the inverse structure `--fix --dry-run` which would act the same as `--check` but would allow for coherency in the arguments since you would have less of a chance to provide bad arguments.
I opted for the `--check` flag for this initial commit because it allows for the interactive prompt to fix when run outside of CI, and acts as expected in CI. Whereas `--dry-run` exiting with non-zero seems unexpected as running without `--dry-run` would not exit with non-zero (unless for some unrelated error).
This feature also combines all three sources for known versions before doing validation, this means the check run during `start` will utilize the same sources as the install check.
In addition, I've also added `react-native`, `react`, `react-dom`, and `react-native-web` to the `bundledNativeModules.json` so the React versions are all checked as well.
The result is a unified validation system across the CLI.
This feature supersedes the `expo doctor --fix-dependencies` command, while adding the additional ability to check/fix only a certain set of packages, i.e. `npx expo install react-native --check`
* Update CHANGELOG.md
* skip installing when all dependencies are fine
* testing install check
* fix tests
* added install e2e tests
* Update CHANGELOG.md
* Update validateDependenciesVersions-test.ts
* Update packages/expo/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* Update getMissingPackages-test.ts
* Update install-test.ts
* Update install-test.ts
* Update react-native
Co-authored-by: Expo Bot <[email protected]>
show more ...
|