| #
edeec536 |
| 06-Sep-2023 |
Evan Bacon <[email protected]> |
chore(cli): delete @expo/dev-server (#24272)
# Why
- I tried this before but the logs endpoint was blocking it.
- I forked the dev server when I wrote the original `expo/cli`, been
meaning to d
chore(cli): delete @expo/dev-server (#24272)
# Why
- I tried this before but the logs endpoint was blocking it.
- I forked the dev server when I wrote the original `expo/cli`, been
meaning to delete the original for a while. The duplicate code and
indirection is making the new server features harder to implement.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Copy/paste remaining code from `@expo/dev-server` in to `@expo/cli`.
- Delete `@expo/dev-server`.
- Drop unused `/logs` and json parser middleware.
- Drop logging mocks.
- Drop experimental Webpack native support.
- Drop legacy react-native middleware support (no longer needed since
everything is versioned).
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- Tests should keep passing.
- Need to do some actual runs since there aren't any e2e tests for
various parts of dev-server.
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
1a3d836e |
| 22-May-2023 |
Evan Bacon <[email protected]> |
feat(cli): Add `--no-minify` flag to `npx expo export` to prevent minifying output JavaScript. (#22544)
# Why
Nice feature to have for debugging.
# How
- Add the `--no-minify` flag to `npx
feat(cli): Add `--no-minify` flag to `npx expo export` to prevent minifying output JavaScript. (#22544)
# Why
Nice feature to have for debugging.
# How
- Add the `--no-minify` flag to `npx expo export`.
- Forward the flag to all Metro invocations.
- Also noticed that in some places, we were minifying Node.js code which
doesn't matter, so now we always skip minification when creating static
functions.
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- `npx expo export --no-minify` -> JS and CSS is not minified.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
8be9689f |
| 08-May-2023 |
evanbacon <[email protected]> |
Revert "feat(metro-config): add web sourcemap support (#22334)"
This reverts commit d8e77756248549b2932cdc8911688f7ef09fb177.
|
| #
d8e77756 |
| 08-May-2023 |
Evan Bacon <[email protected]> |
feat(metro-config): add web sourcemap support (#22334)
# Why
- ensure exporting sourcemaps on web strips out the sourcemap tags when
sourcemaps aren't generated.
- ensure sourcemaps are relativ
feat(metro-config): add web sourcemap support (#22334)
# Why
- ensure exporting sourcemaps on web strips out the sourcemap tags when
sourcemaps aren't generated.
- ensure sourcemaps are relative on web in production when produced (may
revert).
- ensure web sources don't use `.bundle` in map URLs.
- ensure web source maps are placed in the new generated folder
`dist/_expo`.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
9580591f |
| 30-Apr-2023 |
Evan Bacon <[email protected]> |
feat(metro-config, cli): CSS serializer (#22325)
# Why
In order to support static CSS in development mode, we need to update
the metro serializer to support returning the JS and CSS assets. We n
feat(metro-config, cli): CSS serializer (#22325)
# Why
In order to support static CSS in development mode, we need to update
the metro serializer to support returning the JS and CSS assets. We now
inline the CSS in the HTML before sending to the client, this allows for
testing how the website works with JS disabled. We use the same style
tag id to continue to support HMR for styles during subsequent updates.
This change also refactors how exports work to serialize JS and CSS at
the same time (i.e. after the native transformations).
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
0a6ddb20 |
| 13-Mar-2023 |
Evan Bacon <[email protected]> |
feat(cli): add basic static rendering for router projects (#21572)
# Why
- Implement an experimental static rendering system for Metro websites
using Expo Router.
- Behavior is undocumented and
feat(cli): add basic static rendering for router projects (#21572)
# Why
- Implement an experimental static rendering system for Metro websites
using Expo Router.
- Behavior is undocumented and highly experimental.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# How
- Add support to `start` and `export` which pre-renders static web pages
to HTML to improve SEO support on web.
- The system implements [React Navigation's
SSR](https://reactnavigation.org/docs/server-rendering) support.
- Head elements can be used with `import { Head } from
'expo-router/head'`.
- The root HTML is not exposed to the user.
- There are no data fetching mechanisms.
- There's no ability to provide a 404 page or other server features.
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
- e2e test for exporting a router project statically.
- `EXPO_USE_STATIC=1 yarn expo` -> websites are pre-rendered before
being served.
- `EXPO_USE_STATIC=1 yarn expo export -p web` -> static routes are
rendered to static HTML files by the same name (dynamic routes are not
supported).
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
5404abc1 |
| 14-Feb-2023 |
Evan Bacon <[email protected]> |
Close config file watchers to ensure process can exit. (#21199)
# Why
This was a bug and now it's fixed.
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test P
Close config file watchers to ensure process can exit. (#21199)
# Why
This was a bug and now it's fixed.
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
Start and stop the dev server in `expo start`, this should now
completely close and not hang open.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
dc51e206 |
| 27-Apr-2022 |
Evan Bacon <[email protected]> |
feat(cli): add `export` command (#17034)
* feat(cli): add export command
* Update CHANGELOG.md
* update tests
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <34669131+
feat(cli): add `export` command (#17034)
* feat(cli): add export command
* Update CHANGELOG.md
* update tests
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
* reduce interface
* refactor
refactor
refactor
* refactor
* remove all merging code
* drop aliases
* Added asset saving tests
* refactor export code up
* Update env.ts
* Drop unused
* added e2e tests
* Dropped --quiet flag
* PR Feedback
* fix tests
* fix export tests
* Update export-test.ts
Co-authored-by: Expo Bot <[email protected]>
show more ...
|