| #
cfdef4bc |
| 03-Mar-2023 |
Will Schurman <[email protected]> |
[exupdates][ios] Fix some issues from landed swift conversion PRs (#21519)
# Why
These issues were introduced in some of the recently-landed swift
conversion PRs. Due to the flakiness of the CI
[exupdates][ios] Fix some issues from landed swift conversion PRs (#21519)
# Why
These issues were introduced in some of the recently-landed swift
conversion PRs. Due to the flakiness of the CI jobs they weren't
caught/trusted.
# How
Caught these when trying to run an app in expo go.
# Test Plan
Run expo go, open experience, see it works now.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
ae827301 |
| 01-Mar-2023 |
Will Schurman <[email protected]> |
[expo-updates][ios] Convert selection policies to swift (#21394)
# Why
This converts EXUpdatesSelectionPolicy stuff to swift.
# How
Manually convert.
# Test Plan
Run all tests (will u
[expo-updates][ios] Convert selection policies to swift (#21394)
# Why
This converts EXUpdatesSelectionPolicy stuff to swift.
# How
Manually convert.
# Test Plan
Run all tests (will update tests in a follow-up PR to ensure they don't
both break accidentally).
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
5697f03e |
| 01-Mar-2023 |
Will Schurman <[email protected]> |
[expo-updates][ios] Convert EXUpdatesConfig to swift (#21391)
# Why
Converting one more class to swift.
# How
Convert manually.
# Test Plan
Run all tests and build.
# Checklist
[expo-updates][ios] Convert EXUpdatesConfig to swift (#21391)
# Why
Converting one more class to swift.
# How
Convert manually.
# Test Plan
Run all tests and build.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
7c3ed0c0 |
| 14-Dec-2022 |
Douglas Lowder <[email protected]> |
[Expo Go][iOS] No remote home app loads in release builds (#20416)
# Why
Per ENG-7047, we need to disable remote loading of home app, and
checking for home app updates, for release builds.
Upda
[Expo Go][iOS] No remote home app loads in release builds (#20416)
# Why
Per ENG-7047, we need to disable remote loading of home app, and
checking for home app updates, for release builds.
Updates and loading from the packager will still work in debug builds.
# How
Add `#ifdef DEBUG` in several places in
`Exponent/Kernel/AppLoader/EXAppLoader.m`
# Test Plan
- CI should pass
- Test Expo Go builds locally and verify that updates are not loaded,
and that nothing else is broken
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|