| #
51e273e0 |
| 14-Sep-2023 |
Tomasz Sapeta <[email protected]> |
[file-system][iOS] Migrate to Expo Modules API (#23943)
|
| #
2d9e7c30 |
| 20-Feb-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[file-system][ios] Add UTF-8 URI support (#21196)
# Why
Closes https://github.com/expo/expo/issues/10476
# How
This PR updates all iOS local uri instances (NSURL) to parse them using
percent
[file-system][ios] Add UTF-8 URI support (#21196)
# Why
Closes https://github.com/expo/expo/issues/10476
# How
This PR updates all iOS local uri instances (NSURL) to parse them using
percent-encoded characters when necessary, that way we're able to
support paths like `fs.documentDirectory + "中文"`.
The main difference from https://github.com/expo/expo/pull/21098 is that
this PR uses a similar approach to
https://github.com/expo/expo/pull/21139, where we first decode the input
URI to ensure we don't double-encode it. It also uses
`stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet
URLPathAllowedCharacterSet]` instead of `fileURLWithPath` and keeps the
original scheme in place.
# Test Plan
Added unit test support to the EXFileSystem module, just testing
`percentEncodeURIStringAfterScheme` for now, and updated
`apps/test-suite/tests/FileSystem.js` to include a `Create UTF-8 uri`
test.
https://user-images.githubusercontent.com/11707729/217058407-3ff04176-2b72-43f9-803c-6a097f0a79ee.mov
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
22d1e005 |
| 05-Jan-2022 |
Bartosz Kaszubowski <[email protected]> |
[test-suite] lint files, add lint check to CI (#15772)
|
| #
19cbf4dc |
| 18-Aug-2021 |
Bartłomiej Bukowski <[email protected]> |
[apps] Replace `@unimodules/*` imports with `expo-modules-core` (#14079)
|
| #
f62bacca |
| 25-Jun-2021 |
andy <[email protected]> |
[android] SDK 42 Versioned QA (#13326)
|
| #
df3ae3b5 |
| 11-Jun-2021 |
andy <[email protected]> |
[android][qa] minor fixes for test-suite and NCL (#13262)
|
| #
d12a8680 |
| 03-Jul-2020 |
Łukasz Kosmaty <[email protected]> |
[expo-file-system] Fix `getInfo` returning incorrect size when provided path points to folder (#9063)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
| #
3ba2b94b |
| 01-Jun-2020 |
Łukasz Kosmaty <[email protected]> |
[expo-file-system] The background session doesn't fail if connection is down (#8593)
* [expo-file-system] Fix test-suite & update docs
* Update filesystem.md
Co-authored-by: Tomasz Sapeta <171
[expo-file-system] The background session doesn't fail if connection is down (#8593)
* [expo-file-system] Fix test-suite & update docs
* Update filesystem.md
Co-authored-by: Tomasz Sapeta <[email protected]>
Co-authored-by: Tomasz Sapeta <[email protected]>
show more ...
|
| #
8cb96155 |
| 18-Sep-2019 |
Evan Bacon <[email protected]> |
universal core tests (#5587)
* Run core tests on web/native e2e
* Use universal testing for expo-file-system
* Add universal tests to expo-font
* Update TestSuite-test.native.js
* Remove
universal core tests (#5587)
* Run core tests on web/native e2e
* Use universal testing for expo-file-system
* Add universal tests to expo-font
* Update TestSuite-test.native.js
* Removed extra pods
* Update TestUtils.js
* Update SelectScreen.js
* Added tests back
* Removed SVG
show more ...
|
| #
a47a1472 |
| 14-May-2019 |
Ville Immonen <[email protected]> |
[ncl][test-suite] Change imports to SDK 33 syntax with the codemod (#4219)
* [ncl][test-suite] Change imports to SDK 33 syntax with the codemod
* [ncl][test-suite] Add new imported packages to de
[ncl][test-suite] Change imports to SDK 33 syntax with the codemod (#4219)
* [ncl][test-suite] Change imports to SDK 33 syntax with the codemod
* [ncl][test-suite] Add new imported packages to dependencies
show more ...
|
| #
d7aba270 |
| 07-May-2019 |
Dominik Sokal <[email protected]> |
[ios][android][test-suite][docs] throw an error when downloading a fi… (#4142)
* [ios][android][test-suite][docs] throw an error when downloading a file to nonexistent local directory
* update CH
[ios][android][test-suite][docs] throw an error when downloading a fi… (#4142)
* [ios][android][test-suite][docs] throw an error when downloading a file to nonexistent local directory
* update CHANGELOG.md
show more ...
|
| #
fec220cb |
| 18-Apr-2019 |
Sergei Chestakov <[email protected]> |
Add AWS Devicefarm job back into CI (#3996)
* Publish to commit SHA instead of branch name
* Add android devicefarm job back into client workflow in CI
* Combine Basic tests and remove the one
Add AWS Devicefarm job back into CI (#3996)
* Publish to commit SHA instead of branch name
* Add android devicefarm job back into client workflow in CI
* Combine Basic tests and remove the ones that fail
* Fix Import test by not using default import
* Show the number of tests failed in TestScreen
* Fix typo in FileSystem that caused test to fail
* Uncomment and fix remaining FileSystem tests
* Fix Camera roll permissions in FileSystem test
* Add Audio recording permissions test
* Fix Recording tests
staysActiveInBackground is a required attribute on the front end and there was a typo in the isMissingAudioRecordingPermissions function which prevented the tests from running because the module rejected the promise on the basis that the required permissions were not met when they actually were
* Accept Camera Roll permissions in FileSystem test
* Move acceptPermissions to beforeAll in FileSystem
* Remove/document the tests that fail in CI
* Stop running Audio tests in CI
show more ...
|
| #
6cfa9c5f |
| 29-Mar-2019 |
Sergei Chestakov <[email protected]> |
Fix error handling in makeDirectoryAsync method on Android. Resolves #3823. (#3865)
* Fix error handling in makeDirectoryAsync method on Android
This commit changes the behavior of the makeDirect
Fix error handling in makeDirectoryAsync method on Android. Resolves #3823. (#3865)
* Fix error handling in makeDirectoryAsync method on Android
This commit changes the behavior of the makeDirectoryAsync method in the
FileSystem module on Android to not throw an error when the directory
already exists and intermediates is set to true.
This will be consistent with the behavior of the iOS implementation as
well as the expected behavior of `mkdir -p` on Unix systems. Resolves #3823.
In this commit, I've included a test in the test-suite to make sure no
error is thrown when makeDirectoryAsync is called twice in a row with
intermediates set to true. The other tests that call
makeDirectoryAsync seem to cover the other edge cases. I've also
updated the docs to reflect this change.
* Update error message in makeDirectoryAsync
show more ...
|
| #
67f55e2b |
| 25-Oct-2018 |
Stanisław Chmiela <[email protected]> |
Test suite fixes (#2433)
* [tests] Fix a couple of issues in Expo SDK and test-suite
- Add .db as an asset extension of expo-yarn-workspaces
- Fix NSNumber issues in EXFileSystem when manipulati
Test suite fixes (#2433)
* [tests] Fix a couple of issues in Expo SDK and test-suite
- Add .db as an asset extension of expo-yarn-workspaces
- Fix NSNumber issues in EXFileSystem when manipulating files with Base64 encoding
- Fix timing issues in test-suite
* Fix review comment
* Run yarn install v1.10.1
[1/4] Resolving packages...
success Already up-to-date.
$ expo-module prepare
Done in 3.25s.
show more ...
|
| #
2bd74c95 |
| 01-Oct-2018 |
Evan Bacon <[email protected]> |
Added: Support for Base64 (#2328)
|
| #
740b3867 |
| 18-Aug-2018 |
James Ide <[email protected]> |
Move test-suite into the Expo repo under apps
This moves test-suite into the Expo repo, setting things up so that CI can verify changes to modules using test-suite.
Tested by loading and running te
Move test-suite into the Expo repo under apps
This moves test-suite into the Expo repo, setting things up so that CI can verify changes to modules using test-suite.
Tested by loading and running test-suite with `expu start` for now. Also will check that our CI passes since there are some dependencies on test-suite (e.g. publishing it). Before merging, the shipit bot needs to be redeployed as well and may need some manual repo editing inside its container.
fbshipit-source-id: 144e1bd
show more ...
|